BBC: blead breaks B::Hooks::Parser #16603
Comments
From @jkeenanAs first reported by cguevara on #p5p: ##### Excerpt from cpanm build.log file built at b1d2191 attached. Currently bisecting. Thank you very much. |
From @jkeenancpanm (App::cpanminus) 1.7044 on perl 5.029001 built for x86_64-linux # Failed test 'use B::Hooks::Parser;' # Failed test 'use B::Hooks::Parser;' # Failed test at t/toke.t line 7. # Failed test at t/toke.t line 8. Test Summary Report t/basic.t (Wstat: 65280 Tests: 1 Failed: 1) |
From @jkeenanSummary of my perl5 (revision 5 version 29 subversion 1) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Sun, 01 Jul 2018 19:55:58 GMT, jkeenan@pobox.com wrote:
Bisection points to: ##### Remove some deprecated functions from mathoms.c :100644 100644 7c606f4b5c8af86d8d70d39c415609d3cb11cf8a 0f06e3802461f786132c7b3f914b311a217c6573 M embed.fnc Is this a case where upstream module has to be revised due to core functionality no longer available? Thank you very much. -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @khwilliamsonThe breakage is in the aptly named file 'stolen_chunk_of_toke.c'. It's using ancient code to try to duplicate our parsing. The deprecated function removed is 'is_utf8_mark()' Unicode quite a few releases ago moved away from using marks, so this parsing is also obsolete. I think the code should update to steal a more modern chunk of toke.c, and drop its obsolete use. If there were a way to avoid stealing that would be better. I would be happy to work with the maintainers to try to come up with an API function that they could use instead. -- |
From @karenetheridgeOn Sun, 01 Jul 2018 13:40:52 -0700, khw wrote:
I would be grateful to apply any patches that anyone proposes. |
From @smpetersOnce upon a time, we had discussed including NO_MATHOMS in smoke tests against a decent subset of CPAN to find modules using deprecated APIs. This would have caught this problem a while ago. |
From [Unknown Contact. See original ticket]Once upon a time, we had discussed including NO_MATHOMS in smoke tests against a decent subset of CPAN to find modules using deprecated APIs. This would have caught this problem a while ago. |
From @jkeenanOn Thu, 05 Jul 2018 16:10:06 GMT, stmpeters wrote:
What would be the arguments for ./Configure in that case? -- |
From @khwilliamsonOn 07/05/2018 11:45 AM, James E Keenan via RT wrote:
Add -Accflags='-DNO_MATHOMS' |
1 similar comment
From @khwilliamsonOn 07/05/2018 11:45 AM, James E Keenan via RT wrote:
Add -Accflags='-DNO_MATHOMS' |
From @khwilliamsonI believe that this has been fixed for 5.30 by Revert "Remove some deprecated functions from mathoms.c" Could someone verify. This will be a problem in 5.32, and I will work with Karen to come up with an API to keep this from having to steal core code that can be obsoleted. |
From @jkeenanOn Tue, 26 Mar 2019 20:42:10 GMT, khw wrote:
For me, at least, it is not fixed. ##### $ ./bin/perl -v | head -2 | tail -1 $ ./bin/perl -Ilib -V:config_args ## From the .cpanm build.log Building and testing B-Hooks-Parser-0.19 In file included from /home/jkeenan/testing/blead/lib/perl5/5.29.10/x86_64-linux/CORE/perl.h:2495:0, In file included from Parser.xs:12:0: [snip] # # Failed test 'use B::Hooks::Parser;' # Failed test 'use B::Hooks::Parser;' # Failed test at t/toke.t line 7. # Failed test at t/toke.t line 8. Test Summary Report t/basic.t (Wstat: 65280 Tests: 1 Failed: 1) |
From @jkeenanOn Tue, 26 Mar 2019 21:57:12 GMT, jkeenan wrote:
Similar failures on FreeBSD-11.2; build.log available on request. -- |
From @khwilliamsonOn 3/26/19 4:10 PM, James E Keenan via RT wrote:
I think you have -DNO_MATHOMS in your Configure. It works for me |
From @jkeenanOn Wed, 27 Mar 2019 03:52:04 GMT, public@khwilliamson.com wrote:
I do -- but isn't that what you asked us to test? Can you re-state the current bug -- and distinguish it from what might be a problem for 5.32 (next dev cycle)? Thank you very much. -- |
From @khwilliamsonOn 3/27/19 6:20 AM, James E Keenan via RT wrote:
I removed some deprecated functions earlier in 5.29. That broke this In the meantime, however, you started using -DNO_MATHOMS, and that And the intent is to actually proceed with the removal of the functions |
From @khwilliamsonOn Wed, 27 Mar 2019 09:47:14 -0700, public@khwilliamson.com wrote:
I have pushed to blead Make a few parse fcns accessible to B::Hooks::Parser -- |
1 similar comment
From @khwilliamsonOn Wed, 27 Mar 2019 09:47:14 -0700, public@khwilliamson.com wrote:
I have pushed to blead Make a few parse fcns accessible to B::Hooks::Parser -- |
From @khwilliamsonThe distro has now been released with the changes needed, so closing this ticket |
|
@khwilliamson - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been Perl 5.30.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
p5pRT
added
BBC
Migrated from rt.perl.org#133318 (status was 'resolved')
Searchable as RT133318$
The text was updated successfully, but these errors were encountered: