Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] utf8.c: use TRUE not true #16538

Closed
p5pRT opened this issue Apr 28, 2018 · 8 comments
Closed

[PATCH] utf8.c: use TRUE not true #16538

p5pRT opened this issue Apr 28, 2018 · 8 comments
Labels
type-core

Comments

@p5pRT
Copy link

p5pRT commented Apr 28, 2018

Migrated from rt.perl.org#133158 (status was 'resolved')

Searchable as RT133158$
@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2018

From @bulk88

Created by @bulk88

I'll put the patch up through RT because I know this email will be spam
trapped otherwise. This patch is for 5.28. A commit pushed on 4-20-18
broke my build.

Perl Info 
---
Flags:
                category=core
                severity=low
---
Site configuration information for perl 5.27.9:

Configured by Administrator at Tue Jan 30 20:34:30 2018.

Summary of my perl5 (revision 5 version 27 subversion 9) configuration:

              Platform:
                osname=MSWin32
                osvers=5.2.3790
                archname=MSWin32-x86-multi-thread
                uname=''
                config_args='undef'
                hint=recommended
                useposix=true
                d_sigaction=undef
                useithreads=define
                usemultiplicity=define
                use64bitint=undef
                use64bitall=undef
                uselongdouble=undef
                usemymalloc=n
                default_inc_excludes_dot=define
                bincompat5005=undef
              Compiler:
                cc='cl'
                ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL -DWIN32
-D_CONSOLE -DNO_STRICT -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_NONSTDC_NO_DEPRECATE  -DPERL_TEXTMODE_SCRIPTS
-DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DWIN32_NO_REGISTRY'
                optimize='-O1 -MD -Zi -DNDEBUG -GL'
                cppflags='-DWIN32'
                ccversion='15.00.30729.01'
                gccversion=''
                gccosandvers=''
                intsize=4
                longsize=4
                ptrsize=4
                doublesize=8
                byteorder=1234
                doublekind=3
                d_longlong=undef
                longlongsize=8
                d_longdbl=define
                longdblsize=8
                longdblkind=0
                ivtype='long'
                ivsize=4
                nvtype='double'
                nvsize=8
                Off_t='__int64'
                lseeksize=8
                alignbytes=8
                prototype=define
              Linker and Libraries:
                ld='link'
                ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf -ltcg
-libpath:"c:\perl\lib\CORE"        -machine:x86'
                libpth="C:\Program Files (x86)\Microsoft Visual Studio
9.0\VC\lib"
                libs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
                perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
                libc=msvcrt.lib
                so=dll
                useshrplib=true
                libperl=perl527.lib
                gnulibc_version=''
              Dynamic Linking:
                dlsrc=dl_win32.xs
                dlext=dll
                d_dlsymun=undef
                ccdlflags=' '
                cccdlflags=' '
                lddlflags='-dll -nologo -nodefaultlib -debug -opt:ref,icf
-ltcg
                -libpath:"c:\perl\lib\CORE"        -machine:x86'


---
@INC for perl 5.27.9:
                lib
                C:/p527/srcnew/lib

---
Environment for perl 5.27.9:
                CYGWIN=tty
                HOME (unset)
                LANG (unset)
                LANGUAGE (unset)
                LD_LIBRARY_PATH=/usr/lib/x86:/usr/X11R6/lib
                LOGDIR (unset)
                PATH=C:\WINDOWS\system32;C:\Program Files (x86)\Microsoft
Visual
Studio 9.0\VC\BIN;C:\Program Files\Microsoft
SDKs\Windows\v6.0A\bin;C:\Perl\bin;C:\WINDOWS;C:\Program Files
(x86)\Microsoft Visual Studio 9.0\Common7\IDE;C:\Program Files
(x86)\Git\bin;C:\sp3220\c\bin;
                PERL_BADLANG (unset)
                SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2018

From @bulk88

On Fri, 27 Apr 2018 18​:13​:40 -0700, bulk88 wrote​:

This is a bug report for perl from bulk88@​hotmail.com,
generated with the help of perlbug 1.41 running under perl 5.27.9.

-----------------------------------------------------------------
[Please describe your issue here]

I'll put the patch up through RT because I know this email will be spam
trapped otherwise. This patch is for 5.28. A commit pushed on 4-20-18
broke my build.

patch attached

--
bulk88 ~ bulk88 at hotmail.com

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2018

From @bulk88

0001-utf8.c-use-TRUE-not-true.patch 
From 8bb24583ff62c24d39e658cda4474dad46bf84df Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Fri, 27 Apr 2018 21:09:49 -0400
Subject: [PATCH] utf8.c: use TRUE not true

"true" token was added in commit 394d2d3f37 but "true" is C++ and C99,
"TRUE" is portable perl API

Win32 VC 2003 C mode (C89) build faiure
..\utf8.c(6177) : error C2065: 'true' : undeclared identifier
---
 utf8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utf8.c b/utf8.c
index e66c328..ceb4723 100644
--- a/utf8.c
+++ b/utf8.c
@@ -6174,7 +6174,7 @@ Perl_parse_uniprop_string(pTHX_ const char * const name, const Size_t len, const
             return NULL;
         }
 
-        starts_with_In_or_Is = true;
+        starts_with_In_or_Is = TRUE;
     }
 
     /* Get the index into our pointer table of the inversion list corresponding
-- 
2.5.0.windows.1

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2018

From @jkeenan

On Sat, 28 Apr 2018 01​:15​:08 GMT, bulk88 wrote​:

On Fri, 27 Apr 2018 18​:13​:40 -0700, bulk88 wrote​:

This is a bug report for perl from bulk88@​hotmail.com,
generated with the help of perlbug 1.41 running under perl 5.27.9.

-----------------------------------------------------------------
[Please describe your issue here]

I'll put the patch up through RT because I know this email will be spam
trapped otherwise. This patch is for 5.28. A commit pushed on 4-20-18
broke my build.

patch attached

Karl, can you evaluate in relation to commit 394d2d3?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2018

From @khwilliamson

On 04/27/2018 07​:59 PM, James E Keenan via RT wrote​:

On Sat, 28 Apr 2018 01​:15​:08 GMT, bulk88 wrote​:

On Fri, 27 Apr 2018 18​:13​:40 -0700, bulk88 wrote​:

This is a bug report for perl from bulk88@​hotmail.com,
generated with the help of perlbug 1.41 running under perl 5.27.9.

-----------------------------------------------------------------
[Please describe your issue here]

I'll put the patch up through RT because I know this email will be spam
trapped otherwise. This patch is for 5.28. A commit pushed on 4-20-18
broke my build.

patch attached

Karl, can you evaluate in relation to commit 394d2d3?

Thank you very much.

I agree with bulk88

@p5pRT
Copy link
Author

p5pRT commented Apr 30, 2018

From @iabyn

On Fri, Apr 27, 2018 at 09​:35​:42PM -0600, Karl Williamson wrote​:

On 04/27/2018 07​:59 PM, James E Keenan via RT wrote​:

On Sat, 28 Apr 2018 01​:15​:08 GMT, bulk88 wrote​:

On Fri, 27 Apr 2018 18​:13​:40 -0700, bulk88 wrote​:

This is a bug report for perl from bulk88@​hotmail.com,
generated with the help of perlbug 1.41 running under perl 5.27.9.

-----------------------------------------------------------------
[Please describe your issue here]

I'll put the patch up through RT because I know this email will be spam
trapped otherwise. This patch is for 5.28. A commit pushed on 4-20-18
broke my build.

patch attached

Karl, can you evaluate in relation to commit 394d2d3?

Thank you very much.

I agree with bulk88

Now in as v5.27.11-23-ga161cde74a

--
Never work with children, animals, or actors.

@p5pRT
Copy link
Author

p5pRT commented Apr 30, 2018

@iabyn - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT