New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blead Breaks CPAN: ADAMK/SQL-String-0.02.tar.gz #16393
Comments
From @eserteThis is a bug report for perl from slaven@rezic.de, The test suite of SQL-String-0.02 started to fail with 5.27.7 ... On first glance it seems that we have now a warning more than Flags: Site configuration information for perl 5.27.8: Configured by eserte at Sat Jan 20 09:22:10 CET 2018. Summary of my perl5 (revision 5 version 27 subversion 8) configuration: @INC for perl 5.27.8: Environment for perl 5.27.8: |
From @jkeenanOn Mon, 29 Jan 2018 20:25:24 GMT, slaven@rezic.de wrote:
The additional warning is caught in a test related to overloading of the .= operator (approx test #47 in original). ##### Results under perl-5.26.0's prove: ##### Results under blead's prove: ##### -- |
The RT System itself - Status changed from 'new' to 'open' |
From @dur-randirOn Mon, 29 Jan 2018 12:25:24 -0800, slaven@rezic.de wrote:
Bisect points to d7e7503 is the first bad commit $overloaded .= $x: don't stringify $x RT #132385 This is a variant of the ($ref . $overloaded) bug which was fixed with Basically, when the overloaded concat method is called, it should pass |
From @iabynOn Tue, Jan 30, 2018 at 01:03:23AM -0800, Sergey Aleynikov via RT wrote:
The test case reduces to use warnings; which used to be silent, but now emits: Use of uninitialized value $x in concatenation (.) or string I'll look into this further when I can find some time. -- |
From @SmylersDave Mitchell writes:
Why is it wrong for that to warn? $x is undef, and is being supplied to the concatenation operator. Admittedly an overloaded operator that in this case doesn't care that it's undef, but why should Perl start presuming that undef-s are acceptable simply because an operator has been overloaded? I couldn't see anything in overload or in perldiag mentioning that this warning doesn't apply to an overloaded operation. Many uses of overloading are intended to be largely transparent to the user, so they may be surprised to not get a warning that they requested. Smylers |
From zefram@fysh.orgSmylers wrote:
The question is whether .= stringifies its rhs in this case. If it In fact both 5.26.0 and 5.27.8 are agreed: .= does not stringify the rhs -zefram |
From @iabynOn Wed, Jan 31, 2018 at 01:10:33PM +0000, Zefram wrote:
Now fixed in blead with: commit af39014 redo magic/overload handing in pp_multiconcat -- |
@iabyn - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#132783 (status was 'resolved')
Searchable as RT132783$
The text was updated successfully, but these errors were encountered: