Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBIish tests are failing spectacularly (JIT compilation of native calls) #6622

Open
p6rt opened this issue Oct 20, 2017 · 4 comments
Open

DBIish tests are failing spectacularly (JIT compilation of native calls) #6622

p6rt opened this issue Oct 20, 2017 · 4 comments
Labels
exotictest regression Issue did not exist previously SEGV Segmentation fault, bus error, etc. testneeded

Comments

@p6rt
Copy link

p6rt commented Oct 20, 2017

Migrated from rt.perl.org#132328 (status was 'new')

Searchable as RT132328$

@p6rt
Copy link
Author

p6rt commented Oct 20, 2017

From @AlexDaniel

DBIish tests started to fail (with segv) after this rakudo commit​:
rakudo/rakudo@ff063e7

The bump itself brought these MoarVM changes​:
MoarVM/MoarVM@2017.09.1-602-g676723d...2017.09.1-608-ge051ee3

Committable output before and after​:
command​: commit​: ff063e7b53^,ff063e7b53 https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
output​: https://gist.github.com/e25c6a14d6078e99f6bb46de494565b1

Not surprisingly there's no crash with MVM_JIT_DISABLE​:
command​: commit​: MVM_JIT_DISABLE=1 ff063e7b53^,ff063e7b53 https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
output​: https://gist.github.com/24319e448313c13c16d8b67d7961accb

@p6rt
Copy link
Author

p6rt commented Oct 20, 2017

From @AlexDaniel

Moar bisected to MoarVM/MoarVM@4eadf94

On 2017-10-20 07​:23​:04, alex.jakimenko@​gmail.com wrote​:

DBIish tests started to fail (with segv) after this rakudo commit​:
rakudo/rakudo@ff063e7

The bump itself brought these MoarVM changes​:
https://github.com/MoarVM/MoarVM/compare/2017.09.1-602-
g676723d...2017.09.1-608-ge051ee3

Committable output before and after​:
command​: commit​: ff063e7b53^,ff063e7b53
https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
output​: https://gist.github.com/e25c6a14d6078e99f6bb46de494565b1

Not surprisingly there's no crash with MVM_JIT_DISABLE​:
command​: commit​: MVM_JIT_DISABLE=1 ff063e7b53^,ff063e7b53
https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
output​: https://gist.github.com/24319e448313c13c16d8b67d7961accb

@p6rt
Copy link
Author

p6rt commented Oct 20, 2017

From @AlexDaniel

Offending commit reverted in MoarVM/MoarVM@1a9be0a

I tested it with moar HEAD and indeed the issue is no longer there. So it should work fine after moar and nqp bumps.

「testneeded」 ?

On 2017-10-20 07​:53​:23, alex.jakimenko@​gmail.com wrote​:

Moar bisected to
MoarVM/MoarVM@4eadf94

On 2017-10-20 07​:23​:04, alex.jakimenko@​gmail.com wrote​:

DBIish tests started to fail (with segv) after this rakudo commit​:

rakudo/rakudo@ff063e7

The bump itself brought these MoarVM changes​:
https://github.com/MoarVM/MoarVM/compare/2017.09.1-602-
g676723d...2017.09.1-608-ge051ee3

Committable output before and after​:
command​: commit​: ff063e7b53^,ff063e7b53

https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6

output​: https://gist.github.com/e25c6a14d6078e99f6bb46de494565b1

Not surprisingly there's no crash with MVM_JIT_DISABLE​:
command​: commit​: MVM_JIT_DISABLE=1 ff063e7b53^,ff063e7b53

https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6

output​: https://gist.github.com/24319e448313c13c16d8b67d7961accb

@p6rt
Copy link
Author

p6rt commented Feb 4, 2018

From @AlexDaniel

Honestly, I have no idea how to test this… maybe someone should attempt to golf it, but given that the commit description is “JIT compile native calls”, I guess it'd be a bit complicated.

… I'm fine with just delegating it to the DBIish test suite…

On 2017-10-20 08​:12​:41, alex.jakimenko@​gmail.com wrote​:

Offending commit reverted in
MoarVM/MoarVM@1a9be0a

I tested it with moar HEAD and indeed the issue is no longer there. So
it
should work fine after moar and nqp bumps.

「testneeded」 ?

On 2017-10-20 07​:53​:23, alex.jakimenko@​gmail.com wrote​:

Moar bisected to

MoarVM/MoarVM@4eadf94

On 2017-10-20 07​:23​:04, alex.jakimenko@​gmail.com wrote​:

DBIish tests started to fail (with segv) after this rakudo commit​:

rakudo/rakudo@ff063e7

The bump itself brought these MoarVM changes​:
https://github.com/MoarVM/MoarVM/compare/2017.09.1-602-
g676723d...2017.09.1-608-ge051ee3

Committable output before and after​:
command​: commit​: ff063e7b53^,ff063e7b53

https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6

output​: https://gist.github.com/e25c6a14d6078e99f6bb46de494565b1

Not surprisingly there's no crash with MVM_JIT_DISABLE​:
command​: commit​: MVM_JIT_DISABLE=1 ff063e7b53^,ff063e7b53

https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6

output​: https://gist.github.com/24319e448313c13c16d8b67d7961accb

@p6rt p6rt added exotictest regression Issue did not exist previously SEGV Segmentation fault, bus error, etc. testneeded labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exotictest regression Issue did not exist previously SEGV Segmentation fault, bus error, etc. testneeded
Projects
None yet
Development

No branches or pull requests

1 participant