Bleadperl v5.27.2-65-gea710183d4 breaks SARTAK/NetHack-Item-0.21.tar.gz #16167
Comments
From @andkSlaven sent me yet another BBC. bisect commit ea71018 harmonise S_pushav() and pp_padav() cpantesters http://www.cpantesters.org/cpan/report/26f4d550-7439-11e7-b7b1-f7132b4c90c2 perl -V Summary of my perl5 (revision 5 version 27 subversion 3) configuration: Characteristics of this binary (from libperl): -- |
From @jkeenanOn Sat, 23 Sep 2017 20:53:58 GMT, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
Although this is a case where Blead did Break CPAN, the fix will not necessarily be just on blead's part. Even with perl-5.26.0 this module's test suite throws up 141 deprecation warnings, some of which were the subject of a bug ticket filed in November 2013. With 5.26.0 the test suite passes, but I suspect the code has not been touched by the author in all that time. So unless the commit in question starts breaking other CPAN distributions, I doubt that we should treat this as high-priority breakage until we hear from the author. Here's what the actual breakage looks like: ##### Thank you very much. |
|
The RT System itself - Status changed from 'new' to 'open' |
From @iabynOn Sat, Sep 23, 2017 at 07:09:42PM -0700, James E Keenan via RT wrote:
However, since this is a pure-perl module, we should always look closely But in this particular case I can't get close to getting the test in So I won't be spending any further time on this. $ ~/perl5/git/bleed.out/bin/perl5.27.5 -Mblib t/700-tracker.t -- |
From gmail@sartak.orgFrom looking at the stack trace I suspect this could affect other distributions that depend on Moose. I'll see if I can replicate the issue in a standalone test. Thanks, iPhoneから送信 H29/09/23 22:09、James E Keenan via RT <perlbug-followup@perl.org>のメール:
|
From @xsawyerxOn Mon, 25 Sep 2017 16:38:33 -0700, gmail@sartak.org wrote:
Any update on this issue, Shawn? |
From @jkeenanOn Wed, 08 Nov 2017 18:27:39 GMT, xsawyerx@cpan.org wrote:
Yesterday I got bit by the "Out of memory" problem again while doing automated testing of CPAN against blead. That cost me most of an hour getting everything back under control. So I would really like to see this problem corrected or this distribution moved off CPAN. Thank you very much. |
From @iabynOn Thu, Nov 09, 2017 at 05:20:47AM -0800, James E Keenan via RT wrote:
I've looked into it some more, and it turns out that it's a bug with I've raised a CPAN ticket: https://rt.cpan.org/Ticket/Display.html?id=123582 Also, this proof-of-concept fix in Set::Object makes NetHack-Item pass: Inline Patch--- Object.xs- 2017-11-10 11:04:50.345719730 +0000
+++ Object.xs 2017-11-10 11:07:15.406916153 +0000
@@ -643,6 +643,7 @@
sv_bless(self, gv_stashsv(pkg, FALSE));
for (item = 1; item < items; ++item) {
+ SvGETMAGIC(ST(item));
ISET_INSERT(s, ST(item));
}
-- Please note that ash-trays are provided for the use of smokers, |
From @xsawyerxOn 11/10/2017 12:34 PM, Dave Mitchell wrote:
Nice, Dave! I see Reini had already merged the patch. Can we get an A-OK from our testers before we resolve this? |
From @andk
> Can we get an A-OK from our testers before we resolve this? The first pass reports have been generated with perls that previously -- |
From @xsawyerxOn Mon, 13 Nov 2017 11:50:30 -0800, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
Resolved. Thank you, Andreas! (And everyone involved.) |
|
@xsawyerx - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#132152 (status was 'resolved')
Searchable as RT132152$
The text was updated successfully, but these errors were encountered: