New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.27.0-138-g64278e8ca7 breaks SONGMU/L-0.01.tar.gz #16018
Comments
From @andkbisect commit 64278e8 Fatalize inheriting AUTOLOAD for non-methods. diagnostics t/001_basic.t (Wstat: 256 Tests: 4 Failed: 1) Note: the test did not warn in http://www.cpantesters.org/cpan/report/4a9814c8-49b8-11e7-9462-159206c6f99f perl -V Summary of my perl5 (revision 5 version 27 subversion 1) configuration: Characteristics of this binary (from libperl): -- |
From @jkeenanOn Wed, 14 Jun 2017 04:40:46 GMT, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
For context, let's include one more line in the commit message for the breaking commit: ##### Fatalize inheriting AUTOLOAD for non-methods. So, this is something we're likely to see many times in this annual development cycle: code that breaks because we're fatalizing a behavior we've tolerated for twenty years (+ 1 month). Here's the output I get when I try to install L against blead using cpanm: ##### # Failed test at t/001_basic.t line 26. This module's documentation contains the note: ##### Duly forewarned, we look at the code in L.pm. Here's the relevant part: ##### { our $AUTOLOAD; Module::Load::load($module); my $func = $module->can($method) $func->(@_); Given that we want to fatalize previously deprecated behavior, I believe this is a case where blead correctly breaks CPAN. I believe that a bug should be reported in L's bug tracker. Agreed? Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @andkalso affected: BRUMMETT/UR-0.46.tar.gz Thanks to Slaven, the scout! -- |
From @jkeenanOn Tue, 25 Jul 2017 19:43:28 GMT, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
1. General question to P5P: Is there some standard operating procedure we could recommend to module authors as to how to avoid this problem? 2. There are 4 tests in 3 test files failing in reports such as http://www.cpantesters.org/cpan/report/66c62eee-6b5c-11e7-a7ec-5ffb9018cd8c. Only the failures in the first 2 files can be attributed to this AUTOLOAD-related fatalization. I tried to install UR via 'cpanm' against 5.27.2. It has a ton of dependencies. Eventually I was able to get to the failures, but to get to the cause of the failures, at or about t/URT/t/41_rpc_basic.t line 103, I had to change 'ok' to 'like' to get the exception to show up. $ ok 26 - Response return value is correctly empty # Failed test 'Response excpetion correctly reflects calling an undefined function' I had to do a similar ok->like manipulation for the next failure as well: $ ok - Response return value is correctly empty # Failed test 'Response excpetion correctly reflects calling an undefined function' $ ~/testing/blead/bin/prove -I/home/jkeenan/testing/blead/lib -vb t/URT/t/63c_view_with_subviews.t ok 10 - path exists to expected content for toolkit json # Failed test 'content matches!' # Failed test 'content matches!' In third file, diff shows that certain numbers in JSON output are no longer being quoted. That's probably not related to the AUTOLOAD problem. -- |
From @xsawyerxOn 07/25/2017 11:28 PM, James E Keenan via RT wrote:
Nope. That's likely the JSON serialization's detection of numbers vs. |
From @jkeenanOn Wed, 14 Jun 2017 20:15:10 GMT, jkeenan wrote:
Slaven reported the problem in: The author corrected the problem in: -- |
From @jkeenanOn Tue, 25 Jul 2017 21:28:14 GMT, jkeenan wrote:
For the two test failures above I have filed:
-- |
From @jkeenanOn Tue, 01 Aug 2017 23:15:03 GMT, jkeenan wrote:
Maintainers have not yet responded to Aug 01 2017 pull request. [snip] -- |
From @iabyn(reviving a ticket about this commit breaking two CPAN distributions): commit 64278e8 Fatalize inheriting AUTOLOAD for non-methods Since a fixed version of L has been released, and since the problem with 1) at the very least, this ticket is removed from the 5.28 blockers list; -- |
From @xsawyerxOn 04/19/2018 10:34 PM, Dave Mitchell wrote:
This makes sense to me. |
@iabyn - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#131571 (status was 'resolved')
Searchable as RT131571$
The text was updated successfully, but these errors were encountered: