Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.27.0-138-g64278e8ca7 breaks SONGMU/L-0.01.tar.gz #16018

Closed
p5pRT opened this issue Jun 14, 2017 · 12 comments
Closed

Bleadperl v5.27.0-138-g64278e8ca7 breaks SONGMU/L-0.01.tar.gz #16018

p5pRT opened this issue Jun 14, 2017 · 12 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)

Comments

@p5pRT
Copy link

p5pRT commented Jun 14, 2017

Migrated from rt.perl.org#131571 (status was 'resolved')

Searchable as RT131571$

@p5pRT
Copy link
Author

p5pRT commented Jun 14, 2017

From @andk

bisect


commit 64278e8
Author​: Abigail <abigail@​abigail.be>
Date​: Tue Jun 6 23​:16​:30 2017 +0200

  Fatalize inheriting AUTOLOAD for non-methods.

diagnostics


t/001_basic.t (Wstat​: 256 Tests​: 4 Failed​: 1)
  Failed test​: 4
  Non-zero exit status​: 1

Note​: the test did not warn in http​://www.cpantesters.org/cpan/report/4a9814c8-49b8-11e7-9462-159206c6f99f

perl -V


Summary of my perl5 (revision 5 version 27 subversion 1) configuration​:
  Commit id​: 64278e8
  Platform​:
  osname=linux
  osvers=4.9.0-2-amd64
  archname=x86_64-linux-thread-multi
  uname='linux k93msid 4.9.0-2-amd64 #1 smp debian 4.9.18-1 (2017-03-30) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.0-138-g64278e8ca7/1e0c -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Duseithreads -Uuselongdouble -DEBUGGING=-g'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2 -g'
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='6.3.0 20170406'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  MULTIPLICITY
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_IMPLICIT_CONTEXT
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_ITHREADS
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Jun 6 2017 22​:02​:01
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.0-138-g64278e8ca7/1e0c/lib/site_perl/5.27.1/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.0-138-g64278e8ca7/1e0c/lib/site_perl/5.27.1
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.0-138-g64278e8ca7/1e0c/lib/5.27.1/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.0-138-g64278e8ca7/1e0c/lib/5.27.1

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Jun 14, 2017

From @jkeenan

On Wed, 14 Jun 2017 04​:40​:46 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit 64278e8
Author​: Abigail <abigail@​abigail.be>
Date​: Tue Jun 6 23​:16​:30 2017 +0200

Fatalize inheriting AUTOLOAD for non-methods.

diagnostics
-----------
t/001_basic.t (Wstat​: 256 Tests​: 4 Failed​: 1)
Failed test​: 4
Non-zero exit status​: 1

For context, let's include one more line in the commit message for the breaking commit​:

#####
commit 64278e8
Author​: Abigail <abigail@​abigail.be>
AuthorDate​: Tue Jun 6 23​:16​:30 2017 +0200
Commit​: Abigail <abigail@​abigail.be>
CommitDate​: Tue Jun 6 23​:17​:22 2017 +0200

  Fatalize inheriting AUTOLOAD for non-methods.
 
  This was deprecated in 5.004.
#####

So, this is something we're likely to see many times in this annual development cycle​: code that breaks because we're fatalizing a behavior we've tolerated for twenty years (+ 1 month).

Here's the output I get when I try to install L against blead using cpanm​:

#####
$ /testing/blead/bin/prove -I/testing/blead/lib -vb t/001_basic.t
t/001_basic.t ..
ok 1
ok 2
ok 3
not ok 4

# Failed test at t/001_basic.t line 26.
# 'Use of inherited AUTOLOAD for non-method main​::hoge() is no longer allowed at t/001_basic.t line 24.
# '
# doesn't match '(?^​:Undefined subroutine &main​::hoge called)'
1..4
# Looks like you failed 1 test of 4.
#####

This module's documentation contains the note​:

#####
This modules is dangerous, then don't use this module in other perl modules, scripts or product code. This should be used only in one liner.
#####

Duly forewarned, we look at the code in L.pm. Here's the relevant part​:

#####
use Carp ();
use Module​::Load ();

{
  package
  UNIVERSAL;

  our $AUTOLOAD;
  sub AUTOLOAD {
  return if $AUTOLOAD =~ /​::DESTROY$/;
  if (my ($module, $method) = ($AUTOLOAD =~ /^(.*)​::(.*?)$/)) {
  if ($module eq 'main') {
  Carp​::croak(qq{Undefined subroutine &main​::$method called});
  }

  Module​::Load​::load($module);

  my $func = $module->can($method)
  or Carp​::croak qq{Can't locate object method "$method" via package "$module"};

  $func->(@​_);
  } else {
  die "WTF? $AUTOLOAD";
  }
  }
}
#####

Given that we want to fatalize previously deprecated behavior, I believe this is a case where blead correctly breaks CPAN. I believe that a bug should be reported in L's bug tracker.

Agreed?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Jun 14, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jul 25, 2017

From @andk

also affected​: BRUMMETT/UR-0.46.tar.gz

Thanks to Slaven, the scout!

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Jul 25, 2017

From @jkeenan

On Tue, 25 Jul 2017 19​:43​:28 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

also affected​: BRUMMETT/UR-0.46.tar.gz

Thanks to Slaven, the scout!

1. General question to P5P​: Is there some standard operating procedure we could recommend to module authors as to how to avoid this problem?

2. There are 4 tests in 3 test files failing in reports such as http​://www.cpantesters.org/cpan/report/66c62eee-6b5c-11e7-a7ec-5ffb9018cd8c. Only the failures in the first 2 files can be attributed to this AUTOLOAD-related fatalization.

I tried to install UR via 'cpanm' against 5.27.2. It has a ton of dependencies. Eventually I was able to get to the failures, but to get to the cause of the failures, at or about t/URT/t/41_rpc_basic.t line 103, I had to change 'ok' to 'like' to get the exception to show up.

$ /testing/blead/bin/prove -I/testing/blead/lib -v t/URT/t/41_rpc_basic.t

ok 26 - Response return value is correctly empty
not ok 27 - Response excpetion correctly reflects calling an undefined function

# Failed test 'Response excpetion correctly reflects calling an undefined function'
# at t/URT/t/41_rpc_basic.t line 105.
# 'Use of inherited AUTOLOAD for non-method URT​::RPC​::Thingy​::some_undefined_function() is no longer allowed at /home/jkeenan/.cpanm/work/1501015361.9173/UR-0.46/lib/UR/Service/RPC/Executer.pm line 87.
# '
# doesn't match '(?^​:(Can't locate object method|Undefined sub).*some_undefined_function)'

I had to do a similar ok->like manipulation for the next failure as well​:

$ /testing/blead/bin/prove -I/testing/blead/lib -v t/URT/t/42_rpc_between_processes.t

ok - Response return value is correctly empty
not ok - Response excpetion correctly reflects calling an undefined function

# Failed test 'Response excpetion correctly reflects calling an undefined function'
# at t/URT/t/42_rpc_between_processes.t line 128.
# 'Use of inherited AUTOLOAD for non-method URT​::RPC​::Thingy​::some_undefined_function() is no longer allowed at /home/jkeenan/.cpanm/work/1501015361.9173/UR-0.46/lib/UR/Service/RPC/Executer.pm line 87.
# '
# doesn't match '(?^​:(Can't locate object method|Undefined sub).*some_undefined_function)'
ok - Created RPC message for match in scalar context

$ ~/testing/blead/bin/prove -I/home/jkeenan/testing/blead/lib -vb t/URT/t/63c_view_with_subviews.t

ok 10 - path exists to expected content for toolkit json
not ok 11 - content matches!

# Failed test 'content matches!'
# at t/URT/t/63c_view_with_subviews.t line 151.
# got​: '{
# "age" : "99 yrs",
# "cats" : [
# {
# "age" : "2 yrs",
# "fluf" : 11,
# "name" : "fluffy",
# "owner" : {
# "id" : 111
# }
# },
# {
# "age" : "8 yrs",
# "fluf" : "22 yrs",
# "name" : "nestor",
# "owner" : {
# "id" : 111
# }
# }
# ],
# "name" : "Fester"
# }
# '
# expected​: '{
# "age" : "99 yrs",
# "cats" : [
# {
# "age" : "2 yrs",
# "fluf" : "11",
# "name" : "fluffy",
# "owner" : {
# "id" : "111"
# }
# },
# {
# "age" : "8 yrs",
# "fluf" : "22 yrs",
# "name" : "nestor",
# "owner" : {
# "id" : "111"
# }
# }
# ],
# "name" : "Fester"
# }
# '
#
# VIEW​: Acme​::Person as text...
#
# Creating view with toolkit text
...
ok 18 - path exists to expected content for toolkit json
not ok 19 - content matches!

# Failed test 'content matches!'
# at t/URT/t/63c_view_with_subviews.t line 151.
# got​: '{
# "id" : "Acme​::Cat/And/owner_id/O​:\u001dO​:111\u001e",
# "members" : [
# {
# "id" : 222
# },
# {
# "id" : 333
# }
# ]
# }
# '
# expected​: '{
# "id" : "Acme​::Cat/And/owner_id/O​:\u001dO​:111\u001e",
# "members" : [
# {
# "id" : "222"
# },
# {
# "id" : "333"
# }
# ]
# }
# '
#
# VIEW​: Acme​::Cat​::Set as text...

In third file, diff shows that certain numbers in JSON output are no longer being quoted. That's probably not related to the AUTOLOAD problem.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Jul 26, 2017

From @xsawyerx

On 07/25/2017 11​:28 PM, James E Keenan via RT wrote​:

On Tue, 25 Jul 2017 19​:43​:28 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

also affected​: BRUMMETT/UR-0.46.tar.gz

Thanks to Slaven, the scout!

[...]

$ ~/testing/blead/bin/prove -I/home/jkeenan/testing/blead/lib -vb t/URT/t/63c_view_with_subviews.t

ok 10 - path exists to expected content for toolkit json
not ok 11 - content matches!

# Failed test 'content matches!'
# at t/URT/t/63c_view_with_subviews.t line 151.
# got​: '{
# "age" : "99 yrs",
# "cats" : [
# {
# "age" : "2 yrs",
# "fluf" : 11,
# "name" : "fluffy",
# "owner" : {
# "id" : 111
# }
# },
# {
# "age" : "8 yrs",
# "fluf" : "22 yrs",
# "name" : "nestor",
# "owner" : {
# "id" : 111
# }
# }
# ],
# "name" : "Fester"
# }
# '
# expected​: '{
# "age" : "99 yrs",
# "cats" : [
# {
# "age" : "2 yrs",
# "fluf" : "11",
# "name" : "fluffy",
# "owner" : {
# "id" : "111"
# }
# },
# {
# "age" : "8 yrs",
# "fluf" : "22 yrs",
# "name" : "nestor",
# "owner" : {
# "id" : "111"
# }
# }
# ],
# "name" : "Fester"
# }
# '
#
# VIEW​: Acme​::Person as text...
#
# Creating view with toolkit text
...
ok 18 - path exists to expected content for toolkit json
not ok 19 - content matches!

# Failed test 'content matches!'
# at t/URT/t/63c_view_with_subviews.t line 151.
# got​: '{
# "id" : "Acme​::Cat/And/owner_id/O​:\u001dO​:111\u001e",
# "members" : [
# {
# "id" : 222
# },
# {
# "id" : 333
# }
# ]
# }
# '
# expected​: '{
# "id" : "Acme​::Cat/And/owner_id/O​:\u001dO​:111\u001e",
# "members" : [
# {
# "id" : "222"
# },
# {
# "id" : "333"
# }
# ]
# }
# '
#
# VIEW​: Acme​::Cat​::Set as text...

In third file, diff shows that certain numbers in JSON output are no longer being quoted. That's probably not related to the AUTOLOAD problem.

Nope. That's likely the JSON serialization's detection of numbers vs.
strings.

@p5pRT
Copy link
Author

p5pRT commented Aug 1, 2017

From @jkeenan

On Wed, 14 Jun 2017 20​:15​:10 GMT, jkeenan wrote​:

On Wed, 14 Jun 2017 04​:40​:46 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit 64278e8
Author​: Abigail <abigail@​abigail.be>
Date​: Tue Jun 6 23​:16​:30 2017 +0200

Fatalize inheriting AUTOLOAD for non-methods.

diagnostics
-----------
t/001_basic.t (Wstat​: 256 Tests​: 4 Failed​: 1)
Failed test​: 4
Non-zero exit status​: 1

For context, let's include one more line in the commit message for the
breaking commit​:

#####
commit 64278e8
Author​: Abigail <abigail@​abigail.be>
AuthorDate​: Tue Jun 6 23​:16​:30 2017 +0200
Commit​: Abigail <abigail@​abigail.be>
CommitDate​: Tue Jun 6 23​:17​:22 2017 +0200

Fatalize inheriting AUTOLOAD for non-methods.

This was deprecated in 5.004.
#####

So, this is something we're likely to see many times in this annual
development cycle​: code that breaks because we're fatalizing a
behavior we've tolerated for twenty years (+ 1 month).

Here's the output I get when I try to install L against blead using
cpanm​:

#####
$ /testing/blead/bin/prove -I/testing/blead/lib -vb t/001_basic.t
t/001_basic.t ..
ok 1
ok 2
ok 3
not ok 4

# Failed test at t/001_basic.t line 26.
# 'Use of inherited AUTOLOAD for non-method
main​::hoge() is no longer allowed at t/001_basic.t line 24.
# '
# doesn't match '(?^​:Undefined subroutine &main​::hoge called)'
1..4
# Looks like you failed 1 test of 4.
#####

This module's documentation contains the note​:

#####
This modules is dangerous, then don't use this module in other perl
modules, scripts or product code. This should be used only in one
liner.
#####

Duly forewarned, we look at the code in L.pm. Here's the relevant
part​:

#####
use Carp ();
use Module​::Load ();

{
package
UNIVERSAL;

our $AUTOLOAD;
sub AUTOLOAD {
return if $AUTOLOAD =~ /​::DESTROY$/;
if (my ($module, $method) = ($AUTOLOAD =~ /^(.*)​::(.*?)$/)) {
if ($module eq 'main') {
Carp​::croak(qq{Undefined subroutine &main​::$method
called});
}

Module​::Load​::load($module);

my $func = $module->can($method)
or Carp​::croak qq{Can't locate object method "$method" via package
"$module"};

$func->(@​_);
} else {
die "WTF? $AUTOLOAD";
}
}
}
#####

Given that we want to fatalize previously deprecated behavior, I
believe this is a case where blead correctly breaks CPAN. I believe
that a bug should be reported in L's bug tracker.

Agreed?

Thank you very much.

Slaven reported the problem in​:
https://rt.cpan.org/Public/Bug/Display.html?id=122217

The author corrected the problem in​:
Songmu/p5-L#2

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Aug 1, 2017

From @jkeenan

On Tue, 25 Jul 2017 21​:28​:14 GMT, jkeenan wrote​:

On Tue, 25 Jul 2017 19​:43​:28 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

also affected​: BRUMMETT/UR-0.46.tar.gz

Thanks to Slaven, the scout!

1. General question to P5P​: Is there some standard operating
procedure we could recommend to module authors as to how to avoid this
problem?

2. There are 4 tests in 3 test files failing in reports such as
http​://www.cpantesters.org/cpan/report/66c62eee-6b5c-11e7-a7ec-
5ffb9018cd8c. Only the failures in the first 2 files can be
attributed to this AUTOLOAD-related fatalization.

I tried to install UR via 'cpanm' against 5.27.2. It has a ton of
dependencies. Eventually I was able to get to the failures, but to
get to the cause of the failures, at or about t/URT/t/41_rpc_basic.t
line 103, I had to change 'ok' to 'like' to get the exception to show
up.

$ /testing/blead/bin/prove -I/testing/blead/lib -v
t/URT/t/41_rpc_basic.t

ok 26 - Response return value is correctly empty
not ok 27 - Response excpetion correctly reflects calling an undefined
function

# Failed test 'Response excpetion correctly reflects calling an
undefined function'
# at t/URT/t/41_rpc_basic.t line 105.
# 'Use of inherited AUTOLOAD for non-method
URT​::RPC​::Thingy​::some_undefined_function() is no longer allowed at
/home/jkeenan/.cpanm/work/1501015361.9173/UR-
0.46/lib/UR/Service/RPC/Executer.pm line 87.
# '
# doesn't match '(?^​:(Can't locate object method|Undefined
sub).*some_undefined_function)'

I had to do a similar ok->like manipulation for the next failure as
well​:

$ /testing/blead/bin/prove -I/testing/blead/lib -v
t/URT/t/42_rpc_between_processes.t

ok - Response return value is correctly empty
not ok - Response excpetion correctly reflects calling an undefined
function

# Failed test 'Response excpetion correctly reflects calling an
undefined function'
# at t/URT/t/42_rpc_between_processes.t line 128.
# 'Use of inherited AUTOLOAD for non-method
URT​::RPC​::Thingy​::some_undefined_function() is no longer allowed at
/home/jkeenan/.cpanm/work/1501015361.9173/UR-
0.46/lib/UR/Service/RPC/Executer.pm line 87.
# '
# doesn't match '(?^​:(Can't locate object method|Undefined
sub).*some_undefined_function)'
ok - Created RPC message for match in scalar context

For the two test failures above I have filed​:
genome/UR#136

$ ~/testing/blead/bin/prove -I/home/jkeenan/testing/blead/lib -vb
t/URT/t/63c_view_with_subviews.t

ok 10 - path exists to expected content for toolkit json
not ok 11 - content matches!

# Failed test 'content matches!'
# at t/URT/t/63c_view_with_subviews.t line 151.
# got​: '{
# "age" : "99 yrs",
# "cats" : [
# {
# "age" : "2 yrs",
# "fluf" : 11,
# "name" : "fluffy",
# "owner" : {
# "id" : 111
# }
# },
# {
# "age" : "8 yrs",
# "fluf" : "22 yrs",
# "name" : "nestor",
# "owner" : {
# "id" : 111
# }
# }
# ],
# "name" : "Fester"
# }
# '
# expected​: '{
# "age" : "99 yrs",
# "cats" : [
# {
# "age" : "2 yrs",
# "fluf" : "11",
# "name" : "fluffy",
# "owner" : {
# "id" : "111"
# }
# },
# {
# "age" : "8 yrs",
# "fluf" : "22 yrs",
# "name" : "nestor",
# "owner" : {
# "id" : "111"
# }
# }
# ],
# "name" : "Fester"
# }
# '
#
# VIEW​: Acme​::Person as text...
#
# Creating view with toolkit text
...
ok 18 - path exists to expected content for toolkit json
not ok 19 - content matches!

# Failed test 'content matches!'
# at t/URT/t/63c_view_with_subviews.t line 151.
# got​: '{
# "id" : "Acme​::Cat/And/owner_id/O​:\u001dO​:111\u001e",
# "members" : [
# {
# "id" : 222
# },
# {
# "id" : 333
# }
# ]
# }
# '
# expected​: '{
# "id" : "Acme​::Cat/And/owner_id/O​:\u001dO​:111\u001e",
# "members" : [
# {
# "id" : "222"
# },
# {
# "id" : "333"
# }
# ]
# }
# '
#
# VIEW​: Acme​::Cat​::Set as text...

In third file, diff shows that certain numbers in JSON output are no
longer being quoted. That's probably not related to the AUTOLOAD
problem.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Feb 6, 2018

From @jkeenan

On Tue, 01 Aug 2017 23​:15​:03 GMT, jkeenan wrote​:

On Tue, 25 Jul 2017 21​:28​:14 GMT, jkeenan wrote​:

On Tue, 25 Jul 2017 19​:43​:28 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

also affected​: BRUMMETT/UR-0.46.tar.gz

Thanks to Slaven, the scout!

1. General question to P5P​: Is there some standard operating
procedure we could recommend to module authors as to how to avoid this
problem?

2. There are 4 tests in 3 test files failing in reports such as
http​://www.cpantesters.org/cpan/report/66c62eee-6b5c-11e7-a7ec-
5ffb9018cd8c. Only the failures in the first 2 files can be
attributed to this AUTOLOAD-related fatalization.

I tried to install UR via 'cpanm' against 5.27.2. It has a ton of
dependencies. Eventually I was able to get to the failures, but to
get to the cause of the failures, at or about t/URT/t/41_rpc_basic.t
line 103, I had to change 'ok' to 'like' to get the exception to show
up.

$ /testing/blead/bin/prove -I/testing/blead/lib -v
t/URT/t/41_rpc_basic.t

ok 26 - Response return value is correctly empty
not ok 27 - Response excpetion correctly reflects calling an undefined
function

# Failed test 'Response excpetion correctly reflects calling an
undefined function'
# at t/URT/t/41_rpc_basic.t line 105.
# 'Use of inherited AUTOLOAD for non-method
URT​::RPC​::Thingy​::some_undefined_function() is no longer allowed at
/home/jkeenan/.cpanm/work/1501015361.9173/UR-
0.46/lib/UR/Service/RPC/Executer.pm line 87.
# '
# doesn't match '(?^​:(Can't locate object method|Undefined
sub).*some_undefined_function)'

I had to do a similar ok->like manipulation for the next failure as
well​:

$ /testing/blead/bin/prove -I/testing/blead/lib -v
t/URT/t/42_rpc_between_processes.t

ok - Response return value is correctly empty
not ok - Response excpetion correctly reflects calling an undefined
function

# Failed test 'Response excpetion correctly reflects calling an
undefined function'
# at t/URT/t/42_rpc_between_processes.t line 128.
# 'Use of inherited AUTOLOAD for non-method
URT​::RPC​::Thingy​::some_undefined_function() is no longer allowed at
/home/jkeenan/.cpanm/work/1501015361.9173/UR-
0.46/lib/UR/Service/RPC/Executer.pm line 87.
# '
# doesn't match '(?^​:(Can't locate object method|Undefined
sub).*some_undefined_function)'
ok - Created RPC message for match in scalar context

For the two test failures above I have filed​:
genome/UR#136

Maintainers have not yet responded to Aug 01 2017 pull request.

[snip]

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 19, 2018

From @iabyn

(reviving a ticket about this commit breaking two CPAN distributions)​:

  commit 64278e8
  Author​: Abigail <abigail@​abigail.be>
  Date​: Tue Jun 6 23​:16​:30 2017 +0200

  Fatalize inheriting AUTOLOAD for non-methods

Since a fixed version of L has been released, and since the problem with
UR requires fixing UR, and since there has been no other widespread
breakage (I assume) cuased by this commit, I suggest that

1) at the very least, this ticket is removed from the 5.28 blockers list;
2) this ticket be closed.

--
All wight. I will give you one more chance. This time, I want to hear
no Wubens. No Weginalds. No Wudolf the wed-nosed weindeers.
  -- Life of Brian

@p5pRT
Copy link
Author

p5pRT commented Apr 19, 2018

From @xsawyerx

On 04/19/2018 10​:34 PM, Dave Mitchell wrote​:

(reviving a ticket about this commit breaking two CPAN distributions)​:

commit 64278e8ca74bf6743c65ced4c5002cdb054b2357
Author&#8203;: Abigail \<abigail@&#8203;abigail\.be>
Date&#8203;: Tue Jun 6 23&#8203;:16&#8203;:30 2017 \+0200

Fatalize inheriting AUTOLOAD for non\-methods

Since a fixed version of L has been released, and since the problem with
UR requires fixing UR, and since there has been no other widespread
breakage (I assume) cuased by this commit, I suggest that

1) at the very least, this ticket is removed from the 5.28 blockers list;
2) this ticket be closed.

This makes sense to me.

@p5pRT
Copy link
Author

p5pRT commented Apr 20, 2018

@iabyn - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Apr 20, 2018
@p5pRT p5pRT added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Severity Low labels Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

1 participant