New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] Upgrade to threads 2.16 #15972
Comments
From @jdheddenThis is a bug report for perl from jdhedden@cpan.org, The attached patch upgrades 'threads' to version 2.16. It fixes compatibility issues with Clang macros for Perl <5.24 per No functional changes to module. Flags: Site configuration information for perl 5.24.1: Configured by Debian Project at Thu Mar 16 11:11:46 UTC 2017. Summary of my perl5 (revision 5 version 24 subversion 1) configuration: Locally applied patches: @INC for perl 5.24.1: Environment for perl 5.24.1: |
From @jdhedden0001-Upgrade-to-threads-2.16.patchFrom 36aa5b9387e44c0cb8eb7c4bf1a174e2f9071fe8 Mon Sep 17 00:00:00 2001
From: jdhedden <jdhedden@cpan.org>
Date: Sun, 7 May 2017 18:33:39 -0400
Subject: [PATCH] Upgrade to threads 2.16
---
Porting/Maintainers.pl | 2 +-
dist/threads/lib/threads.pm | 4 ++--
dist/threads/t/exit.t | 10 +++++-----
dist/threads/t/thread.t | 2 +-
dist/threads/threads.xs | 5 +++--
5 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/Porting/Maintainers.pl b/Porting/Maintainers.pl
index e9032a91f3..dd195abaa1 100755
--- a/Porting/Maintainers.pl
+++ b/Porting/Maintainers.pl
@@ -1161,7 +1161,7 @@ use File::Glob qw(:case);
},
'threads' => {
- 'DISTRIBUTION' => 'JDHEDDEN/threads-2.15.tar.gz',
+ 'DISTRIBUTION' => 'JDHEDDEN/threads-2.16.tar.gz',
'FILES' => q[dist/threads],
'EXCLUDED' => [
qr{^examples/},
diff --git a/dist/threads/lib/threads.pm b/dist/threads/lib/threads.pm
index d174f72496..2c37a61907 100644
--- a/dist/threads/lib/threads.pm
+++ b/dist/threads/lib/threads.pm
@@ -5,7 +5,7 @@ use 5.008;
use strict;
use warnings;
-our $VERSION = '2.15';
+our $VERSION = '2.16';
my $XS_VERSION = $VERSION;
$VERSION = eval $VERSION;
@@ -134,7 +134,7 @@ threads - Perl interpreter-based threads
=head1 VERSION
-This document describes threads version 2.15
+This document describes threads version 2.16
=head1 WARNING
diff --git a/dist/threads/t/exit.t b/dist/threads/t/exit.t
index bad602f8bb..4e0286605e 100644
--- a/dist/threads/t/exit.t
+++ b/dist/threads/t/exit.t
@@ -48,7 +48,7 @@ my $rc = $thr->join();
ok(! defined($rc), 'Exited: threads->exit()');
-run_perl(prog => 'use threads 2.15;' .
+run_perl(prog => 'use threads 2.16;' .
'threads->exit(86);' .
'exit(99);',
nolib => ($ENV{PERL_CORE}) ? 0 : 1,
@@ -98,7 +98,7 @@ $rc = $thr->join();
ok(! defined($rc), 'Exited: $thr->set_thread_exit_only');
-run_perl(prog => 'use threads 2.15 qw(exit thread_only);' .
+run_perl(prog => 'use threads 2.16 qw(exit thread_only);' .
'threads->create(sub { exit(99); })->join();' .
'exit(86);',
nolib => ($ENV{PERL_CORE}) ? 0 : 1,
@@ -108,7 +108,7 @@ run_perl(prog => 'use threads 2.15 qw(exit thread_only);' .
is($?>>8, 86, "'use threads 'exit' => 'thread_only'");
}
-my $out = run_perl(prog => 'use threads 2.15;' .
+my $out = run_perl(prog => 'use threads 2.16;' .
'threads->create(sub {' .
' exit(99);' .
'});' .
@@ -124,7 +124,7 @@ my $out = run_perl(prog => 'use threads 2.15;' .
like($out, qr/1 finished and unjoined/, "exit(status) in thread");
-$out = run_perl(prog => 'use threads 2.15 qw(exit thread_only);' .
+$out = run_perl(prog => 'use threads 2.16 qw(exit thread_only);' .
'threads->create(sub {' .
' threads->set_thread_exit_only(0);' .
' exit(99);' .
@@ -141,7 +141,7 @@ $out = run_perl(prog => 'use threads 2.15 qw(exit thread_only);' .
like($out, qr/1 finished and unjoined/, "set_thread_exit_only(0)");
-run_perl(prog => 'use threads 2.15;' .
+run_perl(prog => 'use threads 2.16;' .
'threads->create(sub {' .
' $SIG{__WARN__} = sub { exit(99); };' .
' die();' .
diff --git a/dist/threads/t/thread.t b/dist/threads/t/thread.t
index 8f4f156967..c63250c353 100644
--- a/dist/threads/t/thread.t
+++ b/dist/threads/t/thread.t
@@ -161,7 +161,7 @@ package main;
# bugid #24165
-run_perl(prog => 'use threads 2.15;' .
+run_perl(prog => 'use threads 2.16;' .
'sub a{threads->create(shift)} $t = a sub{};' .
'$t->tid; $t->join; $t->tid',
nolib => ($ENV{PERL_CORE}) ? 0 : 1,
diff --git a/dist/threads/threads.xs b/dist/threads/threads.xs
index 838276545c..c519ad4f4d 100644
--- a/dist/threads/threads.xs
+++ b/dist/threads/threads.xs
@@ -1016,12 +1016,13 @@ S_ithread_create(
MUTEX_UNLOCK(&my_pool->create_destruct_mutex);
return (thread);
-#if defined(__clang__) || defined(__clang)
+#if defined(CLANG_DIAG_IGNORE)
CLANG_DIAG_IGNORE(-Wthread-safety);
/* warning: mutex 'thread->mutex' is not held on every path through here [-Wthread-safety-analysis] */
#endif
}
-#if defined(__clang__) || defined(__clang)
+/* perl.h defines CLANG_DIAG_* but only in 5.24+ */
+#if defined(CLANG_DIAG_RESTORE)
CLANG_DIAG_RESTORE
#endif
--
2.11.0
|
The RT System itself - Status changed from 'new' to 'open' |
@jkeenan - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#131267 (status was 'resolved')
Searchable as RT131267$
The text was updated successfully, but these errors were encountered: