Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly-added NQP test for catching exceptions fails on JVM #6195

Closed
p6rt opened this issue Apr 17, 2017 · 5 comments
Closed

Newly-added NQP test for catching exceptions fails on JVM #6195

p6rt opened this issue Apr 17, 2017 · 5 comments
Labels
JVM Related to Rakudo-JVM

Comments

@p6rt
Copy link

p6rt commented Apr 17, 2017

Migrated from rt.perl.org#131167 (status was 'resolved')

Searchable as RT131167$

@p6rt
Copy link
Author

p6rt commented Apr 17, 2017

From @zoffixznet

I had to fudge it for the release and will unfudge after the release.

The test tests if a labeled exception is uncaught by inner unlabled handler and is caught by
outer labeled handler instead, but on JVM it's uncaught entirely.

Fudge​: Raku/nqp@0994e33818

Output of failing test​:

  Unhandled exception; category = 4224
  in <anon> (gen/jvm/stage2/NQPHLL.nqp​:1281)
  in <anon> (gen/jvm/stage2/NQPHLL.nqp)
  in catch_unlabeled_first (t/nqp/044-try-catch.t​:428)
  in <mainline> (t/nqp/044-try-catch.t​:439)
  in eval (gen/jvm/stage2/NQPHLL.nqp​:1168)
  in evalfiles (gen/jvm/stage2/NQPHLL.nqp​:1371)
  in command_eval (gen/jvm/stage2/NQPHLL.nqp​:1265)
  in command_line (gen/jvm/stage2/NQPHLL.nqp​:1239)
  in MAIN (gen/jvm/stage2/NQP.nqp​:4130)
  in <mainline> (gen/jvm/stage2/NQP.nqp​:4126)
  in <anon> (gen/jvm/stage2/NQP.nqp)

@p6rt
Copy link
Author

p6rt commented Apr 17, 2017

From @zoffixznet

The release has been done and the removal has now been reverted in Raku/nqp@6916dd0d99

@p6rt
Copy link
Author

p6rt commented Apr 18, 2019

From @usev6

I have committed Raku/nqp@59d7a8869c and this test passes now.

As far as I understand, the right handler was missed when moving to the outside, because unwind_check sets the outer handler to 0 by default if no outer handler is passed. We do the latter now.

I'm closing this ticket as 'resolved'.

1 similar comment
@p6rt
Copy link
Author

p6rt commented Apr 18, 2019

From @usev6

I have committed Raku/nqp@59d7a8869c and this test passes now.

As far as I understand, the right handler was missed when moving to the outside, because unwind_check sets the outer handler to 0 by default if no outer handler is passed. We do the latter now.

I'm closing this ticket as 'resolved'.

@p6rt
Copy link
Author

p6rt commented Apr 18, 2019

@usev6 - Status changed from 'new' to 'resolved'

@p6rt p6rt closed this as completed Apr 18, 2019
@p6rt p6rt added the JVM Related to Rakudo-JVM label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JVM Related to Rakudo-JVM
Projects
None yet
Development

No branches or pull requests

1 participant