Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A andthen B orelse C orelse D leaks some internal Block #6085

Closed
p6rt opened this issue Feb 17, 2017 · 7 comments
Closed

A andthen B orelse C orelse D leaks some internal Block #6085

p6rt opened this issue Feb 17, 2017 · 7 comments

Comments

@p6rt
Copy link

p6rt commented Feb 17, 2017

Migrated from rt.perl.org#130798 (status was 'resolved')

Searchable as RT130798$

@p6rt
Copy link
Author

p6rt commented Feb 17, 2017

From @LLFourn

note (Nil andthen "foo" orelse Nil orelse "bar");
-> ;; $_ is raw { #`(Block|140635964425160) ... }

see the previously fixed​:
https://rt.perl.org/Public/Bug/Display.html?id=130034

@p6rt
Copy link
Author

p6rt commented Feb 17, 2017

From @dwarring

On Thu, 16 Feb 2017 19​:44​:47 -0800, lloyd.fourn@​gmail.com wrote​:

note (Nil andthen "foo" orelse Nil orelse "bar");
-> ;; $_ is raw { #`(Block|140635964425160) ... }

see the previously fixed​:
https://rt.perl.org/Public/Bug/Display.html?id=130034

09​:38] <dwarring> r​: my $r := do 42 with Nil; say $r.perl;
[09​:38] <+camelia> rakudo-moar a162c4​: OUTPUT«Empty␤»
[09​:38] <+camelia> ..rakudo-jvm fb4f16​: OUTPUT«slip()␤»
[09​:38] <dwarring> r​: my $r := do 42 with Empty; say $r.perl;
[09​:38] <+camelia> rakudo-moar a162c4​: OUTPUT«-> ;; $_ is raw { #`(Block|81724200) ... }␤»
[09​:38] <+camelia> ..rakudo-jvm fb4f16​: OUTPUT«-> ;; $_ is raw { #`(Block|277551034) ... }␤»
[09​:39] <IOninja> aw shit
[09​:39] == wamba [~wamba@​193-194.moravanet.cz] has joined #perl6
[09​:39] <IOninja> dwarring​: you could add those cases to https://rt-archive.perl.org/perl6/Ticket/Display.html?id=130798#ticket-history

@p6rt
Copy link
Author

p6rt commented Feb 17, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Feb 18, 2017

From @usev6

On Fri, 17 Feb 2017 12​:41​:12 -0800, david.warring wrote​:

09​:38] <dwarring> r​: my $r := do 42 with Nil; say $r.perl;
[09​:38] <+camelia> rakudo-moar a162c4​: OUTPUT«Empty␤»
[09​:38] <+camelia> ..rakudo-jvm fb4f16​: OUTPUT«slip()␤»

Just a short comment on this​: Camelia runs on an older commit (fb4f16 is from 2017-01-03). On HEAD r-j returns 'Empty' as well​:

$ ./perl6-j 'my $r := do 42 with Nil; say $r.perl;'
Empty

$ ./perl6-j --version
This is Rakudo version 2017.01-223-gffae3ff built on JVM
implementing Perl 6.c.

@p6rt
Copy link
Author

p6rt commented Apr 26, 2017

From @zoffixznet

Thought a bit more on this one and I think it should actually be possible to remove all the "heuristics" and detect the Empty from previous ops directly via nqp​::p6argvmarray op.

Will hack up a solution, when I get a chance.

@p6rt
Copy link
Author

p6rt commented Apr 29, 2017

From @zoffixznet

On Fri, 17 Feb 2017 12​:41​:12 -0800, david.warring wrote​:

On Thu, 16 Feb 2017 19​:44​:47 -0800, lloyd.fourn@​gmail.com wrote​:

note (Nil andthen "foo" orelse Nil orelse "bar");
-> ;; $_ is raw { #`(Block|140635964425160) ... }

see the previously fixed​:
https://rt.perl.org/Public/Bug/Display.html?id=130034

09​:38] <dwarring> r​: my $r := do 42 with Nil; say $r.perl;
[09​:38] <+camelia> rakudo-moar a162c4​: OUTPUT«Empty␤»
[09​:38] <+camelia> ..rakudo-jvm fb4f16​: OUTPUT«slip()␤»
[09​:38] <dwarring> r​: my $r := do 42 with Empty; say $r.perl;
[09​:38] <+camelia> rakudo-moar a162c4​: OUTPUT«-> ;; $_ is raw {
#`(Block|81724200) ... }␤»
[09​:38] <+camelia> ..rakudo-jvm fb4f16​: OUTPUT«-> ;; $_ is raw {
#`(Block|277551034) ... }␤»
[09​:39] <IOninja> aw shit
[09​:39] == wamba [~wamba@​193-194.moravanet.cz] has joined #perl6
[09​:39] <IOninja> dwarring​: you could add those cases to
https://rt-archive.perl.org/perl6/Ticket/Display.html?id=130798#ticket-history

Thank you for the report. This is now fixed.

OP's Issue​:
  Fix​: rakudo/rakudo@37316f8220
  Tests​: Raku/roast@59d56a4cc1

dwarring's Issue in comments​:
  Fix​: rakudo/rakudo@3c8822e80d
  Tests​: Raku/roast@8993a2434b

@p6rt p6rt closed this as completed Apr 29, 2017
@p6rt
Copy link
Author

p6rt commented Apr 29, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant