From @andk

bisect

commit b5048e7
Author​: Aaron Crane <arc@​cpan.org>
Date​: Mon Jul 11 15​:25​:43 2016 +0100

  Data​::Dumper​: the XS implementation now supports Deparse

diagnostics

http​://www.cpantesters.org/cpan/report/76470897

Downgrading Data​::Dumper to version 2.161 from CPAN makes the tests pass
again.

perl -V

Summary of my perl5 (revision 5 version 25 subversion 7) configuration​:
  Commit id​: b5048e7
  Platform​:
  osname=linux
  osvers=4.8.0-2-amd64
  archname=x86_64-linux
  uname='linux k93msid 4.8.0-2-amd64 #1 smp debian 4.8.11-1 (2016-12-02) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.6-215-gb5048e7b9a/89ad -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2 -g'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='6.2.1 20161124'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Jan 1 2017 21​:16​:33
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.6-215-gb5048e7b9a/89ad/lib/site_perl/5.25.7/x86_64-linux
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.6-215-gb5048e7b9a/89ad/lib/site_perl/5.25.7
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.6-215-gb5048e7b9a/89ad/lib/5.25.7/x86_64-linux
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.6-215-gb5048e7b9a/89ad/lib/5.25.7
  .

--
andreas

From @jkeenan

On Mon, 02 Jan 2017 22​:32​:33 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit b5048e7
Author​: Aaron Crane <arc@​cpan.org>
Date​: Mon Jul 11 15​:25​:43 2016 +0100

Data​::Dumper​: the XS implementation now supports Deparse

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/76470897

Downgrading Data​::Dumper to version 2.161 from CPAN makes the tests
pass
again.

Confirmed. See attachments for reduction and output thereof.

--
James E Keenan (jkeenan@​cpan.org)

From @jkeenan

130487-deparse.pl

From @jkeenan

Global symbol "$three" requires explicit package name (did you forget to declare "my $three"?) at (eval 16) line 2.
Global symbol "$three" requires explicit package name (did you forget to declare "my $three"?) at (eval 16) line 3.
while trying to turn range​: "sub {
  my($three) = @​_;
  return $three;
}
"
into code​: sub {$_[0] =~ s/([sub {
  my($three) = @​_;
  return $three;
}
])/$char2entity{$1} || num_entity($1)/ge; }
  at /home/jkeenan/testing/blead/lib/perl5/site_perl/5.25.9/x86_64-linux/HTML/Entities.pm line 455.

The RT System itself - Status changed from 'new' to 'open'

From @jkeenan

On Tue, 03 Jan 2017 17​:13​:26 GMT, jkeenan wrote​:

On Mon, 02 Jan 2017 22​:32​:33 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit b5048e7
Author​: Aaron Crane <arc@​cpan.org>
Date​: Mon Jul 11 15​:25​:43 2016 +0100

Data​::Dumper​: the XS implementation now supports Deparse

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/76470897

Downgrading Data​::Dumper to version 2.161 from CPAN makes the tests
pass
again.

Confirmed. See attachments for reduction and output thereof.

Inside HTML​::Entities​::encode_entity(), different codepaths are taken depending upon the number of arguments passed to the subroutine. In perl-5.24.0 -- or in blead with $Data​::Dumper​::Deparse = 0 -- encode_entity() sees only 1 argument. But for some reason I don't understand, when, in blead, you have $Data​::Dumper​::Deparse = 1, that subroutine sees *2* arguments.

We can simulate this behavior by simply mocking the first part of the function and then running it at blead with Deparse first false then true. See attachments​: program and output.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

From @jkeenan

130487-reduced.pl

From @jkeenan

$Data​::Dumper​::Deparse is set to​: 0
Saw 1 argument(s)

$Data​::Dumper​::Deparse is set to​: 1
Saw 2 argument(s)

From @arc

Thanks for the report. I've just fixed this in blead as of commit 8235b1c

--
Aaron Crane ** http​://aaroncrane.co.uk/

@arc - Status changed from 'open' to 'resolved'

From @jkeenan

On Wed, 04 Jan 2017 15​:53​:51 GMT, arc wrote​:

Thanks for the report. I've just fixed this in blead as of commit
8235b1c

And I can confirm that I can install the distribution against Perl 5 blead (the commit above) via 'cpanm'.

#####
Building and testing Plack-Middleware-Debug-CatalystStash-1.000000 ... OK
Successfully installed Plack-Middleware-Debug-CatalystStash-1.000000
129 distributions installed
#####
--
James E Keenan (jkeenan@​cpan.org)