From @andk

bisect

commit f441d7d
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Sep 4 23​:14​:21 2016 -0700

  Stop setting OPf_REF on OP_ENTERSUB

cpantesters

http​://www.cpantesters.org/cpan/report/d1f8feb8-7417-11e6-a59b-63bcea7e2f12

perl -V

Summary of my perl5 (revision 5 version 25 subversion 5) configuration​:
  Commit id​: f441d7d
  Platform​:
  osname=linux
  osvers=4.7.0-1-amd64
  archname=x86_64-linux-thread-multi
  uname='linux k83 4.7.0-1-amd64 #1 smp debian 4.7.2-1 (2016-08-28) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.4-85-gf441d7d/f7bf -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2 -g'
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='6.2.0 20160830'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  MULTIPLICITY
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_ITHREADS
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Sep 8 2016 04​:02​:08
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.4-85-gf441d7d/f7bf/lib/site_perl/5.25.5/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.4-85-gf441d7d/f7bf/lib/site_perl/5.25.5
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.4-85-gf441d7d/f7bf/lib/5.25.5/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.4-85-gf441d7d/f7bf/lib/5.25.5
  .

--
andreas

From @cpansprout

On Wed Sep 07 19​:29​:41 2016, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

bisect
------
commit f441d7d
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Sun Sep 4 23​:14​:21 2016 -0700

Stop setting OPf_REF on OP_ENTERSUB

I don’t have time to build and install a new blead right now, but could you test this patch for me? I believe it will work on older perls, too.

--

Father Chrysostomos

From @cpansprout

diff -Nurp Data-Swap-0.08-C1Igky-orig/Swap.xs Data-Swap-0.08-C1Igky/Swap.xs
--- Data-Swap-0.08-C1Igky-orig/Swap.xs	2008-09-12 06:41:59.000000000 -0700
+++ Data-Swap-0.08-C1Igky/Swap.xs	2016-09-07 19:45:22.000000000 -0700
@@ -135,7 +135,7 @@ deref(...)
 	I32 sref;
 	SV *sv;
     PPCODE:
-	sref = (GIMME == G_SCALAR) && (PL_op->op_flags & OPf_REF);
+	sref = (GIMME == G_SCALAR) && (PL_op->op_flags & OPf_MOD);
 	for (i = 0; i < items; i++) {
 		if (!SvROK(ST(i))) {
 			STRLEN z;

The RT System itself - Status changed from 'new' to 'open'

From @andk

On Wed, 07 Sep 2016 19​:46​:33 -0700, "Father Chrysostomos via RT" <perlbug-followup@​perl.org> said​:

  > I don’t have time to build and install a new blead right now, but
  > could you test this patch for me? I believe it will work on older
  > perls, too.

Works! Tested with my oldest smoker (5.8.1), and v5.25.4-84-g0af40c7 and
v5.25.4-85-gf441d7d

--
andreas

From @jkeenan

On Thu, 08 Sep 2016 05​:32​:43 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Wed, 07 Sep 2016 19​:46​:33 -0700, "Father Chrysostomos via RT"
<perlbug-followup@​perl.org> said​:

I don’t have time to build and install a new blead right now, but
could you test this patch for me? I believe it will work on older
perls, too.

Works! Tested with my oldest smoker (5.8.1), and v5.25.4-84-g0af40c7
and
v5.25.4-85-gf441d7d

https://rt.cpan.org/Ticket/Display.html?id=117618#txn-1666388

Father C submitted a patch to Data-Swap's bug queue on Sep 08 2016.

Can we mark this ticket resolved?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

From @jkeenan

On Tue, 06 Dec 2016 20​:47​:33 GMT, jkeenan wrote​:

On Thu, 08 Sep 2016 05​:32​:43 GMT,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Wed, 07 Sep 2016 19​:46​:33 -0700, "Father Chrysostomos via
RT"
<perlbug-followup@​perl.org> said​:

I don’t have time to build and install a new blead right now, but
could you test this patch for me? I believe it will work on older
perls, too.

Works! Tested with my oldest smoker (5.8.1), and v5.25.4-84-g0af40c7
and
v5.25.4-85-gf441d7d

https://rt.cpan.org/Ticket/Display.html?id=117618#txn-1666388

Father C submitted a patch to Data-Swap's bug queue on Sep 08 2016.

Can we mark this ticket resolved?

I'm marking it resolved. Data-Swap (http​://search.cpan.org/~xmath/Data-Swap-0.08/) was last updated on CPAN in 2008. Leon T has indicated it is in need of a new maintainer. We'll hope that a new maintainer comes along and can apply the patch -- but we've done our part.

Thank you very much.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@jkeenan - Status changed from 'open' to 'resolved'