New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkpport adds quotes to $perl even if it's already quoted #15574
Comments
From @briandfoyI'm compiling 5.25.4 from a path with a space character in it. It fails from a double double quoting issue that tries to run a command like: ""/Path/To Some/Place/perl"" ... which_perl from MakeMaker::Test::Utils returns a path already quoted, like q("/Path/To Some/Place/perl"). The run subroutine in mkpport checks for whitespace in $perl and adds another layer of double quotes around the string if it finds whitespace. It should only do that if the value doesn't already have those quotes. |
From @jkeenanOn Wed Aug 31 07:38:33 2016, comdog wrote:
So, to confirm this problem, I created this directory: ##### ... got the tarball for perl-5.25.4, unpacked it and moved into the unpacked directory, configured perl and called 'make -j${TEST_JOBS} test_prep' as I would normally do with blead. 'make' silently terminated at this point: ##### When I then called 'make', 'make' terminated with this error output: ##### Is that the error output you're getting? Thank you very much. |
The RT System itself - Status changed from 'new' to 'open' |
From @craigberryOn Wed, Aug 31, 2016 at 11:43 AM, James E Keenan via RT
Since you've got a test set-up handy, try replacing this line my $run = $perl =~ m/\s/ ? qq("$perl") : $perl; from: http://perl5.git.perl.org/perl.git/blob/HEAD:/mkppport#l140 with my $run = ($perl !~ m/^\"/) && ($perl =~ m/\s/) ? qq("$perl") : $perl; and see if that prevents the double quoting. |
From @jkeenanOn Wed Aug 31 10:17:28 2016, craig.a.berry@gmail.com wrote:
Substituting in that one line, 'make' completes successfully. However, there are massive test failures. Here is a taste of those: ##### ##### I tried similar replacements this morning and got similar results. Thank you very much. |
From @briandfoyI patched my 5.25.12 sources with this: $ diff mkppport mkppport.new
That solves the first problem. |
From @jkeenanOn Wed, 26 Apr 2017 20:08:24 GMT, comdog wrote:
And ... is there a second problem? |
From @briandfoyA second problem besides all the test failures you've already noted? |
Migrated from rt.perl.org#129152 (status was 'open')
Searchable as RT129152$
The text was updated successfully, but these errors were encountered: