Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Weird node visited" #5403

Open
p6rt opened this issue Jun 26, 2016 · 4 comments
Open

"Weird node visited" #5403

p6rt opened this issue Jun 26, 2016 · 4 comments

Comments

@p6rt
Copy link

p6rt commented Jun 26, 2016

Migrated from rt.perl.org#128485 (status was 'stalled')

Searchable as RT128485$

@p6rt
Copy link
Author

p6rt commented Jun 26, 2016

From @raiph

What I did

use experimental :macros;
macro m { quasi {} }
m

What I got

rakudo-moar e071e4​: OUTPUT«Weird node visited​: QAST​::BVal␤»

What I expected

No output or Nil used in sink context or somesuch.

Why the message appears

TimToady added this error message to Rakudo's Optimizer.nqp as part of his Great Sink Refactor commit rakudo/rakudo@f95c144

The error message is the last else in an if/elsif chain that deals with all but two -- BVal and CompUnit -- of the 15 QAST node types mentioned in https://github.com/perl6/nqp/blob/66da2a28b644f0a535f448fb62b4720b0b1201c4/docs/qast.markdown

Perhaps we just need to add BVal and CompUnit to the final elsif at rakudo/rakudo@f95c144#diff-c6d4338f0fe083856631860c53453281R1943

Or perhaps proper sink handling requires one or both of these to be individually processed.

@p6rt
Copy link
Author

p6rt commented Aug 23, 2016

From @coke

On Sun Jun 26 11​:42​:10 2016, raiph wrote​:

What I did

use experimental :macros;
macro m { quasi {} }
m

What I got

rakudo-moar e071e4​: OUTPUT«Weird node visited​: QAST​::BVal␤»

What I expected

No output or Nil used in sink context or somesuch.

Why the message appears

TimToady added this error message to Rakudo's Optimizer.nqp as part of
his Great Sink Refactor commit
rakudo/rakudo@f95c144

The error message is the last else in an if/elsif chain that deals
with all but two -- BVal and CompUnit -- of the 15 QAST node types
mentioned in
https://github.com/perl6/nqp/blob/66da2a28b644f0a535f448fb62b4720b0b1201c4/docs/qast.markdown

Perhaps we just need to add BVal and CompUnit to the final elsif at
rakudo/rakudo@f95c144#diff-
c6d4338f0fe083856631860c53453281R1943

Or perhaps proper sink handling requires one or both of these to be
individually processed.

macros are experimental and development on them is currently stalled.

Marking ticket as 'stalled'

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Aug 23, 2016

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Aug 23, 2016

@coke - Status changed from 'open' to 'stalled'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant