Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.25.2-28-g8bf4c40 breaks METADOO/Tie-REHash-1.05.tar.gz #15410

Closed
p5pRT opened this issue Jun 25, 2016 · 10 comments
Closed

Bleadperl v5.25.2-28-g8bf4c40 breaks METADOO/Tie-REHash-1.05.tar.gz #15410

p5pRT opened this issue Jun 25, 2016 · 10 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) distro-All

Comments

@p5pRT
Copy link

p5pRT commented Jun 25, 2016

Migrated from rt.perl.org#128482 (status was 'resolved')

Searchable as RT128482$

@p5pRT
Copy link
Author

p5pRT commented Jun 25, 2016

From @andk

bisect


commit 8bf4c40
Author​: Yves Orton <demerphq@​gmail.com>
Date​: Mon Jun 20 22​:51​:38 2016 +0200

  Change scalar(%hash) to be the same as 0+keys(%hash)

diagnostics


http​://www.cpantesters.org/cpan/report/6948c51c-39fa-11e6-8ca3-5344607dd3ab

perl -V


Summary of my perl5 (revision 5 version 25 subversion 3) configuration​:
  Commit id​: 8bbcf42
  Platform​:
  osname=linux
  osvers=4.3.0-1-amd64
  archname=x86_64-linux-thread-multi-ld
  uname='linux k83 4.3.0-1-amd64 #1 smp debian 4.3.3-7 (2016-01-19) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-31-g8bbcf42/109d -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Duseithreads -Duselongdouble -DDEBUGGING=-g'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=define
  usemymalloc=n
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2 -g'
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='5.3.1 20160121'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='long double'
  nvsize=16
  Off_t='off_t'
  lseeksize=8
  alignbytes=16
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.21.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.21'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  MULTIPLICITY
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_ITHREADS
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_LONG_DOUBLE
  USE_PERLIO
  USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Jun 23 2016 15​:35​:08
  %ENV​:
  PERL="/tmp/basesmoker-reloperl-FmQt/bin/perl"
  PERL5LIB=""
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="4175"
  PERL5_CPAN_IS_RUNNING="4175"
  PERL_CANARY_STABILITY_NOPROMPT="1"
  PERL_MM_USE_DEFAULT="1"
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-31-g8bbcf42/109d/lib/site_perl/5.25.3/x86_64-linux-thread-multi-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-31-g8bbcf42/109d/lib/site_perl/5.25.3
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-31-g8bbcf42/109d/lib/5.25.3/x86_64-linux-thread-multi-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.25.2-31-g8bbcf42/109d/lib/5.25.3
  .
 
--
andreas

@p5pRT
Copy link
Author

p5pRT commented Jun 26, 2016

From @demerphq

On 25 June 2016 at 13​:02, Andreas J. Koenig via RT
<perlbug-followup@​perl.org> wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #128482]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=128482 >

bisect
------
commit 8bf4c40
Author​: Yves Orton <demerphq@​gmail.com>
Date​: Mon Jun 20 22​:51​:38 2016 +0200

Change scalar\(%hash\) to be the same as 0\+keys\(%hash\)

This tests that scalar() passes through to the perl internal
definition for scalar(%hash), which changed in 5.25

like($pre_v5_8_3 ? tied(%hash)->scalar : scalar(%hash), qr{\d+/\d+},
'Standard hash​: buckets allocated in scalar context')
or diag('scalar %hash​: '
. $pre_v5_8_3 ? tied(%hash)->scalar : scalar(%hash));

It could be changed to only test the booleanness of the scalar(%hash),
or it could be taught that in 5.25 and later the return of
scalar(%hash) is supposed to be the count of keys. I note that in
other contexts it returns 0/1 so...

Yves

@p5pRT
Copy link
Author

p5pRT commented Jun 26, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 21, 2016

From @eserte

On Sun Jun 26 09​:52​:37 2016, demerphq wrote​:

On 25 June 2016 at 13​:02, Andreas J. Koenig via RT
<perlbug-followup@​perl.org> wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #128482]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=128482 >

bisect
------
commit 8bf4c40
Author​: Yves Orton <demerphq@​gmail.com>
Date​: Mon Jun 20 22​:51​:38 2016 +0200

Change scalar\(%hash\) to be the same as 0\+keys\(%hash\)

This tests that scalar() passes through to the perl internal
definition for scalar(%hash), which changed in 5.25

like($pre_v5_8_3 ? tied(%hash)->scalar : scalar(%hash), qr{\d+/\d+},
'Standard hash​: buckets allocated in scalar context')
or diag('scalar %hash​: '
. $pre_v5_8_3 ? tied(%hash)->scalar : scalar(%hash));

It could be changed to only test the booleanness of the scalar(%hash),
or it could be taught that in 5.25 and later the return of
scalar(%hash) is supposed to be the count of keys. I note that in
other contexts it returns 0/1 so...

Yves

Another victim​:
garu/Data-Printer#98

@p5pRT
Copy link
Author

p5pRT commented Aug 21, 2016

From @andk

also affected


Ticket​: garu/Data-Printer#98
Distro​: GARU/Data-Printer-0.38.tar.gz

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Aug 24, 2016

From @eserte

Also affected​:

SKIM/Tie-Hash-Check-0.03.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=117194

@p5pRT
Copy link
Author

p5pRT commented Dec 6, 2016

From @jkeenan

On Wed, 24 Aug 2016 18​:25​:06 GMT, slaven@​rezic.de wrote​:

Also affected​:

SKIM/Tie-Hash-Check-0.03.tar.gz
https://rt.cpan.org/Ticket/Display.html?id=117194

This BBC failure has been reported Resolved​:

https://rt.cpan.org/Ticket/Display.html?id=117194
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Dec 6, 2016

From @jkeenan

On Sun, 21 Aug 2016 16​:49​:28 GMT, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

also affected
-------------
Ticket​: garu/Data-Printer#98
Distro​: GARU/Data-Printer-0.38.tar.gz

This BBC failure has been reported resolved at github level, awaiting CPAN release​:

garu/Data-Printer#97

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Dec 26, 2016

From @jkeenan

In Tie-REHash's bug tracker (https://rt.cpan.org/Ticket/Display.html?id=115659#txn-1693542) I have presented the maintainer with Yves's options for fixing the failing test or with the option of simply deleting it.

We've communicated with all of the CPAN distros mentioned in this ticket. So I'm resolving the ticket.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Dec 26, 2016

@jkeenan - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Dec 26, 2016
@p5pRT p5pRT added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Severity Low distro-All labels Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) distro-All
Projects
None yet
Development

No branches or pull requests

1 participant