Bleadperl v5.25.0-80-g2e6807b breaks XSAWYERX/Dancer2-0.200000.tar.gz #15389
Comments
From @andkbisect commit 2e6807b Make barewords constant-foldable patching prerequisites The following distroprefs file allows installing a fixed Type::Tiny that match: diagnostics http://www.cpantesters.org/cpan/report/7d47f67c-2dc6-11e6-82d3-c225a8c6b5db rt.cpan perl -V Summary of my perl5 (revision 5 version 25 subversion 1) configuration: Characteristics of this binary (from libperl): -- |
From @tonycozOn Wed Jun 08 22:12:33 2016, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
This patch appears to make bareword strict errors report a little earlier, so the code in lib/Dancer2/Core/Request.pm: eval << "_EVAL" for @http_env_keys; ## no critic now fails before the sub is defined, causing the test failures you're seeing. There's two bugs here, one is the code is discarding any errors, changing it to: eval << "_EVAL" or die $@ for @http_env_keys; ## no critic makes the problem very obvious: # Failed test 'use Dancer2::Core::Request;' at which point the fix is obvious - quoting the literal: eval << "_EVAL" or die $@ for @http_env_keys; ## no critic Created PerlDancer/Dancer2#1190 with the fix. Closing. Tony |
|
The RT System itself - Status changed from 'new' to 'open' |
|
@tonycoz - Status changed from 'open' to 'pending release' |
From @SmylersTony Cook via RT writes:
Should that aspect of the change be added to perldelta then — strict Smylers |
From @tonycozOn Thu, Jun 16, 2016 at 06:58:01AM +0100, Smylers wrote:
There's been no change as in *whether* an error is thrown. The code in Request.pm was ignoring any errors thrown. Only in whether the sub definition survives the throwing the error, Tony |
From @xsawyerxTony's fix was merged into Dancer2 and Dancer2 0.200001 was released today to CPAN with the fix. This was resolved upstream as well. Thanks, Tony! :) |
From @xsawyerxThis was resolved by applying Tony's fix, mentioned above. |
|
@xsawyerx - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#128352 (status was 'resolved')
Searchable as RT128352$
The text was updated successfully, but these errors were encountered: