Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kebab case for named parameters in Test.pm6 #5346

Closed
p6rt opened this issue May 29, 2016 · 7 comments
Closed

Use kebab case for named parameters in Test.pm6 #5346

p6rt opened this issue May 29, 2016 · 7 comments
Labels
RFC Request For Comments

Comments

@p6rt
Copy link

p6rt commented May 29, 2016

Migrated from rt.perl.org#128282 (status was 'resolved')

Searchable as RT128282$

@p6rt
Copy link
Author

p6rt commented May 29, 2016

From @zoffixznet

The `is-approx` sub in Test.pm6 module has a multi that take optional rel_tol and abs_tol parameters​: https://github.com/rakudo/rakudo/blob/5638a13ab46b4017ebd7f79dd437a68f0b1eb268/lib/Test.pm6#L246

The snake_case naming of those parameters is inconsistent with the use of kebob-case throughout the entire module and I propose those parameters be renamed to rel-tol and abs-tol.

I'm willing to do the work, if the proposal is accepted. The question then becomes​: should the old names stay?

@p6rt
Copy link
Author

p6rt commented May 29, 2016

From @tbrowder

On Sunday, May 29, 2016, Zoffix Znet <perl6-bugs-followup@​perl.org> wrote​:
...

I'm willing to do the work, if the proposal is accepted. The question then
becomes​: should the old names stay?

I support your proposal for kebob-casing.

-Tom

[tbrowder]

@p6rt
Copy link
Author

p6rt commented May 29, 2016

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented May 29, 2016

From @smls

Do we usually use kebab case for named parameters as well, or just for routine names?
(I'd prefer kebab for both.)

For backwards compatibility, you'd probably have to continue allowing the old names though, but print a deprecation warning for them.

@p6rt
Copy link
Author

p6rt commented Jun 11, 2016

From @zoffixznet

Proposed PR to fix this​: rakudo/rakudo#783

@p6rt
Copy link
Author

p6rt commented Jun 11, 2016

From @zoffixznet

Resolved by this commit​: rakudo/rakudo@bb165a5

@p6rt p6rt closed this as completed Jun 11, 2016
@p6rt
Copy link
Author

p6rt commented Jun 11, 2016

@zoffixznet - Status changed from 'open' to 'resolved'

@p6rt p6rt added the RFC Request For Comments label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

No branches or pull requests

1 participant