New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kebab case for named parameters in Test.pm6 #5346
Comments
From @zoffixznetThe `is-approx` sub in Test.pm6 module has a multi that take optional rel_tol and abs_tol parameters: https://github.com/rakudo/rakudo/blob/5638a13ab46b4017ebd7f79dd437a68f0b1eb268/lib/Test.pm6#L246 The snake_case naming of those parameters is inconsistent with the use of kebob-case throughout the entire module and I propose those parameters be renamed to rel-tol and abs-tol. I'm willing to do the work, if the proposal is accepted. The question then becomes: should the old names stay? |
From @tbrowderOn Sunday, May 29, 2016, Zoffix Znet <perl6-bugs-followup@perl.org> wrote:
I support your proposal for kebob-casing. -Tom [tbrowder] |
The RT System itself - Status changed from 'new' to 'open' |
From @smlsDo we usually use kebab case for named parameters as well, or just for routine names? For backwards compatibility, you'd probably have to continue allowing the old names though, but print a deprecation warning for them. |
From @zoffixznetProposed PR to fix this: rakudo/rakudo#783 |
From @zoffixznetResolved by this commit: rakudo/rakudo@bb165a5 |
@zoffixznet - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#128282 (status was 'resolved')
Searchable as RT128282$
The text was updated successfully, but these errors were encountered: