Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files in git repository that are in DOS format #15374

Open
p5pRT opened this issue May 27, 2016 · 7 comments
Open

Files in git repository that are in DOS format #15374

p5pRT opened this issue May 27, 2016 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented May 27, 2016

Migrated from rt.perl.org#128269 (status was 'open')

Searchable as RT128269$

@p5pRT
Copy link
Author

p5pRT commented May 27, 2016

From @khwilliamson

Files in git repository that are in DOS format

The following files should be converted to unix, unless there is a good reason for them being in DOS. (Also all of Pod​::Parser is in DOS, but it is hopefully soon going to be removed from core blead, so there's no real reason to expend effort on it.) I omitted one file whose name ends in .bat, and some in a Win32 directory, as those appear to me to likely to want to be in DOS.

./cpan/Text-ParseWords/t/ParseWords.t
./cpan/JSON-PP/t/107_allow_singlequote.t
./cpan/JSON-PP/t/106_allow_barekey.t
./cpan/JSON-PP/t/105_esc_slash.t
./cpan/CPAN-Meta/t/data-fixable/1927486199-META.yml
./cpan/Parse-CPAN-Meta/corpus/BadMETA.yml
./symbian/ext/Moped/Msg/Msg.pkg
./symbian/ext/Moped/Msg/bld.inf
./symbian/ext/Moped/Msg/Msg.mmp
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented May 30, 2016

From @jkeenan

On Fri May 27 09​:57​:30 2016, khw wrote​:

Files in git repository that are in DOS format

The following files should be converted to unix, unless there is a
good reason for them being in DOS. (Also all of Pod​::Parser is in
DOS, but it is hopefully soon going to be removed from core blead, so
there's no real reason to expend effort on it.) I omitted one file
whose name ends in .bat, and some in a Win32 directory, as those
appear to me to likely to want to be in DOS.

./cpan/Text-ParseWords/t/ParseWords.t
./cpan/JSON-PP/t/107_allow_singlequote.t
./cpan/JSON-PP/t/106_allow_barekey.t
./cpan/JSON-PP/t/105_esc_slash.t
./cpan/CPAN-Meta/t/data-fixable/1927486199-META.yml
./cpan/Parse-CPAN-Meta/corpus/BadMETA.yml
./symbian/ext/Moped/Msg/Msg.pkg
./symbian/ext/Moped/Msg/bld.inf
./symbian/ext/Moped/Msg/Msg.mmp

The files under cpan/ are maintained upstream on CPAN, so a change ought to originate upstream.

As for the files under symbian, they are maintained by (or, at least, last modified by) Jarkko, so I would recommend consulting with him first.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented May 30, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 30, 2016

From @jhi

On Fri May 27 09​:57​:30 2016, khw wrote​:

Files in git repository that are in DOS format

The following files should be converted to unix, unless there is a
good reason for them being in DOS.

Umm, might I ask the reverse and ask ... why?

I'm no fan of "curliff", quite the reverse, but what is the problem here that such conversion is trying to address? Perl code should be fine with either "unixy" or "dossy", ditto for git.

As for the Symbian files​: do not convert them to UNIX, things are quite likely to break if they are converted. (Though I have no idea whether the thing anymore builds at all, Symbian being quite dead.)

(Also all of Pod​::Parser is in
DOS, but it is hopefully soon going to be removed from core blead, so
there's no real reason to expend effort on it.) I omitted one file
whose name ends in .bat, and some in a Win32 directory, as those
appear to me to likely to want to be in DOS.

./cpan/Text-ParseWords/t/ParseWords.t
./cpan/JSON-PP/t/107_allow_singlequote.t
./cpan/JSON-PP/t/106_allow_barekey.t
./cpan/JSON-PP/t/105_esc_slash.t
./cpan/CPAN-Meta/t/data-fixable/1927486199-META.yml
./cpan/Parse-CPAN-Meta/corpus/BadMETA.yml
./symbian/ext/Moped/Msg/Msg.pkg
./symbian/ext/Moped/Msg/bld.inf
./symbian/ext/Moped/Msg/Msg.mmp

@p5pRT
Copy link
Author

p5pRT commented May 30, 2016

From @khwilliamson

On 05/30/2016 07​:59 AM, Jarkko Hietaniemi via RT wrote​:

On Fri May 27 09​:57​:30 2016, khw wrote​:

Files in git repository that are in DOS format

The following files should be converted to unix, unless there is a
good reason for them being in DOS.

Umm, might I ask the reverse and ask ... why?

That was a statement from the recently abdicated pumpking, and the
current one concurred.

I'm no fan of "curliff", quite the reverse, but what is the problem here that such conversion is trying to address? Perl code should be fine with either "unixy" or "dossy", ditto for git.

It caused me quite a bit of pain to deal with these in Pod​::Checker. It
appears to be a bug in git (v2.5), and I had to get someone else
involved (using an earlier git) to actually get stuff into blead.

As for the Symbian files​: do not convert them to UNIX, things are quite likely to break if they are converted. (Though I have no idea whether the thing anymore builds at all, Symbian being quite dead.)

(Also all of Pod​::Parser is in
DOS, but it is hopefully soon going to be removed from core blead, so
there's no real reason to expend effort on it.) I omitted one file
whose name ends in .bat, and some in a Win32 directory, as those
appear to me to likely to want to be in DOS.

./cpan/Text-ParseWords/t/ParseWords.t
./cpan/JSON-PP/t/107_allow_singlequote.t
./cpan/JSON-PP/t/106_allow_barekey.t
./cpan/JSON-PP/t/105_esc_slash.t
./cpan/CPAN-Meta/t/data-fixable/1927486199-META.yml
./cpan/Parse-CPAN-Meta/corpus/BadMETA.yml
./symbian/ext/Moped/Msg/Msg.pkg
./symbian/ext/Moped/Msg/bld.inf
./symbian/ext/Moped/Msg/Msg.mmp

@p5pRT
Copy link
Author

p5pRT commented Jun 1, 2016

From @khwilliamson

On 05/29/2016 07​:07 PM, James E Keenan via RT wrote​:

On Fri May 27 09​:57​:30 2016, khw wrote​:

Files in git repository that are in DOS format

The following files should be converted to unix, unless there is a
good reason for them being in DOS. (Also all of Pod​::Parser is in
DOS, but it is hopefully soon going to be removed from core blead, so
there's no real reason to expend effort on it.) I omitted one file
whose name ends in .bat, and some in a Win32 directory, as those
appear to me to likely to want to be in DOS.

./cpan/Text-ParseWords/t/ParseWords.t
./cpan/JSON-PP/t/107_allow_singlequote.t
./cpan/JSON-PP/t/106_allow_barekey.t
./cpan/JSON-PP/t/105_esc_slash.t
./cpan/CPAN-Meta/t/data-fixable/1927486199-META.yml
./cpan/Parse-CPAN-Meta/corpus/BadMETA.yml
./symbian/ext/Moped/Msg/Msg.pkg
./symbian/ext/Moped/Msg/bld.inf
./symbian/ext/Moped/Msg/Msg.mmp

The files under cpan/ are maintained upstream on CPAN, so a change ought to originate upstream.

It's not clear to me that this is actually something in the CPAN
versions. I don't know enough about the "system". What I do know is
that when I downloaded Pod​::Checker 1.72 from a tarball on CPAN, that it
had unix line endings when I unpacked it, whereas the version in blead
had dos line endings. I don't know if we can just change the blead line
endings without having to bump the version number and notify the
upstream maintainer.

As for the files under symbian, they are maintained by (or, at least, last modified by) Jarkko, so I would recommend consulting with him first.

Thank you very much.

@p5pRT
Copy link
Author

p5pRT commented Jun 7, 2016

From @xsawyerx

On 05/30/2016 03​:59 PM, Jarkko Hietaniemi via RT wrote​:

On Fri May 27 09​:57​:30 2016, khw wrote​:

Files in git repository that are in DOS format

The following files should be converted to unix, unless there is a
good reason for them being in DOS.
Umm, might I ask the reverse and ask ... why?

I'm no fan of "curliff", quite the reverse, but what is the problem here that such conversion is trying to address? Perl code should be fine with either "unixy" or "dossy", ditto for git.

This was raised, as Karl notes, while trying to work through the
Pod​::Checker issue. Given this already came up, why not clear it up
before it comes up again, where no breakage expected?

As for the Symbian files​: do not convert them to UNIX, things are quite likely to break if they are converted. (Though I have no idea whether the thing anymore builds at all, Symbian being quite dead.)

Interesting. I wouldn't have guessed so. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants