Clarification of File::Copy documentation #15345
Comments
From @rrthomasCreated by @rrthomasIt could be made clearer that the rmscopy function is VMS-specific. This is If I try to import rmscopy on my GNU/Linux system, I get the error that it Perl Info |
From @jkeenanOn Fri May 20 14:28:19 2016, rrt wrote:
Would you be able to supply a patch for the area where you think improvements are needed? (Preferably drawn against blead or perl 5.24.) Thank you very much. -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @ap* rrt@sc3d.org <perlbug-followup@perl.org> [2016-05-21 00:23]:
In fact things go even further than that. It is never exported, *ever*, *However*, under VMS, you can *always* call File::Copy::rmscopy - even Now, adding a sentence that the function is VMS-only is trivial enough. But I’m unclear on whether the exact status of the function ought to be Regards, |
From @rrthomasOn 21 May 2016 at 03:23, James E Keenan via RT <perlbug-followup@perl.org>
I think in this case it's better if we each spend time maintaining If it were possible simply to suggest small edits directly in the web page The other useful thing would be a style guide; I found perlpodstyle, but I do understand that there are too few of you faced with a mountain of -- |
From @xsawyerxOn 05/21/2016 07:46 AM, Aristotle Pagaltzis wrote:
Considering this poses a special case, it might help documenting this in |
From @tonycozOn Fri May 20 14:28:19 2016, rrt wrote:
How about the attached? Tony |
From @tonycoz0001-perl-128199-rmscopy-is-VMS-specific-and-not-exported.patchFrom 5889a3520c0f42ac247dc3c8b5e6c04d2d114c16 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Thu, 2 Jun 2016 14:13:14 +1000
Subject: [PATCH] (perl #128199) rmscopy() is VMS specific and not exported
The first is kind of implied by the text, but make it explicit.
---
lib/File/Copy.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/File/Copy.pm b/lib/File/Copy.pm
index 842bd31..330e2df 100644
--- a/lib/File/Copy.pm
+++ b/lib/File/Copy.pm
@@ -22,7 +22,7 @@ sub syscopy;
sub cp;
sub mv;
-$VERSION = '2.31';
+$VERSION = '2.32';
require Exporter;
@ISA = qw(Exporter);
@@ -479,6 +479,11 @@ from the input filespec, then all timestamps other than the
revision date are propagated. If this parameter is not supplied,
it defaults to 0.
+C<rmscopy> is VMS specific and cannot be exported, it must be
+referenced by its full name, eg:
+
+ File::Copy::rmscopy($from, $to) or die $!;
+
Like C<copy>, C<rmscopy> returns 1 on success. If an error occurs,
it sets C<$!>, deletes the output file, and returns 0.
--
2.1.4
|
From @rrthomasOn 2 June 2016 at 05:13, Tony Cook via RT <perlbug-followup@perl.org> wrote:
That's great; a couple of language fixes: +C<rmscopy> is VMS specific and cannot be exported, it must be Change comma after "exported" to semi-colon.
"eg" should be "e.g.". Thanks very much for this. -- |
From @tonycozOn Thu Jun 02 01:53:00 2016, rrt wrote:
Thanks, adjustments made and applied in 4ef6d38. Tony |
|
@tonycoz - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been Perl 5.26.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#128199 (status was 'resolved')
Searchable as RT128199$
The text was updated successfully, but these errors were encountered: