Patch for perlbug.PL #15336
Comments
From klaus@soonix.deCreated by klaus@soonix.deThis is a bug report for perl from klaus@soonix.de, ----------------------------------------------------------------- Perl Info |
From klaus@soonix.de0001-changed-perlbug-success-notification-motivated-by-ht.patchFrom 0a4dddae0bea94eab13a6884ab350903b9f5a107 Mon Sep 17 00:00:00 2001
From: Klaus Baldermann <klaus@soonix.de>
Date: Wed, 18 May 2016 18:50:48 +0000
Subject: [PATCH] changed perlbug success notification, motivated by
http://www.perlmonks.org/?node_id=1162919
---
AUTHORS | 1 +
utils/perlbug.PL | 9 +++++----
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index a055b67..8ef9e3c 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -710,6 +710,7 @@ Kim Frutiger
Kingpin <mthurn@copper.dulles.tasc.com>
Kirrily Robert <skud@infotrope.net>
Kiyotaka Sakai <ksakai@netwk.ntt-at.co.jp>
+Klaus Baldermann <klaus@soonix.de>
kmx <kmx@volny.cz>
Kragen Sitaker <kragen@pobox.com>
Krishna Sethuraman <krishna@sgi.com>
diff --git a/utils/perlbug.PL b/utils/perlbug.PL
index 720cf12..baa67d2 100644
--- a/utils/perlbug.PL
+++ b/utils/perlbug.PL
@@ -33,7 +33,6 @@ my $patchlevel_date = (stat _)[9];
# used, compare $Config::config_sh with the stored version. If they differ then
# append a list of individual differences to the bug report.
-
print "Extracting $file (with variable substitutions)\n";
# In this section, perl variables will be expanded during extraction.
@@ -101,6 +100,8 @@ my $perl_version = $^V ? sprintf("%vd", $^V) : $];
my $config_tag2 = "$perl_version - $Config{cf_time}";
+my $success_msg = "\nMessage has been handed over to this computer's mail system\n";
+
Init();
if ($opt{h}) { Help(); exit; }
@@ -1139,7 +1140,7 @@ sub _send_message_vms {
print $sff_fh build_complete_message();
my $success = close $sff_fh;
if ($success ) {
- print "\nMessage sent\n";
+ print $success_msg;
return;
}
}
@@ -1160,7 +1161,7 @@ sub _send_message_mailsend {
print $fh _add_attachments() if $have_attachment;
$fh->close or die "Error sending mail: $!";
- print "\nMessage sent.\n";
+ print $success_msg;
}
sub _probe_for_sendmail {
@@ -1204,7 +1205,7 @@ EOF
|| die "'|$sendmail -t -oi -f $from' failed: $!";
print SENDMAIL build_complete_message();
if ( close(SENDMAIL) ) {
- print "\nMessage sent\n";
+ print $success_msg;
} else {
warn "\nSendmail returned status '", $? >> 8, "'\n";
}
--
2.1.4
|
From @jkeenanOn Wed May 18 12:20:33 2016, klaus@soonix.de wrote:
Speaking for $self: I think I'd find this error message: ##### ... just as confusing as the one it replaces. I suspect that most people do not use their "computer's mail system" to send mail; they use Thunderbird or Outlook or some other mail client. But, as I know from experience, 'perlbug' does *not* hand its message over to one's email client. On the rare occasions when I use 'perlbug' (rather than logging into rt.perl.org), I only use it to compose a message which I then save and mail via Thunderbird. So this patch wouldn't really help me -- but that's just my two cents.
-- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Thu May 19 18:11:47 2016, jkeenan wrote:
I'm not sure it helps either. The original discussion appears to be at: http://perlmonks.org/?node_id=1162919 It's possible the correct solution is a patch for #121553, though that's going to be ugly if the mailer is configured for Thunderbird and you're in a non-"-Y" ssh session. Tony |
Migrated from rt.perl.org#128180 (status was 'open')
Searchable as RT128180$
The text was updated successfully, but these errors were encountered: