Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] silence Module::Metadata diagnostics #15328

Closed
p5pRT opened this issue May 16, 2016 · 5 comments
Closed

[PATCH] silence Module::Metadata diagnostics #15328

p5pRT opened this issue May 16, 2016 · 5 comments

Comments

@p5pRT
Copy link

p5pRT commented May 16, 2016

Migrated from rt.perl.org#128160 (status was 'resolved')

Searchable as RT128160$

@p5pRT
Copy link
Author

p5pRT commented May 16, 2016

From @karenetheridge

as requested in RT#128153. I'll include this fix in the next cpan release as well.

@p5pRT
Copy link
Author

p5pRT commented May 16, 2016

From @karenetheridge

0001-do-not-dump-verbose-diagnostics-in-perl-core.patch
From 7583d7c338c39bf78674a4a1ece18478d1658df2 Mon Sep 17 00:00:00 2001
From: Karen Etheridge <ether@cpan.org>
Date: Mon, 16 May 2016 14:35:45 -0700
Subject: [PATCH] do not dump verbose diagnostics in perl core

---
 cpan/Module-Metadata/t/extract-package.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cpan/Module-Metadata/t/extract-package.t b/cpan/Module-Metadata/t/extract-package.t
index db99dae..b1b776c 100644
--- a/cpan/Module-Metadata/t/extract-package.t
+++ b/cpan/Module-Metadata/t/extract-package.t
@@ -159,7 +159,7 @@ foreach my $test_case (@pkg_names) {
             or $errs++;
   }
     is( $warnings, '', "case $test_case->{name}: no warnings from parsing" ) or $errs++;
-    diag "Got: '" . join(', ', @got) . "'\nModule contents:\n$code" if $errs;
+    diag "Got: '" . join(', ', @got) . "'\nModule contents:\n$code" if !$ENV{PERL_CORE} && $errs;
 }
 continue {
   ++$test_num;
-- 
2.6.2

@p5pRT
Copy link
Author

p5pRT commented May 16, 2016

From @jkeenan

On Mon May 16 14​:38​:51 2016, ether wrote​:

as requested in RT#128153. I'll include this fix in the next cpan
release as well.

Thanks. Confirmed results. Applied to blead in commit 9ec9395.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented May 16, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 16, 2016

@jkeenan - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant