-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probably removing a p6bool where it shouldn't #5252
Comments
From @lizmat[17:01:04] <lizmat> m: my $a = 42; say $a =:= $a; say $a.WHAT =:= $a.WHAT; say $a == $a; say $a =:= $a || $a.WHAT =:= $a.WHAT # where does the 1 come from ??? |
From @lizmatuguexe++ reporting, sortiz++ for following up http://irclog.perlgeek.de/p6dev/2016-05-07#i_12446753 <lizmat> m: my $a = "a"; say $a =:= $a # yeah, True |
From @zoffixznetStill present in This is Rakudo version 2016.06-154-g55c359e built on MoarVM version 2016.06-9-g8fc21d5 zoffix@VirtualBox:~$ perl6 --optimize=1 -e 'my $a = 42; say $a =:= $a || $a.WHAT =:= $a.WHAT' |
From @usev6I think the p6bool is removed here: https://github.com/rakudo/rakudo/blob/605f272881a76f0c5a9e352670a1e61eaa627ca6/src/Perl6/Optimizer.nqp#L1300 As far as I understand, the following code shows the problem at a lower level (no differentiation between optimize=(1|2) required -- it happens on all levels): $ ./perl6-m --optimize=off -e 'use nqp; say nqp::unless(nqp::p6bool(nqp::iseq_i(42,42)), False)' $ ./perl6-m --optimize=0 -e 'use nqp; say nqp::unless(nqp::p6bool(nqp::iseq_i(42,42)), False)' I have no idea how it can be fixed, though. Maybe it's not even feasible to do what the comment above the relevant code block promises? # Some ops have first boolean arg, and we may be able to get rid of |
1 similar comment
From @usev6I think the p6bool is removed here: https://github.com/rakudo/rakudo/blob/605f272881a76f0c5a9e352670a1e61eaa627ca6/src/Perl6/Optimizer.nqp#L1300 As far as I understand, the following code shows the problem at a lower level (no differentiation between optimize=(1|2) required -- it happens on all levels): $ ./perl6-m --optimize=off -e 'use nqp; say nqp::unless(nqp::p6bool(nqp::iseq_i(42,42)), False)' $ ./perl6-m --optimize=0 -e 'use nqp; say nqp::unless(nqp::p6bool(nqp::iseq_i(42,42)), False)' I have no idea how it can be fixed, though. Maybe it's not even feasible to do what the comment above the relevant code block promises? # Some ops have first boolean arg, and we may be able to get rid of |
@usev6 - Status changed from 'new' to 'open' |
From @dogbert17On Fri, 07 Oct 2016 14:03:39 -0700, bartolin@gmx.de wrote:
Looks as if this was fixed with rakudo/rakudo@f8b3469. Tests needed. |
From @dogbert17On Fri, 14 Jul 2017 13:31:42 -0700, jan-olof.hendig@bredband.net wrote:
Added in Raku/roast@39802b5b2b. Closing issue. |
@dogbert17 - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#127951 (status was 'resolved')
Searchable as RT127951$
The text was updated successfully, but these errors were encountered: