Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(post 5.24) fix some slightly mangled documentation #15271

Closed
p5pRT opened this issue Apr 12, 2016 · 10 comments
Closed

(post 5.24) fix some slightly mangled documentation #15271

p5pRT opened this issue Apr 12, 2016 · 10 comments

Comments

@p5pRT
Copy link

p5pRT commented Apr 12, 2016

Migrated from rt.perl.org#127882 (status was 'resolved')

Searchable as RT127882$

@p5pRT
Copy link
Author

p5pRT commented Apr 12, 2016

From @tonycoz

This looks like someone manually applied a patch and missed removing the leading + from some of the lines.

@p5pRT
Copy link
Author

p5pRT commented Apr 12, 2016

From @tonycoz

0001-fix-documentation-mangled-by-a-probably-manually-app.patch
From cf891dd2cbc4d51ae822940444ff30eaee1e8a3e Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Tue, 12 Apr 2016 17:04:58 +1000
Subject: fix documentation mangled by a probably manually applied patch

---
 dist/IO/lib/IO/Handle.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dist/IO/lib/IO/Handle.pm b/dist/IO/lib/IO/Handle.pm
index aebf74e..ce976b0 100644
--- a/dist/IO/lib/IO/Handle.pm
+++ b/dist/IO/lib/IO/Handle.pm
@@ -122,8 +122,8 @@ otherwise.
 This works like <$io> described in L<perlop/"I/O Operators">
 except that it's more readable and can be safely called in a
 list context but still returns just one line.  If used as the conditional
-+within a C<while> or C-style C<for> loop, however, you will need to
-+emulate the functionality of <$io> with C<< defined($_ = $io->getline) >>.
+within a C<while> or C-style C<for> loop, however, you will need to
+emulate the functionality of <$io> with C<< defined($_ = $io->getline) >>.
 
 =item $io->getlines
 
@@ -271,7 +271,7 @@ use IO ();	# Load the XS module
 require Exporter;
 @ISA = qw(Exporter);
 
-$VERSION = "1.35";
+$VERSION = "1.36";
 $VERSION = eval $VERSION;
 
 @EXPORT_OK = qw(
-- 
2.1.4

@p5pRT
Copy link
Author

p5pRT commented Apr 12, 2016

From @jkeenan

On Tue Apr 12 00​:07​:02 2016, tonyc wrote​:

This looks like someone manually applied a patch and missed removing
the leading + from some of the lines.

Does a small documentation correction like this have to wait until 5.25.0?

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 12, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 12, 2016

From @jkeenan

On Tue Apr 12 03​:09​:28 2016, jkeenan wrote​:

On Tue Apr 12 00​:07​:02 2016, tonyc wrote​:

This looks like someone manually applied a patch and missed removing
the leading + from some of the lines.

Does a small documentation correction like this have to wait until 5.25.0?

The documentation error in question dates to June 2005.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 12, 2016

From @rjbs

* James E Keenan via RT <perlbug-followup@​perl.org> [2016-04-12T06​:09​:29]

On Tue Apr 12 00​:07​:02 2016, tonyc wrote​:

This looks like someone manually applied a patch and missed removing
the leading + from some of the lines.

Does a small documentation correction like this have to wait until 5.25.0?

No, I reckon not.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Apr 13, 2016

From @tonycoz

On Tue Apr 12 04​:39​:14 2016, perl.p5p@​rjbs.manxome.org wrote​:

* James E Keenan via RT <perlbug-followup@​perl.org> [2016-04-12T06​:09​:29]

On Tue Apr 12 00​:07​:02 2016, tonyc wrote​:

This looks like someone manually applied a patch and missed removing
the leading + from some of the lines.

Does a small documentation correction like this have to wait until 5.25.0?

No, I reckon not.

Applied as 000aab2 with a commit message adjustment (it was a bit too vague.)

Tony

@p5pRT
Copy link
Author

p5pRT commented Apr 13, 2016

@tonycoz - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.
 
With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant