ExtUtils::ParseXS breaks compilation of XS modules on 5.8.5 with -Duseithreads -Doptimize='-g' -DDEBUGGING on gcc5.3.1 #15236
Comments
From @wolfsageCreated by WolfSage@gmail.comReported by ribasushi on Devel::PPPort initially ( Building and testing Devel-PPPort-3.32 ... cp PPPort.pm /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:115:18: /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:2619:40: /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:120:18: /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:2773:17: /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:115:18: /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:2619:40: /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:120:18: /home/rabbit/perl5/perlbrew/perls/5.8.5_dbg/lib/5.8.5/x86_64-linux-thread-multi/CORE/perl.h:2773:17: It turned out to be that the latest ExtUtils::ParseXS was installed, and STATIC void PERL_ARGS_ASSERT_CROAK_XS_USAGE; if (gv) { If we add dTHX; to the beginning of the function, compilation succeeds. #ifdef PERL_NO_GET_CONTEXT which it has on other functions? Perl Info |
From @jkeenanOn Fri, 18 Mar 2016 15:04:15 GMT, alh wrote:
I'm confused as to where in the source code you think such a change should be applied. I don't see that 'ifdef' anywhere in ExtUtils-ParseXS. ##### cpan/Devel-PPPort/parts/inc/newCONSTSUB Thank you very much. |
|
The RT System itself - Status changed from 'new' to 'open' |
From @wolfsageOn Thu, Jan 5, 2017 at 4:03 PM, James E Keenan via RT
I don't recall my original reasoning. However S_croak_xs_usage in core does this: vutil.h:S_croak_xs_usage(pTHX_ const CV *const cv, const char *const params); Whereas ExtUtils::ParseXS only does this: lib/ExtUtils/ParseXS/Utilities.pm:S_croak_xs_usage(const CV *const Seems to me like it's missing the pTHX depending on PERL_IMPLICIT_CONTEXT... -- Matthew Horsfall (alh) |
@wolfsage, can you review this ticket for closability? In your most recent comment, you referred to Nor does this function still appear in the upstream Since (i) @xsawyerx is planning a new CPAN release of EU::PXS, and (ii) there are other EU::PXS issues pending, we should see if we can clean up older tickets for this distro. Thank you very much. |
|
Maybe it's better to do the release without it so as to not stress anyone to wrap something up for the release. Once one is done, it's easier to do the next one. |
|
I think the steps (for anyone) to confirm if this is still an issue are:
If it still fails similarly, some work could be done (if we want to support 5.8.5 still, assuming this issue also doesn't affect other perl versions) |
That's cool. Your volunteering to do a CPAN release just got me to look at old tickets, and this appeared to be the most closable. |
I tried to build perl-5.8.5 from source and failed twice. The first time was from the tag for that release in the GH repository. The second was by obtaining buildperl.pl and calling: In both cases, Any suggestions? Thank you very much. |
|
I think https://metacpan.org/pod/Devel::PatchPerl should get it to build, buildperl in Devel::PPPort always gave me trouble |
Migrated from rt.perl.org#127739 (status was 'open')
Searchable as RT127739$
The text was updated successfully, but these errors were encountered: