Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Add contributing/VCS repository info to Carp.pm #15224

Closed
p5pRT opened this issue Mar 10, 2016 · 8 comments
Closed

[PATCH] Add contributing/VCS repository info to Carp.pm #15224

p5pRT opened this issue Mar 10, 2016 · 8 comments

Comments

@p5pRT
Copy link

p5pRT commented Mar 10, 2016

Migrated from rt.perl.org#127690 (status was 'resolved')

Searchable as RT127690$

@p5pRT
Copy link
Author

p5pRT commented Mar 10, 2016

From @shlomif

Hi all,

this patch adds contributing/VCS repository information to Carp.pm’s
documentation. It also can be found here​:

https://github.com/shlomif/perl5/tree/shlomif--Carp.pm-improvements

Regards,

  Shlomi Fish

@p5pRT
Copy link
Author

p5pRT commented Mar 10, 2016

From @shlomif

0001-Add-contributing-info-to-Carp.patch
From d4a1a58fb041ce601a8c297aca4cb6535d188961 Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Thu, 10 Mar 2016 21:32:41 +0200
Subject: [PATCH] Add contributing info to Carp.

It lacked a link to the VCS repository so I had to ask rjbs about it on
the #p5p IRC channel. And one should always fix a problem twice:

* http://www.joelonsoftware.com/articles/customerservice.html .
---
 dist/Carp/Changes           | 3 +++
 dist/Carp/lib/Carp.pm       | 8 +++++++-
 dist/Carp/lib/Carp/Heavy.pm | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/dist/Carp/Changes b/dist/Carp/Changes
index 13cdfdf..b90b395 100644
--- a/dist/Carp/Changes
+++ b/dist/Carp/Changes
@@ -1,4 +1,7 @@
 
+version 1.39_01; 2016-03-10
+  * Add information for how to contribute to Carp.
+
 version 1.39; 2016-03-06
   * bugfix: longmess() should return the error in scalar context
   (CPANRT#107225)
diff --git a/dist/Carp/lib/Carp.pm b/dist/Carp/lib/Carp.pm
index f39302d..79341c0 100644
--- a/dist/Carp/lib/Carp.pm
+++ b/dist/Carp/lib/Carp.pm
@@ -87,7 +87,7 @@ BEGIN {
     }
 }
 
-our $VERSION = '1.39';
+our $VERSION = '1.39_01';
 $VERSION =~ tr/_//d;
 
 our $MaxEvalLen = 0;
@@ -908,6 +908,12 @@ call die() or warn(), as appropriate.
 L<Carp::Always>,
 L<Carp::Clan>
 
+=head1 CONTRIBUTING
+
+L<Carp> is maintained by the perl 5 porters as part of the core perl 5
+version control repository. Please see the L<perlhack> perldoc for how to
+submit patches and contribute to it.
+
 =head1 AUTHOR
 
 The Carp module first appeared in Larry Wall's perl 5.000 distribution.
diff --git a/dist/Carp/lib/Carp/Heavy.pm b/dist/Carp/lib/Carp/Heavy.pm
index 6ac932a..b7aa19d 100644
--- a/dist/Carp/lib/Carp/Heavy.pm
+++ b/dist/Carp/lib/Carp/Heavy.pm
@@ -2,7 +2,7 @@ package Carp::Heavy;
 
 use Carp ();
 
-our $VERSION = '1.39';
+our $VERSION = '1.39_01';
 $VERSION =~ tr/_//d;
 
 # Carp::Heavy was merged into Carp in version 1.12.  Any mismatched versions
-- 
2.7.2

@p5pRT
Copy link
Author

p5pRT commented Mar 17, 2016

@khwilliamson - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Mar 17, 2016

From @khwilliamson

Thanks, applied as 8b2caac
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Mar 17, 2016

@khwilliamson - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented Mar 18, 2016

From @shlomif

On Wed, 16 Mar 2016 20​:40​:00 -0700
"Karl Williamson via RT" <perlbug-followup@​perl.org> wrote​:

Thanks, applied as 8b2caac

Thanks!

Regards, -- Shlomi

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.
 
With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

@p5pRT p5pRT closed this as completed May 13, 2016
@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant