Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] teach makedef.pl an alternate macro for PERL_COPY_ON_WRITE #15207

Closed
p5pRT opened this issue Feb 29, 2016 · 7 comments
Closed

[PATCH] teach makedef.pl an alternate macro for PERL_COPY_ON_WRITE #15207

p5pRT opened this issue Feb 29, 2016 · 7 comments
Labels
distro-mswin32 type-core

Comments

@p5pRT
Copy link

p5pRT commented Feb 29, 2016

Migrated from rt.perl.org#127636 (status was 'resolved')

Searchable as RT127636$
@p5pRT
Copy link
Author

p5pRT commented Feb 29, 2016

From @bulk88

Created by @bulk88

See attached patch. There is no 2nd patch.

Perl Info 

Flags:
          category=core
          severity=low

Site configuration information for perl 5.23.5:

Configured by Owner at Sun Oct 25 19:14:27 2015.

Summary of my perl5 (revision 5 version 23 subversion 5) configuration:
        Derived from: 644207b7a8ff7a2b1661c05a7f9ac2df9a5dad91
        Platform:
          osname=MSWin32, osvers=6.1, archname=MSWin32-x86-multi-thread
          uname=''
          config_args='undef'
          hint=recommended, useposix=true, d_sigaction=undef
          useithreads=define, usemultiplicity=define
          use64bitint=undef, use64bitall=undef, uselongdouble=undef
          usemymalloc=n, bincompat5005=undef
        Compiler:
          cc='cl', ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL 
-DWIN32 -D_CONSOLE -DNO_STRICT -D_CRT_SECURE_NO_DEPRECATE 
-D_CRT_NONSTDC_NO_DEPRECATE  -DPERL_TEXTMODE_SCRIPTS 
-DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS',
          optimize='-O1 -MD -Zi -DNDEBUG -GL',
          cppflags='-DWIN32'
          ccversion='18.00.31101', gccversion='', gccosandvers=''
          intsize=4, longsize=4, ptrsize=4, doublesize=8, 
byteorder=1234, doublekind=3
          d_longlong=undef, longlongsize=8, d_longdbl=define, 
longdblsize=8, longdblkind=0
          ivtype='long', ivsize=4, nvtype='double', nvsize=8, 
Off_t='__int64', lseeksize=8
          alignbytes=8, prototype=define
        Linker and Libraries:
          ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf 
-ltcg         -libpath:"c:\p523\lib\CORE"         -machine:x86 
"/manifestdependency:type='Win32' 
name='Microsoft.Windows.Common-Controls' version='6.0.0.0' 
processorArchitecture='*' publicKeyToken='6595b64144ccf1df' 
language='*'" -subsystem:console,"5.01"'
          libpth=\lib
          libs=oldnames.lib kernel32.lib user32.lib gdi32.lib 
winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib 
oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib 
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
          perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib 
winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib 
oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib 
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
          libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl523.lib
          gnulibc_version=''
        Dynamic Linking:
          dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
          cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug 
-opt:ref,icf -ltcg         -libpath:"c:\p523\lib\CORE"  -machine:x86 
"/manifestdependency:type='Win32' 
name='Microsoft.Windows.Common-Controls' version='6.0.0.0' 
processorArchitecture='*' publicKeyToken='6595b64144ccf1df' 
language='*'" -subsystem:console,"5.01"'

Locally applied patches:
          uncommitted-changes


@INC for perl 5.23.5:
          C:/p523/site/lib
          C:/p523/lib
          .


Environment for perl 5.23.5:
          HOME (unset)
          LANG (unset)
          LANGUAGE (unset)
          LD_LIBRARY_PATH (unset)
          LOGDIR (unset)
          PATH=C:\p523\site\bin;C:\p523\bin;C:\Program Files\ActiveState 
Komodo Edit 
9\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program 
Files\TortoiseGit\bin;C:\Program Files\Microsoft Windows Performance 
Toolkit\;C:\Program Files\Microsoft SQL 
Server\110\Tools\Binn\;C:\Program Files\Microsoft 
SDKs\TypeScript\1.0\;C:\Program Files\TortoiseHg\;
          PERL_BADLANG (unset)
          SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Feb 29, 2016

From @bulk88

0001-teach-makedef.pl-an-alternate-macro-for-PERL_COPY_ON.patch 
From 3d2ca11494682b8eeb4541696ace0f53624cf42c Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Sun, 28 Feb 2016 22:44:18 -0500
Subject: [PATCH 1/2] teach makedef.pl an alternate macro for
 PERL_COPY_ON_WRITE

otherwise a -DPERL_NO_COW perl win32 build fails during linking perl523.dll
with missing Perl_sv_setsv_cow
---
 makedef.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/makedef.pl b/makedef.pl
index 90c9368..fd3bf62 100644
--- a/makedef.pl
+++ b/makedef.pl
@@ -285,7 +285,7 @@ else {
 			 );
 }
 
-unless ($define{'PERL_COPY_ON_WRITE'}) {
+if (!$define{'PERL_COPY_ON_WRITE'} || $define{'PERL_NO_COW'}) {
     ++$skip{Perl_sv_setsv_cow};
 }
 
-- 
1.9.5.msysgit.1

@p5pRT
Copy link
Author

p5pRT commented Mar 1, 2016

From @tonycoz

On Mon Feb 29 10​:43​:57 2016, bulk88 wrote​:

See attached patch. There is no 2nd patch.

Thanks, applied as 00d484c.

Tony

@p5pRT
Copy link
Author

p5pRT commented Mar 1, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Mar 1, 2016

@tonycoz - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.
 
With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

@p5pRT p5pRT closed this as completed May 13, 2016
@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-mswin32 type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT