Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.23.7-269-g7950309 breaks PEVANS/Scalar-List-Utils-1.43.tar.gz #15196

Closed
p5pRT opened this issue Feb 23, 2016 · 8 comments
Closed

Comments

@p5pRT
Copy link

p5pRT commented Feb 23, 2016

Migrated from rt.perl.org#127603 (status was 'resolved')

Searchable as RT127603$

@p5pRT
Copy link
Author

p5pRT commented Feb 23, 2016

From @andk

bisect


commit 7950309
Author​: David Mitchell <davem@​iabyn.com>
Date​: Wed Dec 30 15​:20​:41 2015 +0000

  dMULTICALL​: remove unused vars

diagnostics


http​://www.cpantesters.org/cpan/report/9f23c4a6-d8c1-11e5-b5fd-c3b7fcd2507e

perl -V


Summary of my perl5 (revision 5 version 23 subversion 8) configuration​:
 
  Platform​:
  osname=linux, osvers=3.2.0-4-amd64, archname=x86_64-linux
  uname='linux eserte 3.2.0-4-amd64 #1 smp debian 3.2.73-2+deb7u2 x86_64 gnulinux '
  config_args='-ds -e -Dprefix=/opt/perl-5.23.8 -Dusedevel -Dusemallocwrap=no -Dcf_email=srezic@​cpan.org'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
  optimize='-O2',
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.7.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.7/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.13.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES PERLIO_LAYERS PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LOCALE_TIME
  USE_PERLIO USE_PERL_ATOF
  Built under linux
  Compiled at Feb 21 2016 07​:00​:19
  %ENV​:
  PERL="/bbbike/perl-5.23.8/bin/perl5.23.8"
  PERL5LIB="/home/cpansand/.cpan/build/2016022115/Set-Product-XS-0.03-9t_VzP/blib/arch​:/home/cpansand/.cpan/build/2016022115/Set-Product-XS-0.03-9t_VzP/blib/lib​:/home/cpansand/.cpan/build/2016022115/Scalar-Util-LooksLikeNumber-1.39.2-qrNb1z/blib/arch​:/home/cpansand/.cpan/build/2016022115/Scalar-Util-LooksLikeNumber-1.39.2-qrNb1z/blib/lib​:/home/cpansand/.cpan/build/2016022115/List-BinarySearch-XS-0.09-dhos6Z/blib/arch​:/home/cpansand/.cpan/build/2016022115/List-BinarySearch-XS-0.09-dhos6Z/blib/lib​:/home/cpansand/.cpan/build/2016022115/List-MoreUtils-0.413-k8KRCG/blib/arch​:/home/cpansand/.cpan/build/2016022115/List-MoreUtils-0.413-k8KRCG/blib/lib​:/home/cpansand/.cpan/build/2016022115/Math-Prime-Util-0.57-hH9Kx4/blib/arch​:/home/cpansand/.cpan/build/2016022115/Math-Prime-Util-0.57-hH9Kx4/blib/lib​:/home/cpansand/.cpan/build/2016022115/Math-Prime-Util-GMP-0.35-7c9zUr/blib/arch​:/home/cpansand/.cpan/build/2016022115/Math-Prime-Util-GMP-0.35-7c9zUr/blib/lib​:/home/cpansand/.cpan/build/2016022115/Bytes-Random-Secure-0.29-OHJuae/blib/arch​:/home/cpansand/.cpan/build/2016022115/Bytes-Random-Secure-0.29-OHJuae/blib/lib​:/home/cpansand/.cpan/build/2016022115/Math-Random-ISAAC-1.004-xOBYzx/blib/arch​:/home/cpansand/.cpan/build/2016022115/Math-Random-ISAAC-1.004-xOBYzx/blib/lib​:/home/cpansand/.cpan/build/2016022115/Crypt-Random-Seed-0.03-65BElR/blib/arch​:/home/cpansand/.cpan/build/2016022115/Crypt-Random-Seed-0.03-65BElR/blib/lib​:/home/cpansand/.cpan/build/2016022115/Crypt-Random-TESHA2-0.01-nw5him/blib/arch​:/home/cpansand/.cpan/build/2016022115/Crypt-Random-TESHA2-0.01-nw5him/blib/lib​:/home/cpansand/.cpan/build/2016022115/Algorithm-FastPermute-0.999-a3HBnz/blib/arch​:/home/cpansand/.cpan/build/2016022115/Algorithm-FastPermute-0.999-a3HBnz/blib/lib​:/home/cpansand/.cpan/build/2016022115/Convert-Binary-C-0.78-cJU8nr/blib/arch​:/home/cpansand/.cpan/build/2016022115/Convert-Binary-C-0.78-cJU8nr/blib/lib"
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="27319"
  PERL5_CPAN_IS_RUNNING="27319"
  PERL5_CPAN_IS_RUNNING_IN_RECURSION="27220,27319"
  PERLDOC="-MPod​::Perldoc​::ToTextOverstrike"
  PERL_BATCH="yes"
  PERL_CANARY_STABILITY_NOPROMPT="1"
  PERL_CPAN_REPORTER_CONFIG="/var/tmp/cpansmoker-1023/2016022115/cpanreporter_002_config.ini"
  PERL_EXTUTILS_AUTOINSTALL="--defaultdeps"
  @​INC​:
  /home/cpansand/.cpan/build/2016022115/Set-Product-XS-0.03-9t_VzP/blib/arch
  /home/cpansand/.cpan/build/2016022115/Set-Product-XS-0.03-9t_VzP/blib/lib
  /home/cpansand/.cpan/build/2016022115/Scalar-Util-LooksLikeNumber-1.39.2-qrNb1z/blib/arch
  /home/cpansand/.cpan/build/2016022115/Scalar-Util-LooksLikeNumber-1.39.2-qrNb1z/blib/lib
  /home/cpansand/.cpan/build/2016022115/List-BinarySearch-XS-0.09-dhos6Z/blib/arch
  /home/cpansand/.cpan/build/2016022115/List-BinarySearch-XS-0.09-dhos6Z/blib/lib
  /home/cpansand/.cpan/build/2016022115/List-MoreUtils-0.413-k8KRCG/blib/arch
  /home/cpansand/.cpan/build/2016022115/List-MoreUtils-0.413-k8KRCG/blib/lib
  /home/cpansand/.cpan/build/2016022115/Math-Prime-Util-0.57-hH9Kx4/blib/arch
  /home/cpansand/.cpan/build/2016022115/Math-Prime-Util-0.57-hH9Kx4/blib/lib
  /home/cpansand/.cpan/build/2016022115/Math-Prime-Util-GMP-0.35-7c9zUr/blib/arch
  /home/cpansand/.cpan/build/2016022115/Math-Prime-Util-GMP-0.35-7c9zUr/blib/lib
  /home/cpansand/.cpan/build/2016022115/Bytes-Random-Secure-0.29-OHJuae/blib/arch
  /home/cpansand/.cpan/build/2016022115/Bytes-Random-Secure-0.29-OHJuae/blib/lib
  /home/cpansand/.cpan/build/2016022115/Math-Random-ISAAC-1.004-xOBYzx/blib/arch
  /home/cpansand/.cpan/build/2016022115/Math-Random-ISAAC-1.004-xOBYzx/blib/lib
  /home/cpansand/.cpan/build/2016022115/Crypt-Random-Seed-0.03-65BElR/blib/arch
  /home/cpansand/.cpan/build/2016022115/Crypt-Random-Seed-0.03-65BElR/blib/lib
  /home/cpansand/.cpan/build/2016022115/Crypt-Random-TESHA2-0.01-nw5him/blib/arch
  /home/cpansand/.cpan/build/2016022115/Crypt-Random-TESHA2-0.01-nw5him/blib/lib
  /home/cpansand/.cpan/build/2016022115/Algorithm-FastPermute-0.999-a3HBnz/blib/arch
  /home/cpansand/.cpan/build/2016022115/Algorithm-FastPermute-0.999-a3HBnz/blib/lib
  /home/cpansand/.cpan/build/2016022115/Convert-Binary-C-0.78-cJU8nr/blib/arch
  /home/cpansand/.cpan/build/2016022115/Convert-Binary-C-0.78-cJU8nr/blib/lib
  /opt/perl-5.23.8/lib/site_perl/5.23.8/x86_64-linux
  /opt/perl-5.23.8/lib/site_perl/5.23.8
  /opt/perl-5.23.8/lib/5.23.8/x86_64-linux
  /opt/perl-5.23.8/lib/5.23.8
  .
--
andreas

@p5pRT
Copy link
Author

p5pRT commented Feb 23, 2016

From @ilmari

(Andreas J. Koenig) (via RT) <perlbug-followup@​perl.org> writes​:

bisect
------
commit 7950309
Author​: David Mitchell <davem@​iabyn.com>
Date​: Wed Dec 30 15​:20​:41 2015 +0000

dMULTICALL&#8203;: remove unused vars

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/9f23c4a6-d8c1-11e5-b5fd-c3b7fcd2507e

The errors are all on the form​:

  ListUtil.xs​: In function 'XS_List__Util_reduce'​:
  ListUtil.xs​:386​:9​: error​: 'newsp' undeclared (first use in this function)

Ironically, this is caused by the following upstream commit (not in
blead yet)​:

commit ff909f8b0096220f4dc32f02110ffa4521758d11
Author​: Paul "LeoNerd" Evans <leonerd@​leonerd.org.uk>
Date​: 2015-11-18 15​:04​:23 +0000

  List​::Util​: silence some compiler warnings
 
  From​: David Mitchell <davem@​iabyn.com>
  Date​: Mon, 15 Dec 2014 17​:19​:06 +0000
  Subject​: [PATCH] List​::Util​: silence some compiler warnings
 
  * the dMULTICALL stuff defines and sets a variable newsp which
  isn't subsequently used
  […]

The PERL_UNUSED_VAR(newsp) statements this introduced need to be made
conditional..

--
- Twitter seems more influential [than blogs] in the 'gets reported in
  the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
  to a mainstream media article. - Calle Dybedahl

@p5pRT
Copy link
Author

p5pRT commented Feb 23, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Feb 23, 2016

From @iabyn

On Tue, Feb 23, 2016 at 08​:46​:27AM +0000, Dagfinn Ilmari Mannsåker wrote​:

(Andreas J. Koenig) (via RT) <perlbug-followup@​perl.org> writes​:

bisect
------
commit 7950309
Author​: David Mitchell <davem@​iabyn.com>
Date​: Wed Dec 30 15​:20​:41 2015 +0000

dMULTICALL&#8203;: remove unused vars

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/9f23c4a6-d8c1-11e5-b5fd-c3b7fcd2507e

The errors are all on the form​:

ListUtil\.xs&#8203;: In function 'XS\_List\_\_Util\_reduce'&#8203;:
ListUtil\.xs&#8203;:386&#8203;:9&#8203;: error&#8203;: 'newsp' undeclared \(first use in this function\)

Ironically, this is caused by the following upstream commit (not in
blead yet)​:

commit ff909f8b0096220f4dc32f02110ffa4521758d11
Author​: Paul "LeoNerd" Evans <leonerd@​leonerd.org.uk>
Date​: 2015-11-18 15​:04​:23 +0000

List&#8203;::Util&#8203;: silence some compiler warnings

From&#8203;: David Mitchell \<davem@&#8203;iabyn\.com>
Date&#8203;: Mon\, 15 Dec 2014 17&#8203;:19&#8203;:06 \+0000
Subject&#8203;: \[PATCH\] List&#8203;::Util&#8203;: silence some compiler warnings

\* the dMULTICALL stuff defines and sets a variable newsp which
  isn't subsequently used
\[…\]

The PERL_UNUSED_VAR(newsp) statements this introduced need to be made
conditional..

I've raised it as

https://rt.cpan.org/Ticket/Display.html?id=112312

--
Modern art​:
  "That's easy, I could have done that!"
  "Ah, but you didn't!"

@p5pRT
Copy link
Author

p5pRT commented Mar 18, 2016

From @rjbs

The CPAN release has fixed this problem, so there is no blocker here.

We'll look at whether we want to upgrade from 1.42_02 (our customized version) to 1.43 (which should have all/most of the patches applied?). 1.44 seems off the table. I'd rather ship 1.42_02 than upgrade to something with experimental stuff in it, for now, though.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Mar 18, 2016

@rjbs - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Mar 18, 2016
@p5pRT
Copy link
Author

p5pRT commented Mar 21, 2016

From @iabyn

On Fri, Mar 18, 2016 at 08​:31​:03AM -0700, Ricardo SIGNES via RT wrote​:

The CPAN release has fixed this problem, so there is no blocker here.

We'll look at whether we want to upgrade from 1.42_02 (our customized version) to 1.43 (which should have all/most of the patches applied?). 1.44 seems off the table. I'd rather ship 1.42_02 than upgrade to something with experimental stuff in it, for now, though.

1.43 won't build on blead.

--
This email is confidential, and now that you have read it you are legally
obliged to shoot yourself. Or shoot a lawyer, if you prefer. If you have
received this email in error, place it in its original wrapping and return
for a full refund. By opening this email, you accept that Elvis lives.

@p5pRT
Copy link
Author

p5pRT commented Mar 23, 2016

From @rjbs

* Dave Mitchell <davem@​iabyn.com> [2016-03-21T08​:41​:41]

On Fri, Mar 18, 2016 at 08​:31​:03AM -0700, Ricardo SIGNES via RT wrote​:

We'll look at whether we want to upgrade from 1.42_02 (our customized
version) to 1.43 (which should have all/most of the patches applied?).
1.44 seems off the table. I'd rather ship 1.42_02 than upgrade to
something with experimental stuff in it, for now, though.

1.43 won't build on blead.

Well, 1.42_02 it is!

--
rjbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant