Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] Remove an unused variable #15189

Closed
p5pRT opened this issue Feb 18, 2016 · 5 comments
Closed

[PATCH] Remove an unused variable #15189

p5pRT opened this issue Feb 18, 2016 · 5 comments
Labels
distro-freebsd type-library

Comments

@p5pRT
Copy link

p5pRT commented Feb 18, 2016

Migrated from rt.perl.org#127561 (status was 'resolved')

Searchable as RT127561$
@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2016

From @tomhukins

Created by @tomhukins

This patch removes an unused variable from a test script.

Perl Info 

Flags:
    category=library
    severity=low
    Type=Patch
    PatchStatus=HasPatch
    module=Time::HiRes

Site configuration information for perl 5.23.8:

Configured by tom at Thu Feb 18 11:52:31 UTC 2016.

Summary of my perl5 (revision 5 version 23 subversion 8) configuration:
  Commit id: 99a459417f0daaf80e278a7ed2d66ba6c741c4a4
  Platform:
    osname=freebsd, osvers=9.3-release-p13, archname=amd64-freebsd
    uname='freebsd canet.scrubhole.org 9.3-release-p13 freebsd 9.3-release-p13 #1 r282738: mon may 11 01:25:08 utc 2015 root@tyne.exonetric.net:usrobjusrsrcsysgeneric amd64 '
    config_args='-des -Dusedevel -Uoptimize'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
    optimize=' ',
    cppflags='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.2.1 20070831 patched [FreeBSD]', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags ='-Wl,-E  -fstack-protector -L/usr/local/lib'
    libpth=/usr/lib /usr/local/lib /usr/include/gcc/4.2 /usr/lib
    libs=-lpthread -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lm -lcrypt -lutil -lc
    libc=, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' '
    cccdlflags='-DPIC -fPIC', lddlflags='-shared  -L/usr/local/lib -fstack-protector'



@INC for perl 5.23.8:
    lib
    /usr/local/lib/perl5/site_perl/5.23.8/amd64-freebsd
    /usr/local/lib/perl5/site_perl/5.23.8
    /usr/local/lib/perl5/5.23.8/amd64-freebsd
    /usr/local/lib/perl5/5.23.8
    /usr/local/lib/perl5/site_perl
    .


Environment for perl 5.23.8:
    HOME=/home/tom
    LANG=en_GB.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/home/tom/bin
    PERL_BADLANG (unset)
    SHELL=/usr/local/bin/zsh

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2016

From @tomhukins

0001-Remove-an-unused-variable.patch 
From 99a459417f0daaf80e278a7ed2d66ba6c741c4a4 Mon Sep 17 00:00:00 2001
From: Tom Hukins <tom@eborcom.com>
Date: Wed, 17 Feb 2016 15:04:10 +0000
Subject: [PATCH] Remove an unused variable

Other Time::HiRes test scripts define and use $limit to cope with timing
on heavily loaded systems.

This test script defined the variable but never used it.
---
 dist/Time-HiRes/t/stat.t | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dist/Time-HiRes/t/stat.t b/dist/Time-HiRes/t/stat.t
index eca9da1..68a6fb6 100644
--- a/dist/Time-HiRes/t/stat.t
+++ b/dist/Time-HiRes/t/stat.t
@@ -16,8 +16,6 @@ BEGIN {
 use Test::More 0.82 tests => 43;
 use t::Watchdog;
 
-my $limit = 0.25; # 25% is acceptable slosh for testing timers
-
 my @atime;
 my @mtime;
 for (1..5) {
-- 
2.7.0

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2016

From @jkeenan

On Thu Feb 18 04​:04​:31 2016, tomhukins wrote​:

This is a bug report for perl from tom@​eborcom.com,
generated with the help of perlbug 1.40 running under perl 5.23.8.

-----------------------------------------------------------------
[Please describe your issue here]

This patch removes an unused variable from a test script.

Thanks, applied to blead in commit 52ffb1b

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT p5pRT closed this as completed Feb 18, 2016
@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2016

@jkeenan - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-freebsd type-library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT