IO::Socket::INET fails because of IPv6 #15175
Comments
From shawnw@speakeasy.orgCreated by shawnw.mobile@gmail.comI ran into problems with a script that uses IO::Socket::INET to connect Patch: gethostbyname() can return IPv6 addresses, which obviously don't play Inline Patchdiff --git a/dist/IO/lib/IO/Socket/INET.pm b/dist/IO/lib/IO/Socket/INET.pm
index 7a16947..ac01b7a 100644
--- a/dist/IO/lib/IO/Socket/INET.pm
+++ b/dist/IO/lib/IO/Socket/INET.pm
@@ -123,10 +123,16 @@ sub _error {
}
sub _get_addr {
- my($sock,$addr_str, $multi) = @_;
+ my($sock,$addr_str, $type, $proto, $multi) = @_;
my @addr;
if ($multi && $addr_str !~ /^\d+(?:\.\d+){3}$/) {
- (undef, undef, undef, undef, @addr) = gethostbyname($addr_str);
+ my $err;
+ ($err, @addr) = getaddrinfo($addr_str, "",
+ {family => AF_INET,
+ socktype => $type,
+ protocol => $proto});
+ return () if $err != 0;
+ @addr = map { $_->{"addr"} } @addr;
} else {
my $h = inet_aton($addr_str);
push(@addr, $h) if defined $h;
@@ -170,7 +176,7 @@ sub configure {
my @raddr = ();
if(defined $raddr) {
- @raddr = $sock->_get_addr($raddr, $arg->{MultiHomed});
+ @raddr = $sock->_get_addr($raddr, $type, $proto, $arg->{MultiHomed});
return _error($sock, $EINVAL, "Bad hostname '",$arg->{PeerAddr},"'")
unless @raddr;
}
--
2.7.0Perl Info |
From @jkeenanOn Thu Feb 11 12:11:21 2016, shawnw@speakeasy.org wrote:
We should see whether this is the same bug as was reported in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=75740. |
|
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Thu Feb 11 12:11:21 2016, shawnw@speakeasy.org wrote:
The patch was submitted inline and did not apply cleanly. I manually applied it to a branch and tidied up the formatting somewhat. See attachment. 'make test' PASSes. I'm not an expert in this area, so I'll defer to others as to whether the patch should be applied or not. Thank you very much. -- |
From @jkeenan127519-0001-Use-getaddrinfo-and-always-force-IPv4-resolution.patchFrom a5579ab1523fc46236c3dc350cf092d5766e7d82 Mon Sep 17 00:00:00 2001
From: Shawn Wagner <shawnw.mobile@gmail.com>
Date: Thu, 11 Feb 2016 21:22:08 -0500
Subject: [PATCH] Use getaddrinfo and always force IPv4 resolution.
Increment $VERSION. Add Shawn Wagner to AUTHORS.
For RT # 127519
---
AUTHORS | 1 +
dist/IO/lib/IO/Socket/INET.pm | 33 +++++++++++++++++++++++----------
2 files changed, 24 insertions(+), 10 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 3cc2ef1..bbe13c3 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -1098,6 +1098,7 @@ Sérgio Durigan Júnior <sergiodj@linux.vnet.ibm.com>
Sergey Alekseev <varnie29a@mail.ru>
Shawn <svicalifornia@gmail.com>
Shawn M Moore <sartak@gmail.com>
+Shawn Wagner <shawnw.mobile@gmail.com>
Sherm Pendley <sherm@dot-app.org>
Shigeya Suzuki <shigeya@wide.ad.jp>
Shimpei Yamashita <shimpei@socrates.patnet.caltech.edu>
diff --git a/dist/IO/lib/IO/Socket/INET.pm b/dist/IO/lib/IO/Socket/INET.pm
index 7a16947..eceb08d 100644
--- a/dist/IO/lib/IO/Socket/INET.pm
+++ b/dist/IO/lib/IO/Socket/INET.pm
@@ -15,7 +15,7 @@ use Exporter;
use Errno;
@ISA = qw(IO::Socket);
-$VERSION = "1.35";
+$VERSION = "1.36";
my $EINVAL = exists(&Errno::EINVAL) ? Errno::EINVAL() : 1;
@@ -123,15 +123,28 @@ sub _error {
}
sub _get_addr {
- my($sock,$addr_str, $multi) = @_;
+ my($sock,$addr_str, $type, $proto, $multi) = @_;
+
my @addr;
if ($multi && $addr_str !~ /^\d+(?:\.\d+){3}$/) {
- (undef, undef, undef, undef, @addr) = gethostbyname($addr_str);
- } else {
- my $h = inet_aton($addr_str);
- push(@addr, $h) if defined $h;
+ my $err;
+ ($err, @addr) = getaddrinfo(
+ $addr_str,
+ "",
+ {
+ family => AF_INET,
+ socktype => $type,
+ protocol => $proto,
+ }
+ );
+ return () if $err != 0;
+ @addr = map { $_->{"addr"} } @addr;
+ }
+ else {
+ my $h = inet_aton($addr_str);
+ push(@addr, $h) if defined $h;
}
- @addr;
+ return @addr;
}
sub configure {
@@ -170,9 +183,9 @@ sub configure {
my @raddr = ();
if(defined $raddr) {
- @raddr = $sock->_get_addr($raddr, $arg->{MultiHomed});
- return _error($sock, $EINVAL, "Bad hostname '",$arg->{PeerAddr},"'")
- unless @raddr;
+ @raddr = $sock->_get_addr($raddr, $type, $proto, $arg->{MultiHomed});
+ return _error($sock, $EINVAL, "Bad hostname '",$arg->{PeerAddr},"'")
+ unless @raddr;
}
while(1) {
--
1.9.1
|
From @leonerdOn Thu, 11 Feb 2016 18:33:30 -0800
This seems a pointless thing to do - on any machine that has
Core already has IO::Socket::IP, which does transparent IPv{n} ...
Thoughts above. Additionally, this bug sounds like a more fundamental platform problem $ socket_getaddrinfo cel --stream socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP) + '[2001:8b0:3f7::2]:0' Yet, gethostbyname() still only gives me 'v4 addresses: $ perl -MData::Dump=pp -E 'say pp( gethostbyname "cel" )' If I specifically ask for something that has only v6 addresses: $ socket_getaddrinfo cel-v6 --stream socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP) + '[2001:8b0:3f7::2]:0' then gethostbyname() returns me nothing: $ perl -MData::Dump=pp -E 'say pp( gethostbyname "cel-v6" )' As far as I read it, IO::Socket::INET is perfectly fine to rely on the I recommend reverting it. -- leonerd@leonerd.org.uk |
From @jkeenanOn 02/12/2016 08:05 AM, Paul "LeoNerd" Evans wrote:
I didn't apply the patch; I merely prepared it in a more usable form. Anyone else want to sound in? Thank you very much. |
From shawnw@speakeasy.orgOn Fri, 12 Feb 2016 05:06:07 -0800
I didn't know about IO::Socket::IP. Still, what OSes don't support Suppose you could also check to make sure the h_addrtype field to see
It's a fundamental design problem dating back to the early days before
I get ( What gethostbyname() returns depends on how your resolver is ( I don't want to have to do that just so an old program works right. I'd -- |
From @leonerdOn Fri, 12 Feb 2016 13:01:42 -0800
That's probably a better approach, then. Given as the gethostby*() Line 129: (undef, undef, undef, undef, @addr) = gethostbyname($addr_str); change that to (undef, undef, my $addrtype, undef, @addr) = gethostbyname($addr_str); Then at least it will not get confused by non-AF_INET return values. -- leonerd@leonerd.org.uk |
Migrated from rt.perl.org#127519 (status was 'open')
Searchable as RT127519$
The text was updated successfully, but these errors were encountered: