New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] minor comment improvements in hv.h and scope.h #15172
Comments
From @bulk88Created by @bulk88See attached patch. Perl Info
|
From @bulk880001-minor-comment-improvements-in-hv.h-and-scope.h.patchFrom b5d9e107a4d18fce7711fb22697afec0fc252a47 Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Thu, 11 Feb 2016 05:48:58 -0500
Subject: [PATCH] minor comment improvements in hv.h and scope.h
-perl doesn't use malloc, it uses Newx (per interp memory)
-say what the return type is of SSNEW
---
hv.h | 3 ++-
scope.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hv.h b/hv.h
index d7cc42f..b97b224 100644
--- a/hv.h
+++ b/hv.h
@@ -403,7 +403,8 @@ C<SV*>.
#define HVhek_UTF8 0x01 /* Key is utf8 encoded. */
#define HVhek_WASUTF8 0x02 /* Key is bytes here, but was supplied as utf8. */
#define HVhek_UNSHARED 0x08 /* This key isn't a shared hash key. */
-#define HVhek_FREEKEY 0x100 /* Internal flag to say key is malloc()ed. */
+/* the following flags are options for functions, they are not stored in heks */
+#define HVhek_FREEKEY 0x100 /* Internal flag to say key is Newx()ed. */
#define HVhek_PLACEHOLD 0x200 /* Internal flag to create placeholder.
* (may change, but Storable is a core module) */
#define HVhek_KEYCANONICAL 0x400 /* Internal flag - key is in canonical form.
diff --git a/scope.h b/scope.h
index 1de27ab..9a504f1 100644
--- a/scope.h
+++ b/scope.h
@@ -310,7 +310,7 @@ scope has the given name. C<name> must be a C<NUL>-terminated literal string.
#define SAVECOPLINE(c) SAVEI32(CopLINE(c))
/* SSNEW() temporarily allocates a specified number of bytes of data on the
- * savestack. It returns an integer index into the savestack, because a
+ * savestack. It returns an I32 index into the savestack, because a
* pointer would get broken if the savestack is moved on reallocation.
* SSNEWa() works like SSNEW(), but also aligns the data to the specified
* number of bytes. MEM_ALIGNBYTES is perhaps the most useful. The
--
1.9.5.msysgit.1
|
The RT System itself - Status changed from 'new' to 'open' |
@tonycoz - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for submitting this report. You have helped make Perl better. Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0 |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#127514 (status was 'resolved')
Searchable as RT127514$
The text was updated successfully, but these errors were encountered: