[PATCH] Fix module paths in INSTALL #15123

p5pRT · 2016-01-10T08:33:28Z

Migrated from rt.perl.org#127229 (status was 'resolved')

Searchable as RT127229$

p5pRT · 2016-01-10T08:33:28Z

From @tomhukins

Created by @tomhukins

The INSTALL document refers to some files in their old location. The
attached patch refers to the files in their current repository location.

Perl Info


Flags:
    category=docs
    severity=low
    Type=Patch
    PatchStatus=HasPatch

Site configuration information for perl 5.20.3:

Configured by perl at Sat Sep 12 19:09:14 UTC 2015.

Summary of my perl5 (revision 5 version 20 subversion 3) configuration:
   
  Platform:
    osname=freebsd, osvers=9.3-release-p26, archname=amd64-freebsd-thread-multi
    uname='freebsd 93amd64-default-job-12 9.3-release-p26 freebsd 9.3-release-p26 amd64 '
    config_args='-sde -Dprefix=/usr/local -Dlibperl=libperl.so.5.20.3 -Darchlib=/usr/local/lib/perl5/5.20/mach -Dprivlib=/usr/local/lib/perl5/5.20 -Dman3dir=/usr/local/lib/perl5/5.20/perl/man/man3 -Dman1dir=/usr/local/lib/perl5/5.20/perl/man/man1 -Dsitearch=/usr/local/lib/perl5/site_perl/mach/5.20 -Dsitelib=/usr/local/lib/perl5/site_perl -Dscriptdir=/usr/local/bin -Dsiteman3dir=/usr/local/lib/perl5/site_perl/man/man3 -Dsiteman1dir=/usr/local/lib/perl5/site_perl/man/man1 -Ui_malloc -Ui_iconv -Uinstallusrbinperl -Dusenm=n -Dcc=cc -Duseshrplib -Dinc_version_list=none -Dcf_by=perl -Dcf_email=perl@FreeBSD.org -Dcf_time=Sat Sep 12 19:09:14 UTC 2015 -Alddlflags=-L/wrkdirs/usr/ports/lang/perl5.20/work/perl-5.20.3 -L/usr/local/lib/perl5/5.20/mach/CORE -Wl,-rpath=/usr/local/lib/perl5/5.20/mach/CORE -lperl -Dshrpldflags=$(LDDLFLAGS:N-L/wrkdirs/usr/ports/lang/perl5.20/work/perl-5.20.3:N-L/usr/local/lib/perl5/5.20/mach/CORE:N-Wl,-rpath=/usr/local/lib/perl5/5.20/mach/CORE:N-lperl) -Wl,-soname,$(LIBPERL:R) -Dotherlibdirs=/usr/local/lib/perl5/site_perl/5.20:/usr/local/lib/perl5/site_perl/5.20/mach -Doptimize=-O2 -pipe -fstack-protector -fno-strict-aliasing -Ui_gdbm -Dusemultiplicity=y -Duse64bitint -Dusethreads=y -Dusemymalloc=n'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
    optimize='-O2 -pipe -fstack-protector -fno-strict-aliasing',
    cppflags='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.2.1 20070831 patched [FreeBSD]', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags ='-lpthread -Wl,-E  -fstack-protector -L/usr/local/lib'
    libpth=/usr/lib /usr/local/lib /usr/include/gcc/4.2 /usr/lib
    libs=-lpthread -lm -lcrypt -lutil
    perllibs=-lpthread -lm -lcrypt -lutil
    libc=, so=so, useshrplib=true, libperl=libperl.so.5.20.3
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='  -Wl,-R/usr/local/lib/perl5/5.20/mach/CORE'
    cccdlflags='-DPIC -fPIC', lddlflags='-shared  -L/wrkdirs/usr/ports/lang/perl5.20/work/perl-5.20.3 -L/usr/local/lib/perl5/5.20/mach/CORE -Wl,-rpath=/usr/local/lib/perl5/5.20/mach/CORE -lperl -L/usr/local/lib -fstack-protector'



@INC for perl 5.20.3:
    /usr/local/lib/perl5/site_perl/mach/5.20
    /usr/local/lib/perl5/site_perl
    /usr/local/lib/perl5/5.20/mach
    /usr/local/lib/perl5/5.20
    /usr/local/lib/perl5/site_perl/5.20
    /usr/local/lib/perl5/site_perl/5.20/mach
    .


Environment for perl 5.20.3:
    HOME=/home/tom
    LANG=en_GB.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/home/tom/bin
    PERL_BADLANG (unset)
    SHELL=/usr/local/bin/zsh

p5pRT · 2016-01-10T08:33:28Z

From @tomhukins

0001-Fix-file-paths.patch

From 6022194976f6f9d74f8de67c42a9b65be5756681 Mon Sep 17 00:00:00 2001
From: Tom Hukins <tom@eborcom.com>
Date: Thu, 10 Dec 2015 13:30:22 +0000
Subject: [PATCH 1/1] Fix file paths

---
 INSTALL | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/INSTALL b/INSTALL
index 43cdc40..15bce32 100644
--- a/INSTALL
+++ b/INSTALL
@@ -1729,12 +1729,12 @@ bval settings.  Upgrade your DB library or OS.
 
 =item Bad arg length for semctl, is XX, should be ZZZ
 
-If you get this error message from the F<ext/IPC/SysV/t/sem.t> test, your
+If you get this error message from the F<cpan/IPC-SysV/t/sem.t> test, your
 System V IPC may be broken.  The XX typically is 20, and that is what ZZZ
 also should be.  Consider upgrading your OS, or reconfiguring your OS
 to include the System V semaphores.
 
-=item ext/IPC/SysV/t/sem........semget: No space left on device
+=item cpan/IPC-SysV/t/sem........semget: No space left on device
 
 Either your account or the whole system has run out of semaphores.  Or
 both.  Either list the semaphores with "ipcs" and remove the unneeded
@@ -1782,7 +1782,7 @@ NCR Tower 32 (OS 2.01.01) may need -W2,-Sl,2000 and #undef MKDIR.
 
 UTS may need one or more of -K or -g, and #undef LSTAT.
 
-FreeBSD can fail the F<ext/IPC/SysV/t/sem.t> test if SysV IPC has not been
+FreeBSD can fail the F<cpan/IPC-SysV/t/sem.t> test if SysV IPC has not been
 configured in the kernel.  Perl tries to detect this, though, and
 you will get a message telling you what to do.
 
@@ -2073,8 +2073,8 @@ If your system is quite busy and doesn't respond quickly enough,
 these tests might fail.  If possible, try running the tests again
 with the system under a lighter load.  These timing-sensitive
 and load-sensitive tests include F<t/op/alarm.t>,
-F<ext/Time-HiRes/t/HiRes.t>, F<ext/threads-shared/t/waithires.t>,
-F<ext/threads-shared/t/stress.t>, F<lib/Benchmark.t>,
+F<cpan/Time-HiRes/t/HiRes.t>, F<dist/threads-shared/t/waithires.t>,
+F<dist/threads-shared/t/stress.t>, F<lib/Benchmark.t>,
 F<lib/Memoize/t/expmod_t.t>, and F<lib/Memoize/t/speed.t>.
 
 You might also experience some failures in F<t/op/stat.t> if you build
-- 
2.6.1

p5pRT · 2016-01-10T11:52:51Z

From @mauke

On Sun Jan 10 00:33:28 2016, tomhukins wrote:

The INSTALL document refers to some files in their old location. The
attached patch refers to the files in their current repository
location.

The patch is good but it refers to F<cpan/Time-HiRes/t/HiRes.t>, which was split up and removed in commit 90e44bf. What should we do about that?

p5pRT · 2016-01-10T11:52:51Z

The RT System itself - Status changed from 'new' to 'open'

p5pRT · 2016-01-10T16:36:10Z

From @tomhukins

On Sun, Jan 10, 2016 at 03:52:51AM -0800, l.mai@web.de via RT wrote:

The patch is good but it refers to F<cpan/Time-HiRes/t/HiRes.t>, which
was split up and removed in commit 90e44bf. What should we do
about that?

Well spotted!

The original form of this comment was added to INSTALL in 0740bb5 along
with a comment in HiRes.t and a variable $limit.

The variable $limit now exists in the Time::HiRes test suite at
alarm.t, clock.t, itimer.t and usleep.t. It also needlessly exists in
stat.t, which I've submitted a patch for upstream:
https://github.com/rjbs/Time-HiRes/pull/5

I have updated my patch and attached it to this message.

Tom

p5pRT · 2016-01-10T16:36:10Z

From @tomhukins

0001-Fix-file-paths.patch

From c3bc701d794bcbc5932d6bbf3d5afce6622a439d Mon Sep 17 00:00:00 2001
From: Tom Hukins <tom@eborcom.com>
Date: Sun, 10 Jan 2016 16:28:39 +0000
Subject: [PATCH] Fix file paths

---
 INSTALL | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/INSTALL b/INSTALL
index 953e96a..6293636 100644
--- a/INSTALL
+++ b/INSTALL
@@ -1729,12 +1729,12 @@ bval settings.  Upgrade your DB library or OS.
 
 =item Bad arg length for semctl, is XX, should be ZZZ
 
-If you get this error message from the F<ext/IPC/SysV/t/sem.t> test, your
+If you get this error message from the F<cpan/IPC-SysV/t/sem.t> test, your
 System V IPC may be broken.  The XX typically is 20, and that is what ZZZ
 also should be.  Consider upgrading your OS, or reconfiguring your OS
 to include the System V semaphores.
 
-=item ext/IPC/SysV/t/sem........semget: No space left on device
+=item cpan/IPC-SysV/t/sem........semget: No space left on device
 
 Either your account or the whole system has run out of semaphores.  Or
 both.  Either list the semaphores with "ipcs" and remove the unneeded
@@ -1782,7 +1782,7 @@ NCR Tower 32 (OS 2.01.01) may need -W2,-Sl,2000 and #undef MKDIR.
 
 UTS may need one or more of -K or -g, and #undef LSTAT.
 
-FreeBSD can fail the F<ext/IPC/SysV/t/sem.t> test if SysV IPC has not been
+FreeBSD can fail the F<cpan/IPC-SysV/t/sem.t> test if SysV IPC has not been
 configured in the kernel.  Perl tries to detect this, though, and
 you will get a message telling you what to do.
 
@@ -2073,8 +2073,10 @@ If your system is quite busy and doesn't respond quickly enough,
 these tests might fail.  If possible, try running the tests again
 with the system under a lighter load.  These timing-sensitive
 and load-sensitive tests include F<t/op/alarm.t>,
-F<ext/Time-HiRes/t/HiRes.t>, F<ext/threads-shared/t/waithires.t>,
-F<ext/threads-shared/t/stress.t>, F<lib/Benchmark.t>,
+F<cpan/Time-HiRes/t/alarm.t>, F<cpan/Time-HiRes/t/clock.t>,
+F<cpan/Time-HiRes/t/itimer.t>, F<cpan/Time-HiRes/t/usleep.t>,
+F<dist/threads-shared/t/waithires.t>,
+F<dist/threads-shared/t/stress.t>, F<lib/Benchmark.t>,
 F<lib/Memoize/t/expmod_t.t>, and F<lib/Memoize/t/speed.t>.
 
 You might also experience some failures in F<t/op/stat.t> if you build
-- 
2.7.0

p5pRT · 2016-01-10T16:46:34Z

From @tomhukins

On Sun, Jan 10, 2016 at 04:35:32PM +0000, Tom Hukins wrote:

I have updated my patch and attached it to this message.

..and as discussed on IRC here's another patch that applies cleanly to
blead as of c935ba5.

Tom

p5pRT · 2016-01-10T16:46:34Z

From @tomhukins

0001-HiRes.t-no-longer-exists.patch

From 5d8be623903df9a692fc88f0cdbfcdadffff696a Mon Sep 17 00:00:00 2001
From: Tom Hukins <tom@eborcom.com>
Date: Sun, 10 Jan 2016 16:28:39 +0000
Subject: [PATCH] HiRes.t no longer exists

Specify which Time::HiRes test scripts might fail under system load.
---
 INSTALL | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/INSTALL b/INSTALL
index 2400a33..6293636 100644
--- a/INSTALL
+++ b/INSTALL
@@ -2073,7 +2073,9 @@ If your system is quite busy and doesn't respond quickly enough,
 these tests might fail.  If possible, try running the tests again
 with the system under a lighter load.  These timing-sensitive
 and load-sensitive tests include F<t/op/alarm.t>,
-F<cpan/Time-HiRes/t/HiRes.t>, F<dist/threads-shared/t/waithires.t>,
+F<cpan/Time-HiRes/t/alarm.t>, F<cpan/Time-HiRes/t/clock.t>,
+F<cpan/Time-HiRes/t/itimer.t>, F<cpan/Time-HiRes/t/usleep.t>,
+F<dist/threads-shared/t/waithires.t>,
 F<dist/threads-shared/t/stress.t>, F<lib/Benchmark.t>,
 F<lib/Memoize/t/expmod_t.t>, and F<lib/Memoize/t/speed.t>.
 
-- 
2.7.0

p5pRT · 2016-01-10T17:07:44Z

From @mauke

On Sun Jan 10 08:46:34 2016, tomhukins wrote:

On Sun, Jan 10, 2016 at 04:35:32PM +0000, Tom Hukins wrote:

I have updated my patch and attached it to this message.

..and as discussed on IRC here's another patch that applies cleanly to
blead as of c935ba5.

Thanks, applied as c935ba5 and 1543af1, along with cb0ee57 for a few non-INSTALL files.

p5pRT · 2016-01-10T17:07:45Z

@mauke - Status changed from 'open' to 'pending release'

p5pRT · 2016-05-13T04:04:25Z

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.

With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

p5pRT · 2016-05-13T04:04:26Z

@khwilliamson - Status changed from 'pending release' to 'resolved'

p5pRT closed this as completed May 13, 2016

p5pRT added Severity Low distro-freebsd documentation labels Oct 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PATCH] Fix module paths in INSTALL #15123

[PATCH] Fix module paths in INSTALL #15123

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

p5pRT commented May 13, 2016

p5pRT commented May 13, 2016

Navigation Menu

[PATCH] Fix module paths in INSTALL #15123

[PATCH] Fix module paths in INSTALL #15123

Comments

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

From @tomhukins

Created by @tomhukins

p5pRT commented Jan 10, 2016

From @tomhukins

p5pRT commented Jan 10, 2016

From @mauke

p5pRT commented Jan 10, 2016

p5pRT commented Jan 10, 2016

From @tomhukins

p5pRT commented Jan 10, 2016

From @tomhukins

p5pRT commented Jan 10, 2016

From @tomhukins

p5pRT commented Jan 10, 2016

From @tomhukins

p5pRT commented Jan 10, 2016

From @mauke

p5pRT commented Jan 10, 2016

p5pRT commented May 13, 2016

From @khwilliamson

p5pRT commented May 13, 2016