Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] minor doc clarifications #15111

Closed
p5pRT opened this issue Jan 1, 2016 · 10 comments
Closed

[PATCH] minor doc clarifications #15111

p5pRT opened this issue Jan 1, 2016 · 10 comments

Comments

@p5pRT
Copy link

p5pRT commented Jan 1, 2016

Migrated from rt.perl.org#127114 (status was 'resolved')

Searchable as RT127114$

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

From @karenetheridge

Very minor edits I made while working on the podlators patch.

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

From @karenetheridge

Apologies; the two commits are now attached.

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

From @karenetheridge

0001-fix-typo-clarify-instructions-a-bit.patch
From a4d33fb196f31a656091aeeeb0e30710855fefab Mon Sep 17 00:00:00 2001
From: Karen Etheridge <ether@cpan.org>
Date: Sun, 20 Dec 2015 21:22:08 -0800
Subject: [PATCH 1/2] fix typo, clarify instructions a bit


diff --git a/Porting/release_managers_guide.pod b/Porting/release_managers_guide.pod
index 6155b2d..0c0f5b8 100644
--- a/Porting/release_managers_guide.pod
+++ b/Porting/release_managers_guide.pod
@@ -262,7 +262,7 @@ C<git checkout .gitignore> in the F<cpan/Distro> directory.
 =item *
 
 Remove files we do not need. That is, remove any files that match the
-entries in C<@IGNORABLE> in F<Porting/Maintainer.pl>, and anything that
+entries in C<@IGNORABLE> in F<Porting/Maintainers.pl>, and anything that
 matches the C<EXCLUDED> section of the distro's entry in the C<%Modules>
 hash.
 
@@ -305,7 +305,7 @@ Run the tests for the package.
 
 =item *
 
-Run the tests in F<t/porting>.
+Run the tests in F<t/porting> (C<make test_porting>).
 
 =item *
 
-- 
2.6.2

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

From @karenetheridge

0002-tell-the-author-where-the-problems-db-is-located.patch
From 64aebfefe9f4ca9c79f2e34a01d933f75dd06821 Mon Sep 17 00:00:00 2001
From: Karen Etheridge <ether@cpan.org>
Date: Fri, 1 Jan 2016 10:46:31 -0800
Subject: [PATCH 2/2] tell the author where the problems db is located


diff --git a/t/porting/podcheck.t b/t/porting/podcheck.t
index 3cd01c3..2dc274c 100644
--- a/t/porting/podcheck.t
+++ b/t/porting/podcheck.t
@@ -1918,7 +1918,7 @@ foreach my $filename (@files) {
 }
 
 if (! $regen
-    && ! ok (keys %known_problems == 0, "The known problems database includes no references to non-existent files"))
+    && ! ok (keys %known_problems == 0, "The known problems database ($data_dir/known_pod_issues.dat) includes no references to non-existent files"))
 {
     note("The following files were not found: "
          . join ", ", keys %known_problems);
-- 
2.6.2

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

From [Unknown Contact. See original ticket]

Apologies; the two commits are now attached.

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

@khwilliamson - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

From @khwilliamson

Thanks,

applied as 812ce6d and b0248db
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Jan 1, 2016

@khwilliamson - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.
 
With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant