Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive comparison use uc + lc not fc #4811

Closed
p6rt opened this issue Dec 3, 2015 · 5 comments
Closed

Case insensitive comparison use uc + lc not fc #4811

p6rt opened this issue Dec 3, 2015 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Dec 3, 2015

Migrated from rt.perl.org#126793 (status was 'resolved')

Searchable as RT126793$

@p6rt
Copy link
Author

p6rt commented Dec 3, 2015

From @coke

There are still some instances where we use "lc" instead of "fc" to do
a case insensitive comparison, notably in

m​:i​:m/.../

Should review the rakudo sources for any use of nqp​:lc that should be nqp​:fc

Originally referenced as part of RT #​126771, this needs a separate ticket.
--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Mar 11, 2017

From @samcv

On Thu, 03 Dec 2015 09​:50​:58 -0800, coke wrote​:

There are still some instances where we use "lc" instead of "fc" to do
a case insensitive comparison, notably in

m​:i​:m/.../

Should review the rakudo sources for any use of nqp​:lc that should be nqp​:fc

Originally referenced as part of RT #​126771, this needs a separate ticket.

In most places but NFA.nqp this has been done. https://github.com/perl6/nqp/blob/master/src/QRegex/NFA.nqp#L290-L294

Also only MoarVM has the nqp​::eqatic op for eqat but case insensitive. Recently I have exposed the nqp​::eqatic op, before it was called directly and not as `nqp​::eqatic`.

JVM does have fold case operations though. Maybe someone who knows more on NFA can help out.

@p6rt
Copy link
Author

p6rt commented Mar 11, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jul 16, 2017

From @samcv

This has been fixed and the required tests unfudged. Closing as resolved.

@p6rt
Copy link
Author

p6rt commented Jul 16, 2017

@samcv - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant