Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not quit from perl debugger by 'q' #15064

Closed
p5pRT opened this issue Nov 26, 2015 · 16 comments
Closed

Can not quit from perl debugger by 'q' #15064

p5pRT opened this issue Nov 26, 2015 · 16 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 26, 2015

Migrated from rt.perl.org#126735 (status was 'resolved')

Searchable as RT126735$

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2015

From @KES777

Created by @KES777

When I try debug script remotely I set​:

PERLDB_OPTS=RemotePort=keswork​:9001

and if the nobody occasionally listen that port
I can not exit from debugger, even can not run any command
Only CTRL+C works.

http​://paste.scsys.co.uk/501839
  1 $ perl -d deb2.pl
  2 Unable to connect to remote host​: keswork​:9001
  3 Compilation failed in require.
  4 at deb2.pl line 0.
  5 main​::BEGIN() called at deb2.pl line 0
  6 eval {...} called at deb2.pl line 0
  7 BEGIN failed--compilation aborted.
  8 at deb2.pl line 0.
  9 Debugged program terminated. Use q to quit or R to restart,
  10 use o inhibit_exit to avoid stopping after program termination,
  11 h q, h R or h o to get additional info.
  12 DB<1> q
  13 syntax error at (eval 10)[/home/kes/perl/lib/5.22.0/perl5db.pl​:737] line 4, at EOF
  14 (Might be a runaway multi-line ;; string starting on line 2)
  15
  16 DB<1> ^C
  17 kes@​keswork ~/tmp $ cat deb2.pl
  18 #!/usr/bin/env perl
  19
  20 my $a = 1;
  21
  22 print $a;

Perl Info

Flags:
    category=library
    severity=low

Site configuration information for perl 5.22.0:

Configured by kes at Tue Sep 29 16:12:55 EEST 2015.

Summary of my perl5 (revision 5 version 22 subversion 0) configuration:
   
  Platform:
    osname=linux, osvers=3.13.0-37-generic, archname=x86_64-linux
    uname='linux keswork 3.13.0-37-generic #64-ubuntu smp mon sep 22 21:28:38 utc 2014 x86_64 x86_64 x86_64 gnulinux '
    config_args='-des -Dprefix=/home/kes/perl'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.8.4', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
    libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.19'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'



@INC for perl 5.22.0:
    /home/kes/perl5/lib/perl5/x86_64-linux
    /home/kes/perl5/lib/perl5
    /home/kes/perl/lib/site_perl/5.22.0/x86_64-linux
    /home/kes/perl/lib/site_perl/5.22.0
    /home/kes/perl/lib/5.22.0/x86_64-linux
    /home/kes/perl/lib/5.22.0
    .


Environment for perl 5.22.0:
    HOME=/home/kes
    LANG=ru_UA.UTF-8
    LANGUAGE=en
    LC_MESSAGES=en_US.UTF-8
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/kes/perl/bin:/home/kes/perl/bin:/home/kes/perl5/bin:/home/kes/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
    PERL5LIB=/home/kes/perl5/lib/perl5
    PERLDB_OPTS=RemotePort=keswork:9001
    PERL_BADLANG (unset)
    PERL_MB_OPT=--install_base "/home/kes/perl5"
    PERL_MM_OPT=INSTALL_BASE=/home/kes/perl5
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2015

From @shlomif

On Thu Nov 26 00​:57​:44 2015, kes-kes@​yandex.ua wrote​:

To​: perlbug@​perl.org
Subject​: Can not quit from perl debugger by 'q'
Cc​: kes-kes@​yandex.ru
Reply-To​: kes-kes@​yandex.ru
Message-Id​: <5.22.0_28030_1448525199@​keswork>
From​: kes-kes@​yandex.ru

This is a bug report for perl from kes-kes@​yandex.ru,
generated with the help of perlbug 1.40 running under perl 5.22.0.

-----------------------------------------------------------------
[Please describe your issue here]

When I try debug script remotely I set​:

PERLDB_OPTS=RemotePort=keswork​:9001

and if the nobody occasionally listen that port
I can not exit from debugger, even can not run any command
Only CTRL+C works.

Thanks for the report, kes! The problem happens when one specifies a RemotePort that cannot be connected to. Attached is a patch to fix the problem on mostly recent bleadperl. It passes all tests and adds some new test assertions. The patch was caused by a lexical variable in lib/perl5db.pl that was used in the BEGIN stage before being initialised. I believe it was I who introduced this variable as part of the massive debugger refactoring I have done as part of one of my TPF grants, and it wasn't caught due to inadequate test coverage.

I ran into some problems getting the tests not to hang but they should be OK now.

Please look into applying it.

Regards,

-- Shlomi Fish

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2015

From @shlomif

perl-debugger-rt126735-fix-v1.patch
diff --git a/lib/perl5db.pl b/lib/perl5db.pl
index 0d240ae..884f67a 100644
--- a/lib/perl5db.pl
+++ b/lib/perl5db.pl
@@ -2490,7 +2490,11 @@ EOP
 # 'm' is method.
 # 'v' is the value (i.e: method name or subroutine ref).
 # 's' is subroutine.
-my %cmd_lookup =
+my %cmd_lookup;
+
+BEGIN
+{
+    %cmd_lookup =
 (
     '-' => { t => 'm', v => '_handle_dash_command', },
     '.' => { t => 's', v => \&_DB__handle_dot_command, },
@@ -2523,6 +2527,7 @@ my %cmd_lookup =
     (map { $_ => {t => 'm', v => '_handle_cmd_wrapper_commands' }, }
         qw(a A b B e E h i l L M o O v w W)),
 );
+};
 
 sub DB {
 
diff --git a/lib/perl5db.t b/lib/perl5db.t
index 98a3686..6ac3932 100644
--- a/lib/perl5db.t
+++ b/lib/perl5db.t
@@ -29,7 +29,7 @@ BEGIN {
     $ENV{PERL_RL} = 'Perl'; # Suppress system Term::ReadLine::Gnu
 }
 
-plan(121);
+plan(123);
 
 my $rc_filename = '.perldb';
 
@@ -2799,6 +2799,22 @@ SKIP:
     );
 }
 
+{
+    # perl 5 RT #126735 regression bug.
+    local $ENV{PERLDB_OPTS} = "NonStop=0 RemotePort=non-existent-host.tld:9001";
+    my $output = runperl( stdin => 'q', stderr => 1, switches => [ '-d' ], prog => '../lib/perl5db/t/fact' );
+    like(
+        $output,
+        qr/^Unable to connect to remote host:/ms,
+        'Tried to connect.',
+    );
+    unlike(
+        $output,
+        qr/syntax error/,
+        'Can quit from the debugger after a wrong RemotePort',
+    );
+}
+
 END {
     1 while unlink ($rc_filename, $out_fn);
 }

@p5pRT
Copy link
Author

p5pRT commented Nov 26, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 27, 2015

From @KES777

No, this patch does not fix the problem. The output​:

perl -d t.pl
Unable to connect to remote host​: keswork​:9001
Compilation failed in require.
at t.pl line 0.
  main​::BEGIN() called at t.pl line 0
  eval {...} called at t.pl line 0
BEGIN failed--compilation aborted.
at t.pl line 0.
Debugged program terminated. Use q to quit or R to restart,
use o inhibit_exit to avoid stopping after program termination,
h q, h R or h o to get additional info.
  DB<1> q
syntax error at (eval 10)[/home/kes/perl/lib/5.22.0/perl5db.pl​:737] line 4, at EOF
  (Might be a runaway multi-line ;; string starting on line 2)

  DB<1>

Maybe you need "q\n" in your testcase? (NOTICE​: \n)

26.11.2015, 22​:25, "Shlomi Fish via RT" <perlbug-followup@​perl.org>​:

On Thu Nov 26 00​:57​:44 2015, kes-kes@​yandex.ua wrote​:

 To​: perlbug@​perl.org
 Subject​: Can not quit from perl debugger by 'q'
 Cc​: kes-kes@​yandex.ru
 Reply-To​: kes-kes@​yandex.ru
 Message-Id​: <5.22.0_28030_1448525199@​keswork>
 From​: kes-kes@​yandex.ru

 This is a bug report for perl from kes-kes@​yandex.ru,
 generated with the help of perlbug 1.40 running under perl 5.22.0.

 -----------------------------------------------------------------
 [Please describe your issue here]

 When I try debug script remotely I set​:

 PERLDB_OPTS=RemotePort=keswork​:9001

 and if the nobody occasionally listen that port
 I can not exit from debugger, even can not run any command
 Only CTRL+C works.

Thanks for the report, kes! The problem happens when one specifies a RemotePort that cannot be connected to. Attached is a patch to fix the problem on mostly recent bleadperl. It passes all tests and adds some new test assertions. The patch was caused by a lexical variable in lib/perl5db.pl that was used in the BEGIN stage before being initialised. I believe it was I who introduced this variable as part of the massive debugger refactoring I have done as part of one of my TPF grants, and it wasn't caught due to inadequate test coverage.

I ran into some problems getting the tests not to hang but they should be OK now.

Please look into applying it.

Regards,

-- Shlomi Fish

,

diff --git a/lib/perl5db.pl b/lib/perl5db.pl
index 0d240ae..884f67a 100644
--- a/lib/perl5db.pl
+++ b/lib/perl5db.pl
@​@​ -2490,7 +2490,11 @​@​ EOP
 # 'm' is method.
 # 'v' is the value (i.e​: method name or subroutine ref).
 # 's' is subroutine.
-my %cmd_lookup =
+my %cmd_lookup;
+
+BEGIN
+{
+ %cmd_lookup =
 (
     '-' => { t => 'm', v => '_handle_dash_command', },
     '.' => { t => 's', v => \&_DB__handle_dot_command, },
@​@​ -2523,6 +2527,7 @​@​ my %cmd_lookup =
     (map { $_ => {t => 'm', v => '_handle_cmd_wrapper_commands' }, }
         qw(a A b B e E h i l L M o O v w W)),
 );
+};

 sub DB {

diff --git a/lib/perl5db.t b/lib/perl5db.t
index 98a3686..6ac3932 100644
--- a/lib/perl5db.t
+++ b/lib/perl5db.t
@​@​ -29,7 +29,7 @​@​ BEGIN {
     $ENV{PERL_RL} = 'Perl'; # Suppress system Term​::ReadLine​::Gnu
 }

-plan(121);
+plan(123);

 my $rc_filename = '.perldb';

@​@​ -2799,6 +2799,22 @​@​ SKIP​:
     );
 }

+{
+ # perl 5 RT #126735 regression bug.
+ local $ENV{PERLDB_OPTS} = "NonStop=0 RemotePort=non-existent-host.tld​:9001";
+ my $output = runperl( stdin => 'q', stderr => 1, switches => [ '-d' ], prog => '../lib/perl5db/t/fact' );
+ like(
+ $output,
+ qr/^Unable to connect to remote host​:/ms,
+ 'Tried to connect.',
+ );
+ unlike(
+ $output,
+ qr/syntax error/,
+ 'Can quit from the debugger after a wrong RemotePort',
+ );
+}
+
 END {
     1 while unlink ($rc_filename, $out_fn);
 }

@p5pRT
Copy link
Author

p5pRT commented Nov 28, 2015

From @shlomif

Hi KES,

On Fri Nov 27 03​:44​:52 2015, kes-kes@​yandex.ua wrote​:

No, this patch does not fix the problem.

Really? How did you apply it? Did you run "make install"? This patch was done against bleadperl - is that what you used? This patch worked perfectly well here with bleadperl.

The output​:

perl -d t.pl
Unable to connect to remote host​: keswork​:9001
Compilation failed in require.
at t.pl line 0.
main​::BEGIN() called at t.pl line 0
eval {...} called at t.pl line 0
BEGIN failed--compilation aborted.
at t.pl line 0.
Debugged program terminated. Use q to quit or R to restart,
use o inhibit_exit to avoid stopping after program termination,
h q, h R or h o to get additional info.
DB<1> q
syntax error at (eval 10)[/home/kes/perl/lib/5.22.0/perl5db.pl​:737]
line 4, at EOF
(Might be a runaway multi-line ;; string starting on line 2)

DB<1>

What are the contents of t.pl? The error you are getting from it initially is really strange.

Maybe you need "q\n" in your testcase? (NOTICE​: \n)

It's not a bad idea to add it, but I believe it's not necessary, because the STDIN will get an EOF.

Regards,

-- Shlomi Fish

26.11.2015, 22​:25, "Shlomi Fish via RT" <perlbug-followup@​perl.org>​:

On Thu Nov 26 00​:57​:44 2015, kes-kes@​yandex.ua wrote​:

 To​: perlbug@​perl.org
 Subject​: Can not quit from perl debugger by 'q'
 Cc​: kes-kes@​yandex.ru
 Reply-To​: kes-kes@​yandex.ru
 Message-Id​: <5.22.0_28030_1448525199@​keswork>
 From​: kes-kes@​yandex.ru

 This is a bug report for perl from kes-kes@​yandex.ru,
 generated with the help of perlbug 1.40 running under perl 5.22.0.

 -----------------------------------------------------------------
 [Please describe your issue here]

 When I try debug script remotely I set​:

 PERLDB_OPTS=RemotePort=keswork​:9001

 and if the nobody occasionally listen that port
 I can not exit from debugger, even can not run any command
 Only CTRL+C works.

Thanks for the report, kes! The problem happens when one specifies a
RemotePort that cannot be connected to. Attached is a patch to fix
the problem on mostly recent bleadperl. It passes all tests and adds
some new test assertions. The patch was caused by a lexical variable
in lib/perl5db.pl that was used in the BEGIN stage before being
initialised. I believe it was I who introduced this variable as part
of the massive debugger refactoring I have done as part of one of my
TPF grants, and it wasn't caught due to inadequate test coverage.

I ran into some problems getting the tests not to hang but they
should be OK now.

Please look into applying it.

Regards,

-- Shlomi Fish

,

diff --git a/lib/perl5db.pl b/lib/perl5db.pl
index 0d240ae..884f67a 100644
--- a/lib/perl5db.pl
+++ b/lib/perl5db.pl
@​@​ -2490,7 +2490,11 @​@​ EOP
 # 'm' is method.
 # 'v' is the value (i.e​: method name or subroutine ref).
 # 's' is subroutine.
-my %cmd_lookup =
+my %cmd_lookup;
+
+BEGIN
+{
+ %cmd_lookup =
 (
     '-' => { t => 'm', v => '_handle_dash_command', },
     '.' => { t => 's', v => \&_DB__handle_dot_command, },
@​@​ -2523,6 +2527,7 @​@​ my %cmd_lookup =
     (map { $_ => {t => 'm', v => '_handle_cmd_wrapper_commands' }, }
         qw(a A b B e E h i l L M o O v w W)),
 );
+};

 sub DB {

diff --git a/lib/perl5db.t b/lib/perl5db.t
index 98a3686..6ac3932 100644
--- a/lib/perl5db.t
+++ b/lib/perl5db.t
@​@​ -29,7 +29,7 @​@​ BEGIN {
     $ENV{PERL_RL} = 'Perl'; # Suppress system Term​::ReadLine​::Gnu
 }

-plan(121);
+plan(123);

 my $rc_filename = '.perldb';

@​@​ -2799,6 +2799,22 @​@​ SKIP​:
     );
 }

+{
+ # perl 5 RT #126735 regression bug.
+ local $ENV{PERLDB_OPTS} = "NonStop=0 RemotePort=non-existent-
host.tld​:9001";
+ my $output = runperl( stdin => 'q', stderr => 1, switches => [ '-d'
], prog => '../lib/perl5db/t/fact' );
+ like(
+ $output,
+ qr/^Unable to connect to remote host​:/ms,
+ 'Tried to connect.',
+ );
+ unlike(
+ $output,
+ qr/syntax error/,
+ 'Can quit from the debugger after a wrong RemotePort',
+ );
+}
+
 END {
     1 while unlink ($rc_filename, $out_fn);
 }

@p5pRT
Copy link
Author

p5pRT commented Nov 28, 2015

From @shlomif

Here is a better patch with the \n and the $VERSION of perl -d.

@p5pRT
Copy link
Author

p5pRT commented Nov 28, 2015

From @shlomif

perl-d-rt126735-fix-v5.diff
diff --git a/lib/perl5db.pl b/lib/perl5db.pl
index 0d240ae..68f7e50 100644
--- a/lib/perl5db.pl
+++ b/lib/perl5db.pl
@@ -528,7 +528,7 @@ BEGIN {
 # Debugger for Perl 5.00x; perl5db.pl patch level:
 use vars qw($VERSION $header);
 
-$VERSION = '1.49_01';
+$VERSION = '1.49_02';
 
 $header = "perl5db.pl version $VERSION";
 
@@ -2490,7 +2490,11 @@ EOP
 # 'm' is method.
 # 'v' is the value (i.e: method name or subroutine ref).
 # 's' is subroutine.
-my %cmd_lookup =
+my %cmd_lookup;
+
+BEGIN
+{
+    %cmd_lookup =
 (
     '-' => { t => 'm', v => '_handle_dash_command', },
     '.' => { t => 's', v => \&_DB__handle_dot_command, },
@@ -2523,6 +2527,7 @@ my %cmd_lookup =
     (map { $_ => {t => 'm', v => '_handle_cmd_wrapper_commands' }, }
         qw(a A b B e E h i l L M o O v w W)),
 );
+};
 
 sub DB {
 
diff --git a/lib/perl5db.t b/lib/perl5db.t
index 98a3686..0c4fc42 100644
--- a/lib/perl5db.t
+++ b/lib/perl5db.t
@@ -29,7 +29,7 @@ BEGIN {
     $ENV{PERL_RL} = 'Perl'; # Suppress system Term::ReadLine::Gnu
 }
 
-plan(121);
+plan(123);
 
 my $rc_filename = '.perldb';
 
@@ -2799,6 +2799,22 @@ SKIP:
     );
 }
 
+{
+    # perl 5 RT #126735 regression bug.
+    local $ENV{PERLDB_OPTS} = "NonStop=0 RemotePort=non-existent-host.tld:9001";
+    my $output = runperl( stdin => "q\n", stderr => 1, switches => [ '-d' ], prog => '../lib/perl5db/t/fact' );
+    like(
+        $output,
+        qr/^Unable to connect to remote host:/ms,
+        'Tried to connect.',
+    );
+    unlike(
+        $output,
+        qr/syntax error/,
+        'Can quit from the debugger after a wrong RemotePort',
+    );
+}
+
 END {
     1 while unlink ($rc_filename, $out_fn);
 }

@p5pRT
Copy link
Author

p5pRT commented Nov 30, 2015

From @KES777

I redone your instructions from start. It seems I did something wrong.
Your patch works fine.

Thank you.

@p5pRT
Copy link
Author

p5pRT commented Nov 30, 2015

From @shlomif

Hi KES,

On Mon Nov 30 05​:02​:59 2015, kes-kes@​yandex.ua wrote​:

I redone your instructions from start. It seems I did something wrong.
Your patch works fine.

Thank you.

Thanks for the heads up, and I'm happy to hear the patch is now working fine for you. You're also very welcome.

I suggest one of the bleadperl committers look into applying this patch. (As I don't have a commit bit.)

Regards,

-- Shlomi Fish

@p5pRT
Copy link
Author

p5pRT commented Nov 30, 2015

From @jkeenan

On Mon Nov 30 09​:19​:32 2015, shlomif wrote​:

Hi KES,

On Mon Nov 30 05​:02​:59 2015, kes-kes@​yandex.ua wrote​:

I redone your instructions from start. It seems I did something
wrong.
Your patch works fine.

Thank you.

Thanks for the heads up, and I'm happy to hear the patch is now
working fine for you. You're also very welcome.

I suggest one of the bleadperl committers look into applying this
patch. (As I don't have a commit bit.)

Thanks for the patch. I have it smoking in this branch​:

smoke-me/jkeenan/shlomif/126735-debugger

Let's get some more eyeballs on it.

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Dec 1, 2015

From @shlomif

On Mon Nov 30 15​:32​:31 2015, jkeenan wrote​:

On Mon Nov 30 09​:19​:32 2015, shlomif wrote​:

Hi KES,

On Mon Nov 30 05​:02​:59 2015, kes-kes@​yandex.ua wrote​:

I redone your instructions from start. It seems I did something
wrong.
Your patch works fine.

Thank you.

Thanks for the heads up, and I'm happy to hear the patch is now
working fine for you. You're also very welcome.

I suggest one of the bleadperl committers look into applying this
patch. (As I don't have a commit bit.)

Thanks for the patch. I have it smoking in this branch​:

smoke-me/jkeenan/shlomif/126735-debugger

Thanks!

Let's get some more eyeballs on it.

Sure.

Thank you very much.

You're welcome.

@p5pRT
Copy link
Author

p5pRT commented Dec 2, 2015

From @rjbs

* James E Keenan via RT <perlbug-followup@​perl.org> [2015-11-30T18​:32​:32]

Thanks for the patch. I have it smoking in this branch​:

smoke-me/jkeenan/shlomif/126735-debugger

Let's get some more eyeballs on it.

+1

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Dec 2, 2015

From @jkeenan

On Tue Dec 01 19​:22​:37 2015, perl.p5p@​rjbs.manxome.org wrote​:

* James E Keenan via RT <perlbug-followup@​perl.org> [2015-11-30T18​:32​:32]

Thanks for the patch. I have it smoking in this branch​:

smoke-me/jkeenan/shlomif/126735-debugger

Let's get some more eyeballs on it.

+1

Thanks for the review. Applied to blead in commit 2305393.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT p5pRT closed this as completed Dec 2, 2015
@p5pRT
Copy link
Author

p5pRT commented Dec 2, 2015

@jkeenan - Status changed from 'open' to 'resolved'

@p5pRT
Copy link
Author

p5pRT commented Dec 3, 2015

From @shlomif

On Wed, 2 Dec 2015 15​:32​:02 -0800
"James E Keenan via RT" <perlbug-followup@​perl.org> wrote​:

On Tue Dec 01 19​:22​:37 2015, perl.p5p@​rjbs.manxome.org wrote​:

* James E Keenan via RT <perlbug-followup@​perl.org> [2015-11-30T18​:32​:32]

Thanks for the patch. I have it smoking in this branch​:

smoke-me/jkeenan/shlomif/126735-debugger

Let's get some more eyeballs on it.

+1

Thanks for the review. Applied to blead in commit
2305393.

Thanks for applying the patch! ♥!

Regards,

  Shlomi Fish

--


Shlomi Fish

Please reply to list if it's a mailing list post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant