Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong line number in error message using Promise #4768

Closed
p6rt opened this issue Nov 20, 2015 · 4 comments
Closed

wrong line number in error message using Promise #4768

p6rt opened this issue Nov 20, 2015 · 4 comments
Labels
RFC Request For Comments

Comments

@p6rt
Copy link

p6rt commented Nov 20, 2015

Migrated from rt.perl.org#126692 (status was 'resolved')

Searchable as RT126692$

@p6rt
Copy link
Author

p6rt commented Nov 20, 2015

From @MARTIMM

Hi,

When using 'my $p = Promise.start($code)' and die in that code for some
reason, I will get the die error message but the line number is of the
'await $p' line. It would be more helpful to have the line number of the
original die statement.

perl6 version 2015.11-5-g08a804c built on MoarVM version 2015.11

Greetings
Marcel

@p6rt
Copy link
Author

p6rt commented Sep 12, 2017

From @jnthn

On Fri, 20 Nov 2015 08​:19​:56 -0800, mt1957@​gmail.com wrote​:

Hi,

When using 'my $p = Promise.start($code)' and die in that code for some
reason, I will get the die error message but the line number is of the
'await $p' line. It would be more helpful to have the line number of the
original die statement.

perl6 version 2015.11-5-g08a804c built on MoarVM version 2015.11

This was long ago improved. It now looks like this​:

$ cat x.p6
my $p = start {
  die "oops";
}
await $p;

$ ./perl6-m x.p6
Tried to get the result of a broken Promise
  in block <unit> at x.p6 line 4

Original exception​:
  oops
  in block at x.p6 line 2

And I remember putting in tests for it, so resolving.

@p6rt
Copy link
Author

p6rt commented Sep 12, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Sep 12, 2017

@jnthn - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Sep 12, 2017
@p6rt p6rt added the RFC Request For Comments label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

No branches or pull requests

1 participant