Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Include the error message on IPC::Open3 exec() failure #15041

Closed
p5pRT opened this issue Nov 10, 2015 · 7 comments
Closed

[PATCH] Include the error message on IPC::Open3 exec() failure #15041

p5pRT opened this issue Nov 10, 2015 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 10, 2015

Migrated from rt.perl.org#126609 (status was 'resolved')

Searchable as RT126609$

@p5pRT
Copy link
Author

p5pRT commented Nov 10, 2015

From @ilmari

See attached patch.

@p5pRT
Copy link
Author

p5pRT commented Nov 10, 2015

From @ilmari

0001-Include-the-error-message-on-IPC-Open3-exec-failure.patch
From 3c791a6b3aebabbb9a761902942164b675a4ebda Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org>
Date: Tue, 10 Nov 2015 10:59:24 +0000
Subject: [PATCH] Include the error message on IPC::Open3 exec() failure

---
 ext/IPC-Open3/lib/IPC/Open3.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ext/IPC-Open3/lib/IPC/Open3.pm b/ext/IPC-Open3/lib/IPC/Open3.pm
index 273f205..e5924a3 100644
--- a/ext/IPC-Open3/lib/IPC/Open3.pm
+++ b/ext/IPC-Open3/lib/IPC/Open3.pm
@@ -9,7 +9,7 @@ package IPC::Open3;
 use Carp;
 use Symbol qw(gensym qualify);
 
-$VERSION	= '1.19';
+$VERSION	= '1.20';
 @ISA		= qw(Exporter);
 @EXPORT		= qw(open3);
 
@@ -280,7 +280,7 @@ sub _open3 {
 		return 1 if ($_[0] eq '-');
 		exec @_ or do {
 		    local($")=(" ");
-		    croak "$Me: exec of @_ failed";
+		    croak "$Me: exec of @_ failed: $!";
 		};
 	    } and do {
                 close $stat_w;
-- 
2.6.2

@p5pRT
Copy link
Author

p5pRT commented Nov 10, 2015

From @ilmari

--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen

@p5pRT
Copy link
Author

p5pRT commented Nov 12, 2015

From @tonycoz

On Tue Nov 10 03​:02​:25 2015, ilmari wrote​:

See attached patch.

Thanks, applied as 48d0e2b.

Tony

@p5pRT
Copy link
Author

p5pRT commented Nov 12, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 12, 2015

@tonycoz - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Nov 12, 2015
@p5pRT
Copy link
Author

p5pRT commented Nov 13, 2015

From @ikegami

Thanks. This was on my to-do list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant