New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary preload wrapper in Makefile #15036
Comments
From hanno@hboeck.deHi, The Makefile.SH in perl contains some code that will in certain I think this is The point of the wrapper seems to be to make sure that during the The check whether this preload script gets used looks like this: Finally why I actually found this and why I think it causes problems: I Conclusion: Please just remove this, I don't think it does any good and -- mail/jabber: hanno@hboeck.de |
From hanno@hboeck.deperl-5.22.0-remove-unneeded-preload.diff--- ./perl-5.22.0/Makefile.SH 2015-05-13 22:19:28.000000000 +0200
+++ ./perl-5.22.0-nopreload/Makefile.SH 2015-10-31 13:45:02.939255468 +0100
@@ -134,26 +134,6 @@
esac
case "$osname" in
- linux)
- # If there is a pre-existing $libperl from a previous
- # installation, Linux needs to use LD_PRELOAD to
- # override the LD_LIBRARY_PATH setting. See the
- # INSTALL file, under "Building a shared perl library".
- # If there is no pre-existing $libperl, we don't need
- # to do anything further.
- if test -f $archlib/CORE/$libperl; then
- rm -f preload
- cat <<'EOT' > preload
-#! /bin/sh
-lib=$1
-shift
-test -r $lib && export LD_PRELOAD="$lib $LD_PRELOAD"
-exec "$@"
-EOT
- chmod 755 preload
- ldlibpth="$ldlibpth `pwd`/preload `pwd`/$libperl"
- fi
- ;;
os390) test -f /bin/env && ldlibpth="/bin/env $ldlibpth"
;;
esac
|
From hanno@hboeck.deHi, I already sent this mail a while ago, but somehow it never got to this The Makefile.SH in perl contains some code that will in certain I think this is The point of the wrapper seems to be to make sure that during the The check whether this preload script gets used looks like this: Finally why I actually found this and why I think it causes problems: I Conclusion: Please just remove this, I don't think it does any good and -- mail/jabber: hanno@hboeck.de |
From hanno@hboeck.deperl-5.22.0-remove-unneeded-preload.diff--- ./perl-5.22.0/Makefile.SH 2015-05-13 22:19:28.000000000 +0200
+++ ./perl-5.22.0-nopreload/Makefile.SH 2015-10-31 13:45:02.939255468 +0100
@@ -134,26 +134,6 @@
esac
case "$osname" in
- linux)
- # If there is a pre-existing $libperl from a previous
- # installation, Linux needs to use LD_PRELOAD to
- # override the LD_LIBRARY_PATH setting. See the
- # INSTALL file, under "Building a shared perl library".
- # If there is no pre-existing $libperl, we don't need
- # to do anything further.
- if test -f $archlib/CORE/$libperl; then
- rm -f preload
- cat <<'EOT' > preload
-#! /bin/sh
-lib=$1
-shift
-test -r $lib && export LD_PRELOAD="$lib $LD_PRELOAD"
-exec "$@"
-EOT
- chmod 755 preload
- ldlibpth="$ldlibpth `pwd`/preload `pwd`/$libperl"
- fi
- ;;
os390) test -f /bin/env && ldlibpth="/bin/env $ldlibpth"
;;
esac
|
From @jkeenanOn Mon Nov 30 20:20:55 2015, hanno@hboeck.de wrote:
You sent it to perl5-porters-owner@perl.org, which is not the correct address. It appears that the message lurked in some dark corner of our system until the sysadmin spotted it today and moved it into the Perl 5 bug queue.
The patch you attached was drawn against perl-5.22 and so would be unlikely to apply. I have created this branch: smoke-me/jkeenan/126599-preload ... and manually modified Makefile.SH consistent with your request. It is now smoke-testing. However, I approach this patch with skepticism. The code in question in Makefile.SH has been in place for over 13 years and pertains to linux, which is the tested operating system on which Perl 5 blead is most frequently tested. Hence, if the problem about which you wrote is a significant problem, I would have expected it to have been reported a long time ago. I'm bcc-ing some of the original contributors to this section of the codebase. Thanks for the patch. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sun Sep 11 19:23:54 2016, jkeenan wrote:
For reference, I am attaching the patch found in the smoke branch. -- |
From @jkeenan126599-0001-Remove-wrapper-script-preload.patchFrom d146d745b3d9e0d62d42242dce0a50c882924be3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hanno=20B=C3=B6ck?= <hanno@hboeck.de>
Date: Sun, 11 Sep 2016 22:06:47 -0400
Subject: [PATCH] Remove wrapper script "preload".
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Committer: Add Hanno Böck to AUTHORS.
For RT #126599
---
AUTHORS | 1 +
Makefile.SH | 20 --------------------
2 files changed, 1 insertion(+), 20 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index d1b87fc..e923350 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -476,6 +476,7 @@ H.Merijn Brand <h.m.brand@xs4all.nl>
Hal Morris <hom00@utsglobal.com>
Hal Pomeranz <pomeranz@netcom.com>
Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
+Hanno Böck <hanno@hboeck.de>
Hannu Napari <Hannu.Napari@hut.fi>
Hans de Graaff <J.J.deGraaff@twi.tudelft.nl>
Hans Dieter Pearcey <hdp@pobox.com>
diff --git a/Makefile.SH b/Makefile.SH
index 42beb81..df2a848 100755
--- a/Makefile.SH
+++ b/Makefile.SH
@@ -143,26 +143,6 @@ true)
esac
case "$osname" in
- linux)
- # If there is a pre-existing $libperl from a previous
- # installation, Linux needs to use LD_PRELOAD to
- # override the LD_LIBRARY_PATH setting. See the
- # INSTALL file, under "Building a shared perl library".
- # If there is no pre-existing $libperl, we don't need
- # to do anything further.
- if test -f $archlib/CORE/$libperl; then
- rm -f preload
- cat <<'EOT' > preload
-#! /bin/sh
-lib=$1
-shift
-test -r $lib && export LD_PRELOAD="$lib $LD_PRELOAD"
-exec "$@"
-EOT
- chmod 755 preload
- ldlibpth="$ldlibpth `pwd`/preload `pwd`/$libperl"
- fi
- ;;
os390) test -f /bin/env && ldlibpth="/bin/env $ldlibpth"
;;
esac
--
2.7.4
|
From [Unknown Contact. See original ticket]On Sun Sep 11 19:23:54 2016, jkeenan wrote:
For reference, I am attaching the patch found in the smoke branch. -- |
From hanno@hboeck.deHi, On Sun, 11 Sep 2016 19:23:55 -0700
There already was some follow-up discussion here: However the issue is still unresolved. The reason why this didn't show I'd still hope we can somehow resolve this and make using ASAN with -- mail/jabber: hanno@hboeck.de |
Migrated from rt.perl.org#126599 (status was 'open')
Searchable as RT126599$
The text was updated successfully, but these errors were encountered: