Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] dont install PPPort.so/PPPort.dll #15023

Closed
p5pRT opened this issue Nov 1, 2015 · 5 comments
Closed

[PATCH] dont install PPPort.so/PPPort.dll #15023

p5pRT opened this issue Nov 1, 2015 · 5 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 1, 2015

Migrated from rt.perl.org#126534 (status was 'resolved')

Searchable as RT126534$

@p5pRT
Copy link
Author

p5pRT commented Nov 1, 2015

From @bulk88

See attached patch.

Summary of my perl5 (revision 5 version 23 subversion 5) configuration​:
  Derived from​: 644207b7a8ff7a2b1661c05a7f9ac2df9a5dad91
  Platform​:
    osname=MSWin32, osvers=6.1, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    useithreads=define, usemultiplicity=define
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler​:
    cc='cl', ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL -DWIN32 -D_CONSO
LE -DNO_STRICT -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE  -DPERL_TE
XTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS',
    optimize='-O1 -MD -Zi -DNDEBUG -GL',
    cppflags='-DWIN32'
    ccversion='18.00.31101', gccversion='', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234, doublekind=3

    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8, longdblki
nd=0
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksi
ze=8
    alignbytes=8, prototype=define
  Linker and Libraries​:
    ld='link', ldflags ='-nologo -nodefaultlib -debug -opt​:ref,icf -ltcg
        -libpath​:"c​:\p523\lib\CORE"             -machine​:x86 "/manifestdependenc
y​:type='Win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' proces
sorArchitecture='*' publicKeyToken='6595b64144ccf1df' language='*'" -subsystem​:c
onsole,"5.01"'
    libpth=\lib
    libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.li
b advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws2_32.l
ib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib

    perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg3
2.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws2_
32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt
.lib
    libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl523.lib
    gnulibc_version=''
  Dynamic Linking​:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug -opt​:ref,icf -l
tcg             -libpath​:"c​:\p523\lib\CORE"             -machine​:x86 "/manifestd
ependency​:type='Win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0
' processorArchitecture='*' publicKeyToken='6595b64144ccf1df' language='*'" -sub
system​:console,"5.01"'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES HAVE_INTERP_INTERN MULTIPLICITY
                        PERLIO_LAYERS PERL_COPY_ON_WRITE
                        PERL_DONT_CREATE_GVSV
                        PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
                        PERL_IMPLICIT_CONTEXT PERL_IMPLICIT_SYS
                        PERL_MALLOC_WRAP PERL_PRESERVE_IVUV USE_ITHREADS
                        USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
                        USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LOCALE_TIME
                        USE_PERLIO USE_PERL_ATOF
  Locally applied patches​:
        uncommitted-changes
  Built under MSWin32
  Compiled at Oct 25 2015 19​:14​:39
  @​INC​:
    C​:/p523/site/lib
    C​:/p523/lib
    .
 

@p5pRT
Copy link
Author

p5pRT commented Nov 1, 2015

From @bulk88

0001-dont-install-PPPort.so-PPPort.dll.patch
From dd5bf6e2f527192bd649a2656daa287b43192ccc Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Sun, 25 Oct 2015 19:31:27 -0400
Subject: [PATCH] dont install PPPort.so/PPPort.dll

This shared lib is only used for PPPort testing itself, it is similar to
APItest.dll in purpose. PPPort.pm never uses XSLoader/DynaLoader, only its
.t files do. This saves 616KB in the final install dir on Win32, and
atleast one or two dozen KB on all OSes. Since where is auto dir, and what
is arch dir, is complicated and unportable (atleast to me), and what other
files live next to the shared lib (examples, .pdb file, .bs file, .a file)
match the directory fragment, not the files inside of it or the dirs
full path.

 Directory of C:\p523\src\lib\auto\Devel\PPPort

10/25/2015  07:16 PM    <DIR>          .
10/25/2015  07:16 PM    <DIR>          ..
10/25/2015  07:16 PM                 0 .exists
10/25/2015  07:16 PM            59,392 PPPort.dll
10/25/2015  07:16 PM               796 PPPort.exp
10/25/2015  07:16 PM             1,738 PPPort.lib
10/25/2015  07:16 PM           569,344 PPPort.pdb
               5 File(s)        631,270 bytes
---
 installperl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/installperl b/installperl
index 866bf5d..5ea37be 100755
--- a/installperl
+++ b/installperl
@@ -671,8 +671,8 @@ sub installlib {
     return if $name =~ /^(?:cpan|instmodsh|prove|corelist|ptar|ptardiff|ptargrep|zipdetails)\z/;
     # ignore the Makefiles
     return if $name =~ /^makefile$/i;
-    # ignore the test extensions
-    return if $dir =~ m{\bXS/(?:APItest|Typemap)\b};
+    # ignore the test extensions, dont install PPPort.so/.dll
+    return if $dir =~ m{\b(?:XS/(?:APItest|Typemap)|Devel/PPPort)\b};
     return if $name =~ m{\b(?:APItest|Typemap)\.pm$};
     # ignore the build support code
     return if $name =~ /\bbuildcustomize\.pl$/;
-- 
1.9.5.msysgit.1

@p5pRT
Copy link
Author

p5pRT commented Nov 2, 2015

From @tonycoz

On Sun Nov 01 09​:52​:40 2015, bulk88 wrote​:

See attached patch.

Thanks, applied as 581f186.

Tony

@p5pRT
Copy link
Author

p5pRT commented Nov 2, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT p5pRT closed this as completed Nov 2, 2015
@p5pRT
Copy link
Author

p5pRT commented Nov 2, 2015

@tonycoz - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant