Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done outside of a supply block fails silently in Rakudo #4541

Closed
p6rt opened this issue Sep 17, 2015 · 5 comments
Closed

done outside of a supply block fails silently in Rakudo #4541

p6rt opened this issue Sep 17, 2015 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Sep 17, 2015

Migrated from rt.perl.org#126089 (status was 'resolved')

Searchable as RT126089$

@p6rt
Copy link
Author

p6rt commented Sep 17, 2015

From @masak

<masak> so what does `done` actually do outside of a `supply` block?
<jnthn> masak​: Nothing, just as "last" doesn't do anything outside of a loop
<PerlJam> masak​: throws a CONTROL_DONE
<masak> m​: last
<camelia> rakudo-moar 643eb6​: OUTPUT«last without loop construct [...]
<jnthn> Well, yeah, it whines you used it in the wrong place
<masak> jnthn​: at least it warns.
<masak> `done` does nothing.
<jnthn> m​: done
<camelia> rakudo-moar 643eb6​: ( no output )
<jnthn> Hm
<jnthn> m​: emit 1;
<camelia> rakudo-moar 643eb6​: ( no output )
<jnthn> Wonder why that gets dropped
<jnthn> It *is* throwing a control exception
<masak> anyway, it seems you agree with me it should do something ;)
<jnthn> Aye
* masak submits rakudobug

@p6rt
Copy link
Author

p6rt commented Sep 18, 2015

From @lizmat

jnthn fixed this with f435959e8b4a1ec72c98bc , tests needed afaik

On 17 Sep 2015, at 22​:44, Carl Mäsak (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by "Carl Mäsak"
# Please include the string​: [perl #​126089]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=126089 >

<masak> so what does `done` actually do outside of a `supply` block?
<jnthn> masak​: Nothing, just as "last" doesn't do anything outside of a loop
<PerlJam> masak​: throws a CONTROL_DONE
<masak> m​: last
<camelia> rakudo-moar 643eb6​: OUTPUT«last without loop construct [...]
<jnthn> Well, yeah, it whines you used it in the wrong place
<masak> jnthn​: at least it warns.
<masak> `done` does nothing.
<jnthn> m​: done
<camelia> rakudo-moar 643eb6​: ( no output )
<jnthn> Hm
<jnthn> m​: emit 1;
<camelia> rakudo-moar 643eb6​: ( no output )
<jnthn> Wonder why that gets dropped
<jnthn> It *is* throwing a control exception
<masak> anyway, it seems you agree with me it should do something ;)
<jnthn> Aye
* masak submits rakudobug

@p6rt
Copy link
Author

p6rt commented Sep 18, 2015

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Sep 19, 2015

From @jnthn

On Fri Sep 18 04​:22​:51 2015, elizabeth wrote​:

jnthn fixed this with f435959e8b4a1ec72c98bc , tests needed afaik

Test added in S17-supply/syntax.t.

@p6rt
Copy link
Author

p6rt commented Sep 19, 2015

@jnthn - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Sep 19, 2015
@p6rt p6rt added the testneeded label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant