Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error for "do undef" references "require" instead #14916

Closed
p5pRT opened this issue Sep 17, 2015 · 13 comments
Closed

error for "do undef" references "require" instead #14916

p5pRT opened this issue Sep 17, 2015 · 13 comments

Comments

@p5pRT
Copy link

p5pRT commented Sep 17, 2015

Migrated from rt.perl.org#126084 (status was 'resolved')

Searchable as RT126084$

@p5pRT
Copy link
Author

p5pRT commented Sep 17, 2015

From @rjbs

Created by @rjbs

  perl -e 'do undef'

Since 5.22.0, this reports "Missing or undefined argument to require",
an improvement on the previous "Null filename used"... when it's for
require.

"do undef" and "do()" should say "...to do", not "...to require"

(It's too bad we don't traditionally quote the builtins in these messages, as
"to do" is somewhat ambiguous if you don't know what's up. Fortunately, the
line number should clarify.)

Perl Info

Flags:
    category=core
    severity=medium

Site configuration information for perl 5.22.0:

Configured by rjbs at Mon Jun  1 12:58:35 EDT 2015.

Summary of my perl5 (revision 5 version 22 subversion 0) configuration:
   
  Platform:
    osname=darwin, osvers=14.3.0, archname=darwin-2level
    uname='darwin jubjub.local 14.3.0 darwin kernel version 14.3.0: mon mar 23 11:59:05 pdt 2015; root:xnu-2782.20.48~5release_x86_64 x86_64 '
    config_args='-Dprefix=/Users/rjbs/.plenv/versions/22.0 -de -Dusedevel -A'eval:scriptdir=/Users/rjbs/.plenv/versions/22.0/bin''
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -I/opt/local/include',
    optimize='-O3',
    cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -I/opt/local/include'
    ccversion='', gccversion='4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector-strong -L/usr/local/lib -L/opt/local/lib'
    libpth=/usr/local/lib /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.1.0/lib /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib /usr/lib /opt/local/lib
    libs=-lpthread -lgdbm -ldbm -ldl -lm -lutil -lc
    perllibs=-lpthread -ldl -lm -lutil -lc
    libc=, so=dylib, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -L/opt/local/lib -fstack-protector-strong'



@INC for perl 5.22.0:
    /Users/rjbs/.plenv/versions/22.0/lib/perl5/site_perl/5.22.0/darwin-2level
    /Users/rjbs/.plenv/versions/22.0/lib/perl5/site_perl/5.22.0
    /Users/rjbs/.plenv/versions/22.0/lib/perl5/5.22.0/darwin-2level
    /Users/rjbs/.plenv/versions/22.0/lib/perl5/5.22.0
    .


Environment for perl 5.22.0:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/rjbs
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/Users/rjbs/.plenv/versions/22.0/bin:/Users/rjbs/.plenv/libexec:/Users/rjbs/.plenv/plugins/perl-build/bin:/Users/rjbs/bin:/Users/rjbs/.rbenv/shims:/Users/rjbs/.rbenv/bin:/Users/rjbs/.rakudobrew/bin:/Users/rjbs/.plenv/shims:/Users/rjbs/.plenv/bin:/opt/local/bin:/opt/local/sbin:/usr/local/texlive/2015/bin/x86_64-darwin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/opt/X11/bin:/Users/rjbs/code/hla
    PERLDOC=-otext
    PERL_AUTOINSTALL=--skipdeps
    PERL_BADLANG (unset)
    PERL_MAILERS=sendmail:/Users/rjbs/bin/sendmail
    SHELL=/opt/local/bin/zsh

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2015

From @jkeenan

On Thu Sep 17 06​:37​:08 2015, rjbs wrote​:

This is a bug report for perl from rjbs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.22.0.

-----------------------------------------------------------------
[Please describe your issue here]

perl -e 'do undef'

Since 5.22.0, this reports "Missing or undefined argument to require",
an improvement on the previous "Null filename used"... when it's for
require.

"do undef" and "do()" should say "...to do", not "...to require"

These warnings are defined in PP(pp_require) in pp_ctl.c. There are several other points where it is indicated that the dofile opcode is implemented via pp_require. So, at a high level, we would probably need a PP(pp_do) in pp_ctl.c. But pp_require is several hundreds line of code long; I'm guessing we wouldn't need all of it for a pp_do.

(It's too bad we don't traditionally quote the builtins in these
messages, as
"to do" is somewhat ambiguous if you don't know what's up.
Fortunately, the
line number should clarify.)

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags​:
category=core
severity=medium
---
Site configuration information for perl 5.22.0​:

Configured by rjbs at Mon Jun 1 12​:58​:35 EDT 2015.

Summary of my perl5 (revision 5 version 22 subversion 0)
configuration​:

Platform​:
osname=darwin, osvers=14.3.0, archname=darwin-2level
uname='darwin jubjub.local 14.3.0 darwin kernel version 14.3.0​: mon
mar 23 11​:59​:05 pdt 2015; root​:xnu-2782.20.48~5release_x86_64 x86_64 '
config_args='-Dprefix=/Users/rjbs/.plenv/versions/22.0 -de
-Dusedevel -A'eval​:scriptdir=/Users/rjbs/.plenv/versions/22.0/bin''
hint=recommended, useposix=true, d_sigaction=define
useithreads=undef, usemultiplicity=undef
use64bitint=define, use64bitall=define, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler​:
cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing
-pipe -fstack-protector-strong -I/usr/local/include
-I/opt/local/include',
optimize='-O3',
cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe
-fstack-protector-strong -I/usr/local/include -I/opt/local/include'
ccversion='', gccversion='4.2.1 Compatible Apple LLVM 6.1.0 (clang-
602.0.53)', gccosandvers=''
intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678,
doublekind=3
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16,
longdblkind=3
ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries​:
ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-
protector-strong -L/usr/local/lib -L/opt/local/lib'
libpth=/usr/local/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.1.0/lib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib
/usr/lib /opt/local/lib
libs=-lpthread -lgdbm -ldbm -ldl -lm -lutil -lc
perllibs=-lpthread -ldl -lm -lutil -lc
libc=, so=dylib, useshrplib=false, libperl=libperl.a
gnulibc_version=''
Dynamic Linking​:
dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup
-L/usr/local/lib -L/opt/local/lib -fstack-protector-strong'

---
@​INC for perl 5.22.0​:
/Users/rjbs/.plenv/versions/22.0/lib/perl5/site_perl/5.22.0/darwin-
2level
/Users/rjbs/.plenv/versions/22.0/lib/perl5/site_perl/5.22.0
/Users/rjbs/.plenv/versions/22.0/lib/perl5/5.22.0/darwin-2level
/Users/rjbs/.plenv/versions/22.0/lib/perl5/5.22.0
.

---
Environment for perl 5.22.0​:
DYLD_LIBRARY_PATH (unset)
HOME=/Users/rjbs
LANG=en_US.UTF-8
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/Users/rjbs/.plenv/versions/22.0/bin​:/Users/rjbs/.plenv/libexec​:/Users/rjbs/.plenv/plugins/perl-
build/bin​:/Users/rjbs/bin​:/Users/rjbs/.rbenv/shims​:/Users/rjbs/.rbenv/bin​:/Users/rjbs/.rakudobrew/bin​:/Users/rjbs/.plenv/shims​:/Users/rjbs/.plenv/bin​:/opt/local/bin​:/opt/local/sbin​:/usr/local/texlive/2015/bin/x86_64-
darwin​:/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/local/bin​:/opt/X11/bin​:/Users/rjbs/code/hla
PERLDOC=-otext
PERL_AUTOINSTALL=--skipdeps
PERL_BADLANG (unset)
PERL_MAILERS=sendmail​:/Users/rjbs/bin/sendmail
SHELL=/opt/local/bin/zsh

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2015

From @tonycoz

On Sun Sep 20 15​:57​:21 2015, jkeenan wrote​:

These warnings are defined in PP(pp_require) in pp_ctl.c. There are
several other points where it is indicated that the dofile opcode is
implemented via pp_require. So, at a high level, we would probably
need a PP(pp_do) in pp_ctl.c. But pp_require is several hundreds line
of code long; I'm guessing we wouldn't need all of it for a pp_do.

You don't need to duplicate pp_require, we have a macro to find the description of an op.

See the attached.

Tony

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2015

From @tonycoz

0001-perl-126084-report-the-correct-op-in-pp_require.patch
From 0cf23372b33f16f0d3977c88c901b7f04b3cb21d Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Mon, 21 Sep 2015 09:43:14 +1000
Subject: [perl #126084] report the correct op in pp_require

pp_require implements both require and do "file", but always reported
the error as being for require.
---
 pod/perldiag.pod      | 12 ++++++++----
 pp_ctl.c              |  8 ++++----
 t/lib/croak/pp_ctl    | 20 ++++++++++++++++++++
 t/lib/warnings/pp_ctl | 13 +++++++++++++
 4 files changed, 45 insertions(+), 8 deletions(-)

diff --git a/pod/perldiag.pod b/pod/perldiag.pod
index 6af1245..eeb658a 100644
--- a/pod/perldiag.pod
+++ b/pod/perldiag.pod
@@ -3397,11 +3397,15 @@ can vary from one line to the next.
 (S syntax) This is an educated guess made in conjunction with the message
 "%s found where operator expected".  Often the missing operator is a comma.
 
-=item Missing or undefined argument to require
+=item Missing or undefined argument to %s
 
-(F) You tried to call require with no argument or with an undefined
-value as an argument.  Require expects either a package name or a
-file-specification as an argument.  See L<perlfunc/require>.
+(F) You tried to call require or do with no argument or with an undefined
+value as an argument.
+
+Require expects either a package name or a file-specification as an
+argument.  See L<perlfunc/require>.
+
+Do expected a file-specification as an argument.  See L<perlfunc/do>.
 
 =item Missing right brace on \%c{} in regex; marked by S<<-- HERE> in m/%s/
 
diff --git a/pp_ctl.c b/pp_ctl.c
index 852ec36..8e05d53 100644
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -3686,12 +3686,12 @@ PP(pp_require)
 	RETPUSHYES;
     }
     if (!SvOK(sv))
-        DIE(aTHX_ "Missing or undefined argument to require");
+        DIE(aTHX_ "Missing or undefined argument to %s", OP_DESC(PL_op));
     name = SvPV_nomg_const(sv, len);
     if (!(name && len > 0 && *name))
-        DIE(aTHX_ "Missing or undefined argument to require");
+        DIE(aTHX_ "Missing or undefined argument to %s", OP_DESC(PL_op));
 
-    if (!IS_SAFE_PATHNAME(name, len, "require")) {
+    if (!IS_SAFE_PATHNAME(name, len, OP_DESC(PL_op))) {
         DIE(aTHX_ "Can't locate %s:   %s",
             pv_escape(newSVpvs_flags("",SVs_TEMP),SvPVX(sv),SvCUR(sv),
                       SvCUR(sv)*2,NULL, SvUTF8(sv)?PERL_PV_ESCAPE_UNI:0),
@@ -3899,7 +3899,7 @@ PP(pp_require)
 			dirlen = 0;
 		    }
 
-		    if (!IS_SAFE_SYSCALL(dir, dirlen, "@INC entry", "require"))
+		    if (!IS_SAFE_SYSCALL(dir, dirlen, "@INC entry", OP_DESC(PL_op)))
 			continue;
 #ifdef VMS
 		    if ((unixdir =
diff --git a/t/lib/croak/pp_ctl b/t/lib/croak/pp_ctl
index ee1edba..0ce9166 100644
--- a/t/lib/croak/pp_ctl
+++ b/t/lib/croak/pp_ctl
@@ -16,3 +16,23 @@ use 5.01;
 default{}
 EXPECT
 Can't "default" outside a topicalizer at - line 2.
+########
+# NAME error on require undef
+require undef
+EXPECT
+Missing or undefined argument to require at - line 1.
+########
+# NAME error on require ""
+require ""
+EXPECT
+Missing or undefined argument to require at - line 1.
+########
+# NAME error on do undef
+do undef
+EXPECT
+Missing or undefined argument to do "file" at - line 1.
+########
+# NAME error on do ""
+do ""
+EXPECT
+Missing or undefined argument to do "file" at - line 1.
diff --git a/t/lib/warnings/pp_ctl b/t/lib/warnings/pp_ctl
index 9b3f298..2959fef 100644
--- a/t/lib/warnings/pp_ctl
+++ b/t/lib/warnings/pp_ctl
@@ -251,3 +251,16 @@ EXPECT
 use warnings;
 eval 'use 5.006; use 5.10.0';
 EXPECT
+########
+# NAME \0 in require/do arguments and @INC
+use warnings;
+eval 'require "a\0b";';
+eval 'do "a\0b"';
+push @INC, "a\0b";
+eval 'require "some-unknown-filename"';
+eval 'do "some-unknown-filename"';
+EXPECT
+Invalid \0 character in pathname for require: a\0b at (eval 1) line 1.
+Invalid \0 character in pathname for do "file": a\0b at (eval 2) line 1.
+Invalid \0 character in @INC entry for require: a\0b at (eval 3) line 1.
+Invalid \0 character in @INC entry for do "file": a\0b at (eval 4) line 1.
-- 
2.1.4

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2015

From @rjbs

* Tony Cook via RT <perlbug-followup@​perl.org> [2015-09-20T19​:44​:59]

See the attached.

Thanks!

+Require expects either a package name or a file-specification as an
+argument. See L<perlfunc/require>.
+
+Do expected a file-specification as an argument. See L<perlfunc/do>.

^--- Verb tense disagreement

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Sep 21, 2015

From @tonycoz

On Sun Sep 20 16​:50​:17 2015, perl.p5p@​rjbs.manxome.org wrote​:

* Tony Cook via RT <perlbug-followup@​perl.org> [2015-09-20T19​:44​:59]

See the attached.

Thanks!

+Require expects either a package name or a file-specification as an
+argument. See L<perlfunc/require>.
+
+Do expected a file-specification as an argument. See L<perlfunc/do>.

^--- Verb tense disagreement

Oops, updated patch.

Tony

@p5pRT
Copy link
Author

p5pRT commented Sep 21, 2015

From @tonycoz

0001-perl-126084-report-the-correct-op-in-pp_require.patch
From e6c2a82191fb03d6a76ba7e238cdccae1c859af2 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Mon, 21 Sep 2015 10:11:39 +1000
Subject: [perl #126084] report the correct op in pp_require

pp_require implements both require and do "file", but always reported
the error as being for require.
---
 pod/perldiag.pod      | 12 ++++++++----
 pp_ctl.c              |  8 ++++----
 t/lib/croak/pp_ctl    | 20 ++++++++++++++++++++
 t/lib/warnings/pp_ctl | 13 +++++++++++++
 4 files changed, 45 insertions(+), 8 deletions(-)

diff --git a/pod/perldiag.pod b/pod/perldiag.pod
index 6af1245..2e41502 100644
--- a/pod/perldiag.pod
+++ b/pod/perldiag.pod
@@ -3397,11 +3397,15 @@ can vary from one line to the next.
 (S syntax) This is an educated guess made in conjunction with the message
 "%s found where operator expected".  Often the missing operator is a comma.
 
-=item Missing or undefined argument to require
+=item Missing or undefined argument to %s
 
-(F) You tried to call require with no argument or with an undefined
-value as an argument.  Require expects either a package name or a
-file-specification as an argument.  See L<perlfunc/require>.
+(F) You tried to call require or do with no argument or with an undefined
+value as an argument.
+
+Require expects either a package name or a file-specification as an
+argument.  See L<perlfunc/require>.
+
+Do expects a file-specification as an argument.  See L<perlfunc/do>.
 
 =item Missing right brace on \%c{} in regex; marked by S<<-- HERE> in m/%s/
 
diff --git a/pp_ctl.c b/pp_ctl.c
index 852ec36..8e05d53 100644
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -3686,12 +3686,12 @@ PP(pp_require)
 	RETPUSHYES;
     }
     if (!SvOK(sv))
-        DIE(aTHX_ "Missing or undefined argument to require");
+        DIE(aTHX_ "Missing or undefined argument to %s", OP_DESC(PL_op));
     name = SvPV_nomg_const(sv, len);
     if (!(name && len > 0 && *name))
-        DIE(aTHX_ "Missing or undefined argument to require");
+        DIE(aTHX_ "Missing or undefined argument to %s", OP_DESC(PL_op));
 
-    if (!IS_SAFE_PATHNAME(name, len, "require")) {
+    if (!IS_SAFE_PATHNAME(name, len, OP_DESC(PL_op))) {
         DIE(aTHX_ "Can't locate %s:   %s",
             pv_escape(newSVpvs_flags("",SVs_TEMP),SvPVX(sv),SvCUR(sv),
                       SvCUR(sv)*2,NULL, SvUTF8(sv)?PERL_PV_ESCAPE_UNI:0),
@@ -3899,7 +3899,7 @@ PP(pp_require)
 			dirlen = 0;
 		    }
 
-		    if (!IS_SAFE_SYSCALL(dir, dirlen, "@INC entry", "require"))
+		    if (!IS_SAFE_SYSCALL(dir, dirlen, "@INC entry", OP_DESC(PL_op)))
 			continue;
 #ifdef VMS
 		    if ((unixdir =
diff --git a/t/lib/croak/pp_ctl b/t/lib/croak/pp_ctl
index ee1edba..0ce9166 100644
--- a/t/lib/croak/pp_ctl
+++ b/t/lib/croak/pp_ctl
@@ -16,3 +16,23 @@ use 5.01;
 default{}
 EXPECT
 Can't "default" outside a topicalizer at - line 2.
+########
+# NAME error on require undef
+require undef
+EXPECT
+Missing or undefined argument to require at - line 1.
+########
+# NAME error on require ""
+require ""
+EXPECT
+Missing or undefined argument to require at - line 1.
+########
+# NAME error on do undef
+do undef
+EXPECT
+Missing or undefined argument to do "file" at - line 1.
+########
+# NAME error on do ""
+do ""
+EXPECT
+Missing or undefined argument to do "file" at - line 1.
diff --git a/t/lib/warnings/pp_ctl b/t/lib/warnings/pp_ctl
index 9b3f298..2959fef 100644
--- a/t/lib/warnings/pp_ctl
+++ b/t/lib/warnings/pp_ctl
@@ -251,3 +251,16 @@ EXPECT
 use warnings;
 eval 'use 5.006; use 5.10.0';
 EXPECT
+########
+# NAME \0 in require/do arguments and @INC
+use warnings;
+eval 'require "a\0b";';
+eval 'do "a\0b"';
+push @INC, "a\0b";
+eval 'require "some-unknown-filename"';
+eval 'do "some-unknown-filename"';
+EXPECT
+Invalid \0 character in pathname for require: a\0b at (eval 1) line 1.
+Invalid \0 character in pathname for do "file": a\0b at (eval 2) line 1.
+Invalid \0 character in @INC entry for require: a\0b at (eval 3) line 1.
+Invalid \0 character in @INC entry for do "file": a\0b at (eval 4) line 1.
-- 
2.1.4

@p5pRT
Copy link
Author

p5pRT commented Sep 22, 2015

From @jkeenan

On Sun Sep 20 17​:13​:19 2015, tonyc wrote​:

Oops, updated patch.

+1. Smoking in branch smoke-me/jkeenan/126084-dofile.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 29, 2015

From @jkeenan

On Mon Sep 21 18​:28​:35 2015, jkeenan wrote​:

On Sun Sep 20 17​:13​:19 2015, tonyc wrote​:

Oops, updated patch.

+1. Smoking in branch smoke-me/jkeenan/126084-dofile.

Tony​: Smoke reports (mostly from your own smokers) can be found here​:

http​://perl.develop-help.com/?b=smoke-me%2Fjkeenan%2F126084-dofile

My sense is that there are no new test failures as a result of your patch -- just the usual suspects.

Shall we proceed to apply?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2018

From @jkeenan

On Tue, 29 Sep 2015 22​:09​:03 GMT, jkeenan wrote​:

On Mon Sep 21 18​:28​:35 2015, jkeenan wrote​:

On Sun Sep 20 17​:13​:19 2015, tonyc wrote​:

Oops, updated patch.

+1. Smoking in branch smoke-me/jkeenan/126084-dofile.

Tony​: Smoke reports (mostly from your own smokers) can be found here​:

http​://perl.develop-help.com/?b=smoke-me%2Fjkeenan%2F126084-dofile

My sense is that there are no new test failures as a result of your
patch -- just the usual suspects.

Shall we proceed to apply?

Thank you very much.

Though this branch got smoked, it was never applied to blead and the ticket remains unresolved.

TonyC, can you take a look?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2018

From @tonycoz

On Thu, 20 Sep 2018 16​:30​:16 -0700, jkeenan wrote​:

Though this branch got smoked, it was never applied to blead and the
ticket remains unresolved.

TonyC, can you take a look?

This was fixed by 33fe195.

Since it was previously fixed I'm resolving it instead of marking it pending release.

Tony

@p5pRT p5pRT closed this as completed Sep 20, 2018
@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2018

@tonycoz - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant