Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest::SHA#addfile($filename) doesn't output correct hash on Windows #14909

Closed
p5pRT opened this issue Sep 15, 2015 · 6 comments
Closed

Digest::SHA#addfile($filename) doesn't output correct hash on Windows #14909

p5pRT opened this issue Sep 15, 2015 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Sep 15, 2015

Migrated from rt.perl.org#126062 (status was 'rejected')

Searchable as RT126062$

@p5pRT
Copy link
Author

p5pRT commented Sep 15, 2015

From ntysdd@gmail.com

Perl version : 5.22.0 / MSWin32-x64-multi-thread

The filehandle version works provided opened in binary mode.

@p5pRT
Copy link
Author

p5pRT commented Sep 16, 2015

From @jkeenan

On Tue Sep 15 11​:15​:54 2015, ntysdd@​gmail.com wrote​:

Perl version : 5.22.0 / MSWin32-x64-multi-thread

The filehandle version works provided opened in binary mode.

An example would be helpful to spur the discussion.

Can you provide one?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 16, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Sep 16, 2015

From @tonycoz

On Tue Sep 15 11​:15​:54 2015, ntysdd@​gmail.com wrote​:

Perl version : 5.22.0 / MSWin32-x64-multi-thread

The filehandle version works provided opened in binary mode.

Digest​::SHA isn't maintained by perl5-porters.

This should be reported to the module author via rt.cpan.org.

Note that the documentation for addfile() describes a mode parameter, which can include "b" to read the file in binary mode​:

  $state->addfile($filename, "b");

Tony

@p5pRT
Copy link
Author

p5pRT commented Oct 21, 2015

From @tonycoz

On Tue Sep 15 21​:08​:13 2015, tonyc wrote​:

On Tue Sep 15 11​:15​:54 2015, ntysdd@​gmail.com wrote​:

Perl version : 5.22.0 / MSWin32-x64-multi-thread

The filehandle version works provided opened in binary mode.

Digest​::SHA isn't maintained by perl5-porters.

This should be reported to the module author via rt.cpan.org.

Note that the documentation for addfile() describes a mode parameter,
which can include "b" to read the file in binary mode​:

$state->addfile($filename, "b");

It isn't a p5p issue, and there's been no further discussion, so closing.

Tony

@p5pRT p5pRT closed this as completed Oct 21, 2015
@p5pRT
Copy link
Author

p5pRT commented Oct 21, 2015

@tonycoz - Status changed from 'open' to 'rejected'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant