Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] move Time-HiRes to /dist #14853

Closed
p5pRT opened this issue Aug 13, 2015 · 10 comments
Closed

[PATCH] move Time-HiRes to /dist #14853

p5pRT opened this issue Aug 13, 2015 · 10 comments
Labels
distro-mswin32 type-core

Comments

@p5pRT
Copy link

p5pRT commented Aug 13, 2015

Migrated from rt.perl.org#125807 (status was 'resolved')

Searchable as RT125807$
@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2015

From @bulk88

Created by @bulk88

See attached patch. I cant see any public communications about the perms
change, but they happened in PAUSE as of today (maybe they happened
earlier this week, IDK), so Time​::HiRes is P5P upstream now, so move it
to dist. I've never done this before so IDK if I made any mistakes in
the patch. Future commits/patches will start patching Time​::HiRes with
improvements.

Perl Info 

Flags:
         category=core
         severity=low

Site configuration information for perl 5.23.0:

Configured by Owner at Mon Jun 29 03:16:56 2015.

Summary of my perl5 (revision 5 version 23 subversion 0) configuration:
       Derived from: 63602a3fc27a417daf3c532b6a11ae6eba2a072a
       Platform:
         osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread
         uname=''
         config_args='undef'
         hint=recommended, useposix=true, d_sigaction=undef
         useithreads=define, usemultiplicity=define
         use64bitint=undef, use64bitall=undef, uselongdouble=undef
         usemymalloc=n, bincompat5005=undef
       Compiler:
         cc='cl', ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL -DWIN32
-D_CONSOLE -DNO_STRICT  -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT
-DPERL_IMPLICIT_SYS -D_USE_32BIT_TIME_T',
         optimize='-O1 -MD -Zi -DNDEBUG -GL',
         cppflags='-DWIN32'
         ccversion='13.10.6030', gccversion='', gccosandvers=''
         intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234,
doublekind=3
         d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8,
longdblkind=0
         ivtype='long', ivsize=4, nvtype='double', nvsize=8,
Off_t='__int64', lseeksize=8
         alignbytes=8, prototype=define
       Linker and Libraries:
         ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf
-ltcg 		-libpath:"c:\perl\lib\CORE" 		-machine:x86'
         libpth=\lib
         libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
         perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib
oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
         libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl523.lib
         gnulibc_version=''
       Dynamic Linking:
         dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
         cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug
-opt:ref,icf -ltcg 		-libpath:"c:\perl\lib\CORE" 		-machine:x86'

Locally applied patches:
         uncommitted-changes


@INC for perl 5.23.0:
         C:/perl521/srcnewb4opt/lib
         .


Environment for perl 5.23.0:
         HOME (unset)
         LANG (unset)
         LANGUAGE (unset)
         LD_LIBRARY_PATH (unset)
         LOGDIR (unset)
         PATH=C:\sperl\c\bin;C:\WINDOWS\system32;C:\Program Files\Microsoft
Visual Studio .NET 2003\Vc7\bin;C:\Program Files\Microsoft Visual Studio
.NET 2003\Common7\IDE;C:\WINDOWS;C:\Program Files\Git\cmd;C:\Program
Files\Microsoft Visual Studio .NET 2003\Common7\Tools\bin;C:\perl\bin
         PERL_BADLANG (unset)
         PERL_JSON_BACKEND=Cpanel::JSON::XS
         PERL_YAML_BACKEND=YAML
         SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Aug 13, 2015

From @bulk88

0001-move-Time-HiRes-to-dist.patch

@p5pRT
Copy link
Author

p5pRT commented Aug 17, 2015

From @tonycoz

On Thu Aug 13 16​:32​:24 2015, bulk88 wrote​:

See attached patch. I cant see any public communications about the perms
change, but they happened in PAUSE as of today (maybe they happened
earlier this week, IDK), so Time​::HiRes is P5P upstream now, so move it
to dist. I've never done this before so IDK if I made any mistakes in
the patch. Future commits/patches will start patching Time​::HiRes with
improvements.

Based on the discussion in #p5p, Time-HiRes isn't moving to blead upstream.

So rejecting.

Tony

@p5pRT
Copy link
Author

p5pRT commented Aug 17, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 17, 2015

@tonycoz - Status changed from 'open' to 'rejected'

@p5pRT
Copy link
Author

p5pRT commented Feb 9, 2016

@khwilliamson - Status changed from 'rejected' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Feb 9, 2016

From @khwilliamson

Further consideration indicated that this should be done, and commit
91ba54d
did it

--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Feb 9, 2016

@khwilliamson - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.
 
With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

@khwilliamson - Status changed from 'pending release' to 'resolved'

@p5pRT p5pRT closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-mswin32 type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT