New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] add warnings 7fatal testcase for #123398 #14670
Comments
From @rurbanThis is a bug report for perl from rurban@cpanel.net, From 09488421cf4af21111fabf99d97ddfa984c5e26d Mon Sep 17 00:00:00 2001 t/lib/warnings/7fatal | 18 ++++++++++++++++++ Inline Patchdiff --git t/lib/warnings/7fatal t/lib/warnings/7fatal
index 87f3fd0..40c649f 100644
--- t/lib/warnings/7fatal
+++ t/lib/warnings/7fatal
@@ -548,3 +548,21 @@ syntax error at - line 4, near "1 {"
"my" variable $x masks earlier declaration in same statement at - line 6.
syntax error at - line 7, near "}"
Execution of - aborted due to compilation errors.
+########
+
+# fatal warnings in DESTROY should be made non-fatal [perl #123398]
+# This test will blow up your memory with SEGV without the patch
+package Foo;
+use strict; use utf8; use warnings FATAL => 'all';
+sub new {
+ return bless{ 'field' => undef }, 'Foo';
+}
+sub DESTROY {
+ my $self = shift;
+ $self->{'field'}->missing_method;
+}
+package main;
+my $foo = new Foo;
+undef($foo);
+EXPECT
+ (in cleanup) Can't call method "missing_method" on an undefined value at - line 11.
--
Flags: Site configuration information for perl 5.21.9: Configured by rurban at Mon Feb 16 13:23:45 CET 2015. Summary of my perl5 (revision 5 version 21 subversion 9) configuration: @INC for perl 5.21.9: Environment for perl 5.21.9: |
From @tonycozOn Thu Apr 23 04:07:29 2015, rurban@cpanel.net wrote:
Thanks, applied as 04ac80c41ac62f54dd26df5f70955181c2a2349b. Tony |
The RT System itself - Status changed from 'new' to 'open' |
@tonycoz - Status changed from 'open' to 'pending release' |
From @tonycozOn Mon Jun 08 22:26:11 2015, tonyc wrote:
I missed pushing it, so it ended up as 4221d7c. Tony |
From @khwilliamsonThank you for submitting this report. You have helped make Perl better. Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0 |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#124370 (status was 'resolved')
Searchable as RT124370$
The text was updated successfully, but these errors were encountered: