Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Parentheses missing around "my" list' shouldn't trigger for globs #14645

Closed
p5pRT opened this issue Apr 10, 2015 · 5 comments
Closed

'Parentheses missing around "my" list' shouldn't trigger for globs #14645

p5pRT opened this issue Apr 10, 2015 · 5 comments
Labels
distro-Linux type-core

Comments

@p5pRT
Copy link

p5pRT commented Apr 10, 2015

Migrated from rt.perl.org#124280 (status was 'resolved')

Searchable as RT124280$
@p5pRT
Copy link
Author

p5pRT commented Apr 10, 2015

From @mauke

Created by @mauke

$ perl -wce 'our $bar = sub { my $foo, *bar; }'
Parentheses missing around "my" list at -e line 1.
-e syntax OK

This warning ("Parentheses missing around X list") is triggered by some rather
questionable heuristics applied to the lexer buffer. What makes no sense to me
is that typeglobs (*bar) are included in the list of variable types to warn
about. I don't think they should be, because 'my *bar' or 'our *bar' are syntax
errors (you can't declare globs).

Perl Info 

Flags:
    category=core
    severity=low

Site configuration information for perl 5.20.2:

Configured by mauke at Fri Feb 20 22:08:22 CET 2015.

Summary of my perl5 (revision 5 version 20 subversion 2) configuration:
   
  Platform:
    osname=linux, osvers=3.18.3-1-arch, archname=i686-linux
    uname='linux simplicio 3.18.3-1-arch #1 smp preempt sun jan 18 17:33:37 cet 2015 i686 gnulinux '
    config_args=''
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.9.2 20150204 (prerelease)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags ='-fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/i686-pc-linux-gnu/4.9.2/include-fixed /usr/lib /lib
    libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.21.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.21'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'



@INC for perl 5.20.2:
    /home/mauke/usr/lib/perl5/site_perl/5.20.2/i686-linux
    /home/mauke/usr/lib/perl5/site_perl/5.20.2
    /home/mauke/usr/lib/perl5/5.20.2/i686-linux
    /home/mauke/usr/lib/perl5/5.20.2
    .


Environment for perl 5.20.2:
    HOME=/home/mauke
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LC_COLLATE=POSIX
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/mauke/perl5/perlbrew/bin:/home/mauke/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
    PERLBREW_BASHRC_VERSION=0.69
    PERLBREW_HOME=/home/mauke/.perlbrew
    PERLBREW_ROOT=/home/mauke/perl5/perlbrew
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Nov 21, 2015

From @mauke

On Fri Apr 10 13​:28​:35 2015, mauke- wrote​:

$ perl -wce 'our $bar = sub { my $foo, *bar; }'
Parentheses missing around "my" list at -e line 1.
-e syntax OK

This warning ("Parentheses missing around X list") is triggered by
some rather
questionable heuristics applied to the lexer buffer. What makes no
sense to me
is that typeglobs (*bar) are included in the list of variable types to
warn
about. I don't think they should be, because 'my *bar' or 'our *bar'
are syntax
errors (you can't declare globs).

They are there because this warning also applies to 'local', and 'local *foo, *bar' should indeed be 'local(*foo, *bar)' (probably).

Fixed in blead by 4639a3a.

@p5pRT
Copy link
Author

p5pRT commented Nov 23, 2015

@mauke - Status changed from 'new' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.
 
With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

@khwilliamson - Status changed from 'pending release' to 'resolved'

@p5pRT p5pRT closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-Linux type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT