Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] remove obsolete VOL in S_parse_body #14622

Closed
p5pRT opened this issue Mar 27, 2015 · 8 comments
Closed

[PATCH] remove obsolete VOL in S_parse_body #14622

p5pRT opened this issue Mar 27, 2015 · 8 comments
Labels
distro-mswin32 type-core

Comments

@p5pRT
Copy link

p5pRT commented Mar 27, 2015

Migrated from rt.perl.org#124188 (status was 'resolved')

Searchable as RT124188$
@p5pRT
Copy link
Author

p5pRT commented Mar 27, 2015

From @bulk88

Created by @bulk88

See attached patch.

Perl Info 

Flags:
                  category=core
                  severity=low

Site configuration information for perl 5.21.4:

Configured by Owner at Thu Sep 18 12:08:58 2014.

Summary of my perl5 (revision 5 version 21 subversion 4) configuration:
                Derived from: 7d2b2edb94ab56333b9049a3e26d15ea18445512
                Ancestor: 19be3be6968e2337bcdfe480693fff795ecd1304
                Platform:
                  osname=MSWin32, osvers=5.1,
archname=MSWin32-x86-multi-thread
                  uname=''
                  config_args='undef'
                  hint=recommended, useposix=true, d_sigaction=undef
                  useithreads=define, usemultiplicity=define
                  use64bitint=undef, use64bitall=undef, uselongdouble=undef
                  usemymalloc=n, bincompat5005=undef
                Compiler:
                  cc='cl', ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG
-DWIN32
-D_CONSOLE -DNO_STRICT  -DPERL_TEXTMODE_SCRIPTS
-DPERL_HASH_FUNC_ONE_AT_A_TIME -DPERL_IMPLICIT_CONTEXT
-DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T',
                  optimize='-O1 -MD -Zi -DNDEBUG',
                  cppflags='-DWIN32'
                  ccversion='12.00.8168', gccversion='', gccosandvers=''
                  intsize=4, longsize=4, ptrsize=4, doublesize=8,
byteorder=1234
                  d_longlong=undef, longlongsize=8, d_longdbl=define,
longdblsize=8,
longdblkind=0
                  ivtype='long', ivsize=4, nvtype='double', nvsize=8,
Off_t='__int64',
lseeksize=8
                  alignbytes=8, prototype=define
                Linker and Libraries:
                  ld='link', ldflags ='-nologo -nodefaultlib -debug
-opt:ref,icf
-libpath:"c:\perl521\lib\CORE"  -machine:x86'
                  libpth=C:\PROGRA~1\MIAF9D~1\VC98\lib
                  libs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
                  perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib
oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
                  libc=msvcrt.lib, so=dll, useshrplib=true,
libperl=perl521.lib
                  gnulibc_version=''
                Dynamic Linking:
                  dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef,
ccdlflags=' '
                  cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib
-debug
-opt:ref,icf  -libpath:"c:\perl521\lib\CORE"  -machine:x86'

Locally applied patches:
                  uncommitted-changes
                  a0fe7a7e75de29e59f1da0d6822dc06e5be658fe
                  a261faffee83d0145642ab5d1d046c9f813bc497
                  6506ab86ad1602a9ca720fcd30446dce1461d23d
                  7d2b2edb94ab56333b9049a3e26d15ea18445512


@INC for perl 5.21.4:
                  lib
                  C:/perl521/srcnew/lib
                  .


Environment for perl 5.21.4:
                  HOME (unset)
                  LANG (unset)
                  LANGUAGE (unset)
                  LD_LIBRARY_PATH (unset)
                  LOGDIR (unset)
                  PATH=
                  PERL_BADLANG (unset)
                  PERL_JSON_BACKEND=Cpanel::JSON::XS
                  PERL_YAML_BACKEND=YAML
                  SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Mar 27, 2015

From @bulk88

0001-remove-obsolete-VOL-in-S_parse_body.patch 
From ac9d0208272f135052713bf34b11c5b88a407cfb Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Fri, 27 Mar 2015 03:02:58 -0400
Subject: [PATCH] remove obsolete VOL in S_parse_body

commit 312caa8e97 removed dJMPENV from perl_parse_body (former perl_parse)
when it created perl_parse_body and perl_parse kept the dJMPENV, but this
commit forgot to remove the VOL tag on var dosearch. Since the VOL is
only required when the function has a setjmp in it, and this function
doesn't have a setjmp in it anymore, remove the VOL tag.
---
 perl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/perl.c b/perl.c
index 69c85c8..07cb421 100644
--- a/perl.c
+++ b/perl.c
@@ -1833,7 +1833,7 @@ S_parse_body(pTHX_ char **env, XSINIT_t xsinit)
     int argc = PL_origargc;
     char **argv = PL_origargv;
     const char *scriptname = NULL;
-    VOL bool dosearch = FALSE;
+    bool dosearch = FALSE;
     char c;
     bool doextract = FALSE;
     const char *cddir = NULL;
-- 
1.7.9.msysgit.0

@p5pRT
Copy link
Author

p5pRT commented Jun 2, 2015

From @tonycoz

On Fri Mar 27 00​:05​:41 2015, bulk88 wrote​:

See attached patch.

Thanks, applied as 402582c.

Tony

@p5pRT
Copy link
Author

p5pRT commented Jun 2, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 2, 2015

@tonycoz - Status changed from 'open' to 'resolved'

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2015

@tonycoz - Status changed from 'resolved' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

From @khwilliamson

Thank you for submitting this report. You have helped make Perl better.
 
With the release of Perl 5.24.0 on May 9, 2016, this and 149 other issues have been resolved.

Perl 5.24.0 may be downloaded via https://metacpan.org/release/RJBS/perl-5.24.0

@p5pRT
Copy link
Author

p5pRT commented May 13, 2016

@khwilliamson - Status changed from 'pending release' to 'resolved'

@p5pRT p5pRT closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-mswin32 type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT