Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.21.6-135-g6d59e61 breaks SMUELLER/Math-Histogram-1.03.tar.gz #14617

Closed
p5pRT opened this issue Mar 24, 2015 · 6 comments
Closed

Comments

@p5pRT
Copy link

p5pRT commented Mar 24, 2015

Migrated from rt.perl.org#124164 (status was 'rejected')

Searchable as RT124164$

@p5pRT
Copy link
Author

p5pRT commented Mar 24, 2015

From @andk

Another one from Slaven...

bisect


commit 6d59e61
Author​: Lukas Mai <l.mai@​web.de>
Date​: Sat Nov 29 12​:17​:05 2014 +0100

  define and use STATIC_ASSERT_STMT for compile-time invariants

rt cross reference


https://rt.cpan.org/Ticket/Display.html?id=103035

perl -V


Summary of my perl5 (revision 5 version 21 subversion 7) configuration​:
  Commit id​: 6d59e61
  Platform​:
  osname=linux, osvers=3.16.0-4-amd64, archname=x86_64-linux-thread-multi
  uname='linux k83 3.16.0-4-amd64 #1 smp debian 3.16.7-ckt7-1 (2015-03-01) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.21.6-135-g6d59e61/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion='', gccversion='4.9.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_ITHREADS USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO
  USE_PERL_ATOF USE_REENTRANT_API
  Built under linux
  Compiled at Mar 24 2015 02​:50​:14
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.6-135-g6d59e61/9980/lib/site_perl/5.21.7/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.6-135-g6d59e61/9980/lib/site_perl/5.21.7
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.6-135-g6d59e61/9980/lib/5.21.7/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.6-135-g6d59e61/9980/lib/5.21.7
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Mar 27, 2015

From @cpansprout

On Mon Mar 23 19​:11​:52 2015, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Another one from Slaven...

bisect
------
commit 6d59e61
Author​: Lukas Mai <l.mai@​web.de>
Date​: Sat Nov 29 12​:17​:05 2014 +0100

define and use STATIC_ASSERT_STMT for compile-time invariants

I don’t get test failures on a Mac.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Mar 27, 2015

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2015

From @tonycoz

On Fri Mar 27 15​:00​:57 2015, sprout wrote​:

On Mon Mar 23 19​:11​:52 2015, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

Another one from Slaven...

bisect
------
commit 6d59e61
Author​: Lukas Mai <l.mai@​web.de>
Date​: Sat Nov 29 12​:17​:05 2014 +0100

define and use STATIC_ASSERT_STMT for compile-time invariants

I don’t get test failures on a Mac.

It only happens for non-debugging builds.

The relevant part of the change is that NDEBUG is now defined for non-DEBUGGING builds.

Histogram.xs includes the following​:

  #include "assert.h"

  ...

  if (MH_AXIS_ISFIXBIN(axis)) {
  assert( hv_stores(hash, "nbins", newSVuv(MH_AXIS_NBINS(axis))) );
  assert( hv_stores(hash, "min", newSVnv(MH_AXIS_MIN(axis))) );
  assert( hv_stores(hash, "max", newSVnv(MH_AXIS_MAX(axis))) );
  }

Previously for non-DEBUGGING builds, this resulted in those assertions being treated
as assertions and the hv_stores() being executed.

Now, since we define NDEBUG the system assert.h defines to *not* executing the supplied
parameter.

Tony

@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2015

From @tsee

This is a bug in my module. I've released a fixed version. Not a bug in Perl (and I'm closing this as rejected accordingly).

Sorry about that, guys!

@p5pRT p5pRT closed this as completed Apr 7, 2015
@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2015

@tsee - Status changed from 'open' to 'rejected'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant