New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blead's EUMM always fails tests on Win32 Perl on Win64 #14566
Comments
From natti2121@outlook.comCreated by @bulk88This is a 5.22 blocker so please link it to the 5.22 blocker ticket. The ExtUtils::MakeMaker that is included with Perl 5.21.9 fails tests This was reported and fixed a while ago in examples from "nmake test" ../lib/warnings.t .................................................. ok Test Summary Report C:\p521\219src\win32> Test Summary Report Failed tests: 19, 25 C:\p521\219src\t> # Failed test 'prereqs dumped' # Failed test ' without error' # Failed test 'prereqs dumped' Test Summary Report C:\p521\219src\t> Perl Info
|
From @bulk88Created by @bulk88This is a 5.22 blocker so please link it to the 5.22 blocker ticket. The ExtUtils::MakeMaker that is included with Perl 5.21.9 fails tests This was reported and fixed a while ago in examples from "nmake test" ../lib/warnings.t .................................................. ok Test Summary Report C:\p521\219src\win32> Test Summary Report Failed tests: 19, 25 C:\p521\219src\t> # Failed test 'prereqs dumped' # Failed test ' without error' # Failed test 'prereqs dumped' Test Summary Report C:\p521\219src\t> Perl Info
|
From @jkeenanAppears to be a duplicate of RT #123998; merging. |
From @bulk88The failure list has grown in the last month or so, previously ../cpan/ExtUtils-MakeMaker/t/prereq_print.t and ../cpan/ExtUtils-MakeMaker/t/min_perl_version.t failed, now t/porting/utils.t is also failing. IDK what exactly changed. C:\p521\srcpara>perl t/porting/utils.t C:\p521\srcpara> The chcp warning comes from whenever "use ExtUtils::MakeMaker;" executes. C:\p521\srcpara>perl -MExtUtils::MakeMaker -E"0" C:\p521\srcpara> -- |
From @tonycozOn Thu Mar 05 18:51:22 2015, natti2121@outlook.com wrote:
The tests pass for me on x64 Win 7 with a 32-bit build: J:\dev\perl\git\perl\win32>nmake test TEST_FILES="porting\utils.t ..\cpan\ExtUtils-MakeMaker\t\*.t" J:\dev\perl\git\perl\win32>dumpbin /headers ..\t\perl.exe | find "machine" Tony |
The RT System itself - Status changed from 'new' to 'open' |
From @sisyphus-----Original Message-----
They pass for me on x64 Win 7 (both 32-bit and 64-bit builds) - but only if If I remove ".COM" from the PATHEXT env var, then the failures occur. I don't know why chcp.com would not be locatable on some systems. (Does it Cheers, |
From @tonycozOn Thu Apr 09 18:22:38 2015, tonyc wrote:
In any case, here's a backport patch of the change in EU::MM. Tony |
From @tonycoz0001-perl-123998-backport-cda0edd5-from-EU-MM-upstream.patchFrom 992184367a28c2733d86166a2dfef4ac62d8760e Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop-help.com>
Date: Fri, 10 Apr 2015 15:01:48 +1000
Subject: [PATCH] [perl #123998] backport cda0edd5 from EU::MM upstream
EU::MM upstream doesn't have a stable release with this fix, and
such a release would include many other unrelated changes, late in
the perl release process.
Instead, just backport the specific fix, along with all the version
bumps needed to make it obviously *not* EU:MM 7.04.
---
Porting/Maintainers.pl | 26 ++++++++++++++++-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist.pm | 2 +-
.../ExtUtils-MakeMaker/lib/ExtUtils/Liblist/Kid.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_AIX.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Any.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_BeOS.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Cygwin.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_DOS.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Darwin.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_MacOS.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_NW5.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_OS2.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_QNX.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_UWIN.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Unix.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VMS.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VOS.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win32.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win95.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MY.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm | 2 +-
.../lib/ExtUtils/MakeMaker/Config.pm | 2 +-
.../lib/ExtUtils/MakeMaker/FAQ.pod | 2 +-
.../lib/ExtUtils/MakeMaker/Locale.pm | 2 +-
.../lib/ExtUtils/MakeMaker/Tutorial.pod | 2 +-
.../lib/ExtUtils/MakeMaker/version.pm | 2 +-
.../lib/ExtUtils/MakeMaker/version/regex.pm | 2 +-
.../lib/ExtUtils/MakeMaker/version/vpp.pm | 2 +-
.../ExtUtils-MakeMaker/lib/ExtUtils/Mkbootstrap.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mksymlists.pm | 2 +-
cpan/ExtUtils-MakeMaker/lib/ExtUtils/testlib.pm | 2 +-
cpan/ExtUtils-MakeMaker/t/min_perl_version.t | 3 +-
cpan/ExtUtils-MakeMaker/t/prereq_print.t | 3 +-
t/porting/customized.dat | 34 ++++++++++++++++++++++
36 files changed, 95 insertions(+), 35 deletions(-)
diff --git a/Porting/Maintainers.pl b/Porting/Maintainers.pl
index 39bbd61..8220ab6 100755
--- a/Porting/Maintainers.pl
+++ b/Porting/Maintainers.pl
@@ -476,7 +476,31 @@ use File::Glob qw(:case);
'README.packaging',
],
# Applied upstream remove customisation when updating EUMM
- 'CUSTOMIZED' => [ qw[ t/pm_to_blib.t ] ],
+ 'CUSTOMIZED' => [
+ qw[ t/pm_to_blib.t ],
+ # chcp fixes
+ qw[ t/min_perl_version.t t/prereq_print.t ],
+ # version bumps
+ qw[ lib/ExtUtils/Command/MM.pm lib/ExtUtils/Liblist.pm
+ lib/ExtUtils/Liblist/Kid.pm lib/ExtUtils/MM.pm
+ lib/ExtUtils/MM_AIX.pm lib/ExtUtils/MM_Any.pm
+ lib/ExtUtils/MM_BeOS.pm lib/ExtUtils/MM_Cygwin.pm
+ lib/ExtUtils/MM_DOS.pm lib/ExtUtils/MM_Darwin.pm
+ lib/ExtUtils/MM_MacOS.pm lib/ExtUtils/MM_NW5.pm
+ lib/ExtUtils/MM_OS2.pm lib/ExtUtils/MM_QNX.pm
+ lib/ExtUtils/MM_UWIN.pm lib/ExtUtils/MM_Unix.pm
+ lib/ExtUtils/MM_VMS.pm lib/ExtUtils/MM_VOS.pm
+ lib/ExtUtils/MM_Win32.pm lib/ExtUtils/MM_Win95.pm
+ lib/ExtUtils/MY.pm lib/ExtUtils/MakeMaker.pm
+ lib/ExtUtils/MakeMaker/Config.pm lib/ExtUtils/MakeMaker/FAQ.pod
+ lib/ExtUtils/MakeMaker/Locale.pm
+ lib/ExtUtils/MakeMaker/Tutorial.pod
+ lib/ExtUtils/MakeMaker/version.pm
+ lib/ExtUtils/MakeMaker/version/regex.pm
+ lib/ExtUtils/MakeMaker/version/vpp.pm
+ lib/ExtUtils/Mkbootstrap.pm lib/ExtUtils/Mksymlists.pm
+ lib/ExtUtils/testlib.pm ],
+ ],
},
'ExtUtils::Manifest' => {
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm
index 41f5478..203b3aa 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm
@@ -10,7 +10,7 @@ our @ISA = qw(Exporter);
our @EXPORT = qw(test_harness pod2man perllocal_install uninstall
warn_if_old_packlist test_s cp_nonempty);
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
my $Is_VMS = $^O eq 'VMS';
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist.pm
index 85ebbf5..3df1793 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist.pm
@@ -2,7 +2,7 @@ package ExtUtils::Liblist;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
use File::Spec;
require ExtUtils::Liblist::Kid;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist/Kid.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist/Kid.pm
index 41f07c2..37bcfd4 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist/Kid.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist/Kid.pm
@@ -11,7 +11,7 @@ use 5.006;
use strict;
use warnings;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
use ExtUtils::MakeMaker::Config;
use Cwd 'cwd';
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM.pm
index 0e0770c..f2aa8b4 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM.pm
@@ -3,7 +3,7 @@ package ExtUtils::MM;
use strict;
use ExtUtils::MakeMaker::Config;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::Liblist;
require ExtUtils::MakeMaker;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_AIX.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_AIX.pm
index 211c5af..58ea5b9 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_AIX.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_AIX.pm
@@ -1,7 +1,7 @@
package ExtUtils::MM_AIX;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Unix;
our @ISA = qw(ExtUtils::MM_Unix);
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Any.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Any.pm
index af4c9ca..4c00129 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Any.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Any.pm
@@ -1,7 +1,7 @@
package ExtUtils::MM_Any;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
use Carp;
use File::Spec;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_BeOS.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_BeOS.pm
index f5c4e18..35b76c0 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_BeOS.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_BeOS.pm
@@ -26,7 +26,7 @@ require ExtUtils::MM_Any;
require ExtUtils::MM_Unix;
our @ISA = qw( ExtUtils::MM_Any ExtUtils::MM_Unix );
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
=item os_flavor
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Cygwin.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Cygwin.pm
index de98b1b..b504c47 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Cygwin.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Cygwin.pm
@@ -9,7 +9,7 @@ require ExtUtils::MM_Unix;
require ExtUtils::MM_Win32;
our @ISA = qw( ExtUtils::MM_Unix );
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
=head1 NAME
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_DOS.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_DOS.pm
index b227e2d..353c54f 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_DOS.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_DOS.pm
@@ -2,7 +2,7 @@ package ExtUtils::MM_DOS;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Any;
require ExtUtils::MM_Unix;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Darwin.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Darwin.pm
index 247a836..315d1b4 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Darwin.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Darwin.pm
@@ -7,7 +7,7 @@ BEGIN {
our @ISA = qw( ExtUtils::MM_Unix );
}
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
=head1 NAME
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_MacOS.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_MacOS.pm
index 973e2e3..bef2c00 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_MacOS.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_MacOS.pm
@@ -2,7 +2,7 @@ package ExtUtils::MM_MacOS;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
sub new {
die 'MacOS Classic (MacPerl) is no longer supported by MakeMaker';
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_NW5.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_NW5.pm
index 7d283d9..4e36796 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_NW5.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_NW5.pm
@@ -22,7 +22,7 @@ use strict;
use ExtUtils::MakeMaker::Config;
use File::Basename;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Win32;
our @ISA = qw(ExtUtils::MM_Win32);
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_OS2.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_OS2.pm
index cd40832..c9ace00 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_OS2.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_OS2.pm
@@ -5,7 +5,7 @@ use strict;
use ExtUtils::MakeMaker qw(neatvalue);
use File::Spec;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Any;
require ExtUtils::MM_Unix;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_QNX.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_QNX.pm
index 374180e..13e12c4 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_QNX.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_QNX.pm
@@ -1,7 +1,7 @@
package ExtUtils::MM_QNX;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Unix;
our @ISA = qw(ExtUtils::MM_Unix);
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_UWIN.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_UWIN.pm
index 569bdee..4af2909 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_UWIN.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_UWIN.pm
@@ -1,7 +1,7 @@
package ExtUtils::MM_UWIN;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Unix;
our @ISA = qw(ExtUtils::MM_Unix);
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Unix.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Unix.pm
index 4ec32a3..f63145c 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Unix.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Unix.pm
@@ -15,7 +15,7 @@ use ExtUtils::MakeMaker qw($Verbose neatvalue);
# If we make $VERSION an our variable parse_version() breaks
use vars qw($VERSION);
-$VERSION = '7.04';
+$VERSION = '7.04_01';
$VERSION = eval $VERSION; ## no critic [BuiltinFunctions::ProhibitStringyEval]
require ExtUtils::MM_Any;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VMS.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VMS.pm
index ed27ced..45d06b0 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VMS.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VMS.pm
@@ -15,7 +15,7 @@ BEGIN {
use File::Basename;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Any;
require ExtUtils::MM_Unix;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VOS.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VOS.pm
index 634a966..dfec6d5 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VOS.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VOS.pm
@@ -1,7 +1,7 @@
package ExtUtils::MM_VOS;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Unix;
our @ISA = qw(ExtUtils::MM_Unix);
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win32.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win32.pm
index 8e7da6a..fbd3f49 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win32.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win32.pm
@@ -27,7 +27,7 @@ use ExtUtils::MakeMaker qw( neatvalue );
require ExtUtils::MM_Any;
require ExtUtils::MM_Unix;
our @ISA = qw( ExtUtils::MM_Any ExtUtils::MM_Unix );
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
$ENV{EMXSHELL} = 'sh'; # to run `commands`
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win95.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win95.pm
index 20f1590..cc37c24 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win95.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win95.pm
@@ -2,7 +2,7 @@ package ExtUtils::MM_Win95;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require ExtUtils::MM_Win32;
our @ISA = qw(ExtUtils::MM_Win32);
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MY.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MY.pm
index 54c1129..f2114f9 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MY.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MY.pm
@@ -3,7 +3,7 @@ package ExtUtils::MY;
use strict;
require ExtUtils::MM;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
our @ISA = qw(ExtUtils::MM);
{
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm
index df5acdf..fe95b27 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm
@@ -24,7 +24,7 @@ my %Recognized_Att_Keys;
our %macro_fsentity; # whether a macro is a filesystem name
our %macro_dep; # whether a macro is a dependency
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
$VERSION = eval $VERSION; ## no critic [BuiltinFunctions::ProhibitStringyEval]
# Emulate something resembling CVS $Revision$
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Config.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Config.pm
index 13d75ea..9001cc6 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Config.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Config.pm
@@ -2,7 +2,7 @@ package ExtUtils::MakeMaker::Config;
use strict;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
use Config ();
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/FAQ.pod b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/FAQ.pod
index 11b8883..d2b4ab3 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/FAQ.pod
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/FAQ.pod
@@ -1,6 +1,6 @@
package ExtUtils::MakeMaker::FAQ;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
1;
__END__
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm
index f6edcf2..be78eb2 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm
@@ -1,7 +1,7 @@
package ExtUtils::MakeMaker::Locale;
use strict;
-our $VERSION = "7.04";
+our $VERSION = "7.04_01";
use base 'Exporter';
our @EXPORT_OK = qw(
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Tutorial.pod b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Tutorial.pod
index dd636bd..9cbdd9b 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Tutorial.pod
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Tutorial.pod
@@ -1,6 +1,6 @@
package ExtUtils::MakeMaker::Tutorial;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
=head1 NAME
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version.pm
index 8b18042..3269f44 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version.pm
@@ -15,7 +15,7 @@ use strict;
use vars qw(@ISA $VERSION $CLASS $STRICT $LAX *declare *qv);
-$VERSION = '7.04';
+$VERSION = '7.04_01';
$CLASS = 'version';
{
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/regex.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/regex.pm
index e125d38..a134a00 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/regex.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/regex.pm
@@ -10,7 +10,7 @@ use strict;
use vars qw($VERSION $CLASS $STRICT $LAX);
-$VERSION = '7.04';
+$VERSION = '7.04_01';
#--------------------------------------------------------------------------#
# Version regexp components
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/vpp.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/vpp.pm
index 68376ba..34bbd01 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/vpp.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/vpp.pm
@@ -128,7 +128,7 @@ use strict;
use Config;
use vars qw($VERSION $CLASS @ISA $LAX $STRICT);
-$VERSION = '7.04';
+$VERSION = '7.04_01';
$CLASS = 'ExtUtils::MakeMaker::version::vpp';
require ExtUtils::MakeMaker::version::regex;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mkbootstrap.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mkbootstrap.pm
index 4177723..97d4300 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mkbootstrap.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mkbootstrap.pm
@@ -3,7 +3,7 @@ package ExtUtils::Mkbootstrap;
# There's just too much Dynaloader incest here to turn on strict vars.
use strict 'refs';
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
require Exporter;
our @ISA = ('Exporter');
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mksymlists.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mksymlists.pm
index 2eb8bf4..3a9fc71 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mksymlists.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mksymlists.pm
@@ -10,7 +10,7 @@ use Config;
our @ISA = qw(Exporter);
our @EXPORT = qw(&Mksymlists);
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
sub Mksymlists {
my(%spec) = @_;
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/testlib.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/testlib.pm
index f48dfa4..2a5323e 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/testlib.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/testlib.pm
@@ -3,7 +3,7 @@ package ExtUtils::testlib;
use strict;
use warnings;
-our $VERSION = '7.04';
+our $VERSION = '7.04_01';
use Cwd;
use File::Spec;
diff --git a/cpan/ExtUtils-MakeMaker/t/min_perl_version.t b/cpan/ExtUtils-MakeMaker/t/min_perl_version.t
index c5d78d6..6abd4f1 100644
--- a/cpan/ExtUtils-MakeMaker/t/min_perl_version.t
+++ b/cpan/ExtUtils-MakeMaker/t/min_perl_version.t
@@ -138,6 +138,7 @@ END
note "PREREQ_PRINT output"; {
my $prereq_out = run(qq{$perl Makefile.PL "PREREQ_PRINT=1"});
is( $?, 0, 'PREREQ_PRINT exiting normally' );
+ $prereq_out =~ s/.*(\$PREREQ_PM\s*=)/$1/s; # strip off errors eg from chcp
my $prereq_out_sane = $prereq_out =~ /^\s*\$PREREQ_PM\s*=/;
ok( $prereq_out_sane, ' and talking like we expect' ) ||
diag($prereq_out);
@@ -164,7 +165,7 @@ note "PRINT_PREREQ output"; {
is( $?, 0, 'PRINT_PREREQ exiting normally' );
ok( $prereq_out !~ /^warning/i, ' and not complaining loudly' );
like( $prereq_out,
- qr/^perl\(perl\) \s* >= 5\.005 \s+ perl\(strict\) \s* >= \s* 0 \s*$/x,
+ qr/^perl\(perl\) \s* >= 5\.005 \s+ perl\(strict\) \s* >= \s* 0 \s*$/mx,
'dump has prereqs and perl version' );
}
diff --git a/cpan/ExtUtils-MakeMaker/t/prereq_print.t b/cpan/ExtUtils-MakeMaker/t/prereq_print.t
index b6e12ef..b70d735 100644
--- a/cpan/ExtUtils-MakeMaker/t/prereq_print.t
+++ b/cpan/ExtUtils-MakeMaker/t/prereq_print.t
@@ -48,6 +48,7 @@ unlink $Makefile;
my $prereq_out = run(qq{$Perl Makefile.PL "PREREQ_PRINT=1"});
ok( !-r $Makefile, "PREREQ_PRINT produces no $Makefile" );
is( $?, 0, ' exited normally' );
+$prereq_out =~ s/^'chcp' is not recognized.*batch file\.//s; # remove errors
{
package _Prereq::Print;
no strict;
@@ -61,7 +62,7 @@ is( $?, 0, ' exited normally' );
$prereq_out = run(qq{$Perl Makefile.PL "PRINT_PREREQ=1"});
ok( !-r $Makefile, "PRINT_PREREQ produces no $Makefile" );
is( $?, 0, ' exited normally' );
-::like( $prereq_out, qr/^perl\(strict\) \s* >= \s* 0 \s*$/x,
+::like( $prereq_out, qr/^perl\(strict\) \s* >= \s* 0 \s*$/mx,
'prereqs dumped' );
diff --git a/t/porting/customized.dat b/t/porting/customized.dat
index fa37838..d68cacd 100644
--- a/t/porting/customized.dat
+++ b/t/porting/customized.dat
@@ -1,4 +1,38 @@
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm 7f4dfd0fe884bd42412bcf04ca80ef97b39c1d54
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist.pm bef099988b15fb0b2a1f5ac48c01af1f7f36d329
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/Liblist/Kid.pm 8168e18f0e3ce3ece4bb7e7c72d57ec07c67c402
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm 7115e97a53559cb3ec061dd6f7f344e522724c4a
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Config.pm f8db8d4245bf0684b8210c811f50d7cfb1a27d78
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/FAQ.pod 757bffb47857521311f8f3bde43ebe165f8d5191
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm eb7f7c39720aea85f6443109f8d356890247d108
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Tutorial.pod b01a546e52a908ce4ccd0b1a36fe81de52ab0691
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version.pm 91a7b2a36210cebd57ff89d202af3d2b7bce430c
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/regex.pm d4e7d722b4544be28da838912a7cc714528bc05f
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/version/vpp.pm 7297903505ab551731692ec79cdc0f5396e12479
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mkbootstrap.pm 58872d66a72515f7d5be02417dfd2b28005fd61a
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/Mksymlists.pm ab80029ab16d38d4f2e41dc88d2ceb9f3790e477
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM.pm 453e0abbc4bb38db4c0820ad5c4846f313b66291
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_AIX.pm c1b1babda8f43ae7a2caba1cb4f70f92af5a0e34
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Any.pm 6f90d94ad3e7aa0045a3b1a10a1bb18391f89f57
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_BeOS.pm cab2b3ce08b71a4ce89aa630f236eb08b852439d
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Cygwin.pm 61fced0faf518bf87c265fcb51ed330ba354623f
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Darwin.pm ae0ef51a7b6dd0b05aa61c779df7167dda5f5119
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_DOS.pm 9bff0fc8801d93578a5ac35d39f06cdc0e2af1ef
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_MacOS.pm 0544301f7121ff02fd3a11b73ca2fab22e1176d4
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_NW5.pm 433135eecb85b4b1d90d3027432f329436c78447
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_OS2.pm 1fbb5605bfb47feee4083feba8aa85e659628f70
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_QNX.pm 5b66d1f485a6034d96fc24ba1665b1bad9e447f1
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Unix.pm 8cef99a9bd370ecfd07ddb0efbdcbb4101255e45
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_UWIN.pm 939572fde3d59ba77c2e677fe2df2bed4bed5898
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VMS.pm 09c2049bfd25b735e2a5bcf56a6cff7b4827f9c8
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_VOS.pm d65d63f8217a55c36f62e249814988974f593c79
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win32.pm c0ae2a92a7a9f71fc5f608b4192c6255510b7ae4
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MM_Win95.pm 12df38eacceeed73cab94c423236bfaed0fbbfec
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/MY.pm 22fe9596a0237252f45399a36abc83b7813bc328
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/lib/ExtUtils/testlib.pm 7fbc42ca2ebc6c677b79ae5fd5647243cf069463
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/t/min_perl_version.t c36ce0442830b5b07702a988d415e9cc67a4e973
ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/t/pm_to_blib.t 71ebcee355691ce374fcad251b12d8b2412462b3
+ExtUtils::MakeMaker cpan/ExtUtils-MakeMaker/t/prereq_print.t 73e12a094c286921e2abf688eb49d0f4aad3e963
PerlIO::via::QuotedPrint cpan/PerlIO-via-QuotedPrint/t/QuotedPrint.t ca39f0146e89de02c746e199c45dcb3e5edad691
Text::ParseWords cpan/Text-ParseWords/t/ParseWords.t 9bae51c9b944cd5c0bbabe9d397e573976a2be8e
Win32API::File cpan/Win32API-File/buffers.h 02d230ac9ac7091365128161a0ed671898baefae
--
1.9.5.msysgit.0
|
From @bulk88On Thu Apr 09 19:08:04 2015, sisyphus wrote:
Server 2003 x64 running/compiling 32 bit perl. If you read the GH ticket Perl-Toolchain-Gang/ExtUtils-MakeMaker#193 you will see many other software projects have this problem and document it. -- |
From @bulk88On Thu Apr 09 22:03:03 2015, tonyc wrote:
The EUMM .t'es are passing with your patch but t/porting/utils.t is still failing. Maybe EUMM should be reverted to 7.02? # Porting/bisect-example.sh isn't a Perl script The reason for that is C:\p521\srcpara>perl -Ilib -MExtUtils::MakeMaker -e"0" C:\p521\srcpara> So should a new ticket be filed on GH or should EUMM be reverted in core or what? -- |
From @rjbsKaren points out Perl-Toolchain-Gang/ExtUtils-MakeMaker#193 which indicates that cda0edd in that repo should be a fix. Hopefully this means we have a way forward: we apply that locally, or we get an EUMM release cut with that fix (and as little as possible else.) |
From @bulk88On Mon Apr 27 15:30:45 2015, rjbs wrote:
commit https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/commit/cda0edd5067a2348f183d9100cc5b0fa92336937 became p5p patch https://rt-archive.perl.org/perl5/Ticket/Attachment/1339705/716378/0001-perl-123998-backport-cda0edd5-from-EU-MM-upstream.patch but that p5p patch is from a EUMM patch that stopped EUMM's tests from failing, it did not fix the underlying bug of that failure message from win32 shell being printed to STDERR every time you "require ExtUtils::MakeMaker;". That underlying bug means p5p test t/porting/utils.t fails. In any case, C:\p521\srcpara>perl -Ilib -MExtUtils::MakeMaker -e"0" C:\p521\srcpara> this is clearly a bug. Here is some manual bisecting I did to narrow the problem. ################################################################### Release engineering for v7.05_08 C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils Update bundled Encode::Locale to CPAN 1.04 C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils quote_literal PASTHRU_* as can have "" in C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils Back-compat linkext -> subdirs_(perl-linktype) if LINKTYPE= and DIR C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils Release engineering for v7.04 C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils Release engineering for v7.02 C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils Release engineering for v7.00 C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils Moved bundled Encode::Locale to EUMM::Locale instead C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils Release engineering for v6.99_12 C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils C:\sources\eumm> Release engineering for v6.98 C:\sources\eumm>C:\p521\srcpara\perl -Ilib -IC:\p521\srcpara\lib -MExtUtils::Ma C:\sources\eumm>C:\p521\srcpara\miniperl -Ilib -IC:\p521\srcpara\lib -MExtUtils C:\sources\eumm> Summary, last stable (I guess, if EUMM stables are even, odds are alpha) before the bug was 6.98. Last shipped release before the bug was 6.99_12. The commit directly after commit "Release engineering for v6.99_12" created the bug, name of the bug introducing commit is "Moved bundled Encode::Locale to EUMM::Locale instead". The bug lasts until commit "Update bundled Encode::Locale to CPAN 1.04", first shipped release with the fix is 7.05_08. -- |
From @iabynOn Mon, Apr 27, 2015 at 04:39:43PM -0700, bulk88 via RT wrote:
If I am reading the code correctly, the "fix" in 7.05_08 is that perl -MExtUtils::MakeMaker -e "0" no longer pollutes STDERR, but something that needs to know the code page Anyway, as a quick fix for 5.22, could we simply stop MakeMaker polluting qx(chcp) to or whatever similar win32-specific thing works? -- |
From @bulk88On Wed May 06 06:24:44 2015, davem wrote:
I did that in the attached patch. t/porting/utils.t also needs git in %PATH% to fail on win32, since if there is no working git, the whole file is skipped, and I dont always keep git in my %PATH% on win32. I dont personally like the idea of sending the error to null and I dont like the patch I wrote, since whatever info ("active code page") is collected will be wrong with no warning for EUMM users. IDK enough to say if having the wrong infp makes a difference in the end or not. -- |
From @bulk880001-fix-123998-suppress-stderr-noise-in-EUMM-if-Win32-ch.patchFrom 5d370191488b4e919956a033fa450813df23ee36 Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Fri, 8 May 2015 19:51:47 -0400
Subject: [PATCH] fix #123998 suppress stderr noise in EUMM if Win32 chcp tool
is not found
---
cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm
index f6edcf2..794f39e 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker/Locale.pm
@@ -47,7 +47,9 @@ sub _init {
$ENCODING_CONSOLE_OUT = "cp$cp" if $cp;
};
# Invoking the 'chcp' program might also work
- if (!$ENCODING_CONSOLE_IN && (qx(chcp) || '') =~ /^Active code page: (\d+)/) {
+ # 32bit chcp (which is used by 32 bit perl) is not available on
+ # Server 2003 x64, so suppress STDERR in case chcp isn't found
+ if (!$ENCODING_CONSOLE_IN && (qx(chcp 2>NUL) || '') =~ /^Active code page: (\d+)/) {
$ENCODING_CONSOLE_IN = "cp$1";
}
}
--
1.8.0.msysgit.0
|
From @tonycozOn Fri May 08 16:57:16 2015, bulk88 wrote:
With your patch it will fallback to the default, cp1252. For blead's purposes, sufficiently recent releases of Win32.pm include Tony |
From @iabynOn Sun, May 10, 2015 at 05:21:09PM -0700, Tony Cook via RT wrote:
I've pushed Daniel's patch for smoking as -- |
From @steve-m-hayOn 12 May 2015 at 17:41, Dave Mitchell <davem@iabyn.com> wrote:
Yes, update CUSTOMIZED and then run t/porting/customized.t --regen to |
From @bulk88On Tue May 12 09:41:58 2015, davem wrote:
The branch passes a harness run but there is some more chcp mop up to do. A patch for EUMM_Locale branch is attached. It probably should be squashed. On the EUMM_Locale branch this was happening. C:\p521\srcpara\t>perl harness ../cpan/ExtUtils-MakeMaker/t/basic.t C:\p521\srcpara\t>perl harness -v ../cpan/ExtUtils-MakeMaker/t/basic.t C:\p521\srcpara\t> C:\p521\srcpara\t> -- |
From @bulk880001-123998-more-chcp-calls-to-send-to-dev-null.patchFrom 2e70b04c73d37d7b71029a689de450e01621c505 Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Tue, 12 May 2015 18:56:01 -0400
Subject: [PATCH] #123998 more chcp calls to send to dev null
---
cpan/ExtUtils-MakeMaker/t/basic.t | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cpan/ExtUtils-MakeMaker/t/basic.t b/cpan/ExtUtils-MakeMaker/t/basic.t
index a0a6f91..d592dd8 100644
--- a/cpan/ExtUtils-MakeMaker/t/basic.t
+++ b/cpan/ExtUtils-MakeMaker/t/basic.t
@@ -34,10 +34,10 @@ my $perl = which_perl();
my $Is_VMS = $^O eq 'VMS';
my $OLD_CP; # crude but...
if ($^O eq "MSWin32") {
- $OLD_CP = $1 if qx(chcp) =~ /(\d+)$/ and $? == 0;
- qx(chcp 1252) if defined $OLD_CP;
+ $OLD_CP = $1 if qx(chcp 2>NUL) =~ /(\d+)$/ and $? == 0;
+ qx(chcp 1252 2>NUL) if defined $OLD_CP;
}
-END { qx(chcp $OLD_CP) if $^O eq "MSWin32" and defined $OLD_CP }
+END { qx(chcp $OLD_CP 2>NUL) if $^O eq "MSWin32" and defined $OLD_CP }
my $tmpdir = tempdir( DIR => 't', CLEANUP => 1 );
chdir $tmpdir;
--
1.8.0.msysgit.0
|
From @tonycozOn Sun May 10 17:21:09 2015, tonyc wrote:
It turns out the upstream of EUMM::Locale already does this, and EUMM::Locale Perl-Toolchain-Gang/ExtUtils-MakeMaker@1e2f087 I've pushed that change to smoke-me/tonyc/eumm-locale-update Tony |
From @bulk88On Tue May 12 17:32:10 2015, tonyc wrote:
Your branch passes. Same problem as in my last post about basic.t emitting warnings. I have no opinion whether davem's "2 > NUL" or your update EUMM Locale to dev version patch is the correct one. ../cpan/ExtUtils-Install/t/Installed.t ............................ ok -- |
From @iabynOn Tue, May 12, 2015 at 11:35:19PM -0700, bulk88 via RT wrote:
I know very little about either EU::MM nor win32, so I'm happy to defer to -- |
From @tonycozOn Tue May 12 23:35:18 2015, bulk88 wrote:
I've backported 37c498812ffa78926d4e4e3e5c5e219d4c405e36 which fixes this,
The warning from echo.t was in 5.20 and shouldn't be a blocker for 5.22. Tony |
From @bulk88On Wed May 13 21:18:52 2015, tonyc wrote:
SHA-1: 3c05f06 is okay to merge. No more "chcp" anywhere in a harness run. -- |
From @tonycozOn Thu May 14 10:01:40 2015, bulk88 wrote:
Thanks, both changes have been applied to blead as 18fe626 Tony |
@tonycoz - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for submitting this ticket. The issue should now be resolved with the release today of Perl v5.22, which is available at http://www.perl.org/get.html |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#123998 (status was 'resolved')
Searchable as RT123998$
The text was updated successfully, but these errors were encountered: