Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] fix segv for psudofork duping of SAVEt_GP_ALIASED_SV #14288

Closed
p5pRT opened this issue Dec 1, 2014 · 5 comments
Closed

[PATCH] fix segv for psudofork duping of SAVEt_GP_ALIASED_SV #14288

p5pRT opened this issue Dec 1, 2014 · 5 comments
Labels
distro-mswin32 type-core

Comments

@p5pRT
Copy link

p5pRT commented Dec 1, 2014

Migrated from rt.perl.org#123339 (status was 'resolved')

Searchable as RT123339$
@p5pRT
Copy link
Author

p5pRT commented Dec 1, 2014

From @bulk88

Created by @bulk88

See attached patch.

Perl Info 

Flags:
       category=core
       severity=low

Site configuration information for perl 5.21.7:

Configured by Owner at Sat Nov 22 21:54:54 2014.

Summary of my perl5 (revision 5 version 21 subversion 7) configuration:
     Local Commit: 1bce52df028aabe28c20b2d97949e35c17ea811e
     Ancestor: 7072da8afeba4c87ae623cd913e274396ffcf1cd
     Platform:
       osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread
       uname=''
       config_args='undef'
       hint=recommended, useposix=true, d_sigaction=undef
       useithreads=define, usemultiplicity=define
       use64bitint=undef, use64bitall=undef, uselongdouble=undef
       usemymalloc=n, bincompat5005=undef
     Compiler:
       cc='cl', ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -G7 -GL
-DWIN32 -D_CONSOLE -DNO_STRICT  -DPERL_TEXTMODE_SCRIPTS
-DPERL_HASH_FUNC_ONE_AT_A_TIME -DNO_MATHOMS -DPERL_IMPLICIT_CONTEXT
-DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T',
       optimize='-O1 -MD -Zi -DNDEBUG -G7 -GL',
       cppflags='-DWIN32'
       ccversion='13.10.6030', gccversion='', gccosandvers=''
       intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234,
doublekind=3
       d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8,
longdblkind=0
       ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64',
lseeksize=8
       alignbytes=8, prototype=define
     Linker and Libraries:
       ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf
-ltcg  -libpath:"c:\perl521\lib\CORE"  -machine:x86'
       libpth="C:\Program Files\Microsoft Visual Studio .NET 2003\VC7\lib"
       libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
       perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib
oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
       libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl521.lib
       gnulibc_version=''
     Dynamic Linking:
       dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
       cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug
-opt:ref,icf -ltcg  -libpath:"c:\perl521\lib\CORE"  -machine:x86'

Locally applied patches:
       ce7a4d57d0acca9f39a84d36d708c4505dfe45ca
       ca0b263f4b167ddf97416f657d79ab5bd3344357
       08919bf863666074243240abbd19cd1a74cc7b74
       b8a043377dbf39548709b107a11e5cc2714c0e9a
       efa855eb5cffb7739616c295dd968d1510efeeb0
       1d47d0b810e26d9a2f9101fb813bd5b3dd332cc9
       3faca062ddb056db54f73fa55b0a9d473675dd33
       0b3e905bda3e75ad948a1213f620656b60807393
       1b1efc719fde05d215e5a13fb38c03e12a3aab08
       1bce52df028aabe28c20b2d97949e35c17ea811e


@INC for perl 5.21.7:
       ..\lib
       C:/perl521/srcnewb4opt/lib
       .


Environment for perl 5.21.7:
       HOME (unset)
       LANG (unset)
       LANGUAGE (unset)
       LD_LIBRARY_PATH (unset)
       LOGDIR (unset)
       PATH=C:\WINDOWS\system32;C:\Program Files\Microsoft Visual Studio
.NET 2003\Vc7\bin;C:\Program Files\Microsoft Visual Studio .NET
2003\Common7\IDE;C:\WINDOWS;C:\Program Files\Git\cmd;C:\Program
Files\Microsoft Visual Studio .NET 2003\Common7\Tools\bin;C:\perl\bin
       PERL_BADLANG (unset)
       PERL_JSON_BACKEND=Cpanel::JSON::XS
       PERL_YAML_BACKEND=YAML
       SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Dec 1, 2014

From @bulk88

0001-fix-segv-for-psudofork-duping-of-SAVEt_GP_ALIASED_SV.patch 
From 6b5636d69153597b7fda8b8b86d2e51e11bcdf26 Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Mon, 1 Dec 2014 12:43:16 -0500
Subject: [PATCH] fix segv for psudofork duping of SAVEt_GP_ALIASED_SV

op/fork.t test 6 that contains "@a = (1..3);" will crash on Win32 with
special debugging heap and race condition rarely crash otherwise.
Refcnt mistake is from commit ff2a62e0c8 . See perl #40565 for details.
---
 sv.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/sv.c b/sv.c
index b1a5da5..a9be92c 100644
--- a/sv.c
+++ b/sv.c
@@ -14265,11 +14265,13 @@ Perl_ss_dup(pTHX_ PerlInterpreter *proto_perl, CLONE_PARAMS* param)
 	    ptr = POPPTR(ss,ix);
 	    TOPPTR(nss,ix) = parser_dup((const yy_parser*)ptr, param);
 	    break;
-        case SAVEt_GP_ALIASED_SV:
-	    ptr = POPPTR(ss,ix);
-	    TOPPTR(nss,ix) = gp_dup((GP *)ptr, param);
-	    ((GP *)ptr)->gp_refcnt++;
+	case SAVEt_GP_ALIASED_SV: {
+	    GP * gp_ptr = POPPTR(ss,ix);
+	    GP * new_gp_ptr = gp_dup(gp_ptr, param);
+	    TOPPTR(nss,ix) = new_gp_ptr;
+	    new_gp_ptr->gp_refcnt++;
 	    break;
+	}
 	default:
 	    Perl_croak(aTHX_
 		       "panic: ss_dup inconsistency (%"IVdf")", (IV) type);
-- 
1.7.9.msysgit.0

@p5pRT
Copy link
Author

p5pRT commented Dec 1, 2014

From @cpansprout

On Mon Dec 01 09​:44​:18 2014, bulk88 wrote​:

This is a bug report for perl from bulk88@​hotmail.com,
generated with the help of perlbug 1.40 running under perl 5.21.7.

-----------------------------------------------------------------
[Please describe your issue here]

See attached patch.

Thank you for fixing such a stupid error on my part. I have applied it as 64c909d.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Dec 1, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Dec 1, 2014

@cpansprout - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-mswin32 type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT