Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.21.5-77-g51a82aa breaks TIMB/Devel-NYTProf-5.06.tar.gz #14210

Closed
p5pRT opened this issue Nov 5, 2014 · 9 comments
Closed

Bleadperl v5.21.5-77-g51a82aa breaks TIMB/Devel-NYTProf-5.06.tar.gz #14210

p5pRT opened this issue Nov 5, 2014 · 9 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 5, 2014

Migrated from rt.perl.org#123134 (status was 'resolved')

Searchable as RT123134$

@p5pRT
Copy link
Author

p5pRT commented Nov 5, 2014

From @andk

git bisect


commit 51a82aa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Wed Oct 22 19​:32​:04 2014 -0700

  [perl #122695] Fix line number for else{foo}

sample fail report


http​://www.cpantesters.org/cpan/report/57794ab6-5b4c-11e4-8613-91e8bb36d621

perl -V


Summary of my perl5 (revision 5 version 21 subversion 6) configuration​:
  Commit id​: 51a82aa
  Platform​:
  osname=linux, osvers=3.16-2-amd64, archname=x86_64-linux-thread-multi-ld
  uname='linux k83 3.16-2-amd64 #1 smp debian 3.16.3-2 (2014-09-20) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.21.5-77-g51a82aa/a2da -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Duselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  use64bitint=define, use64bitall=define, uselongdouble=define
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion='', gccversion='4.9.1', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
  ivtype='long', ivsize=8, nvtype='long double', nvsize=16, Off_t='off_t', lseeksize=8
  alignbytes=16, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_ITHREADS USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_LONG_DOUBLE
  USE_PERLIO USE_PERL_ATOF USE_REENTRANT_API
  Built under linux
  Compiled at Oct 23 2014 06​:05​:20
  %ENV​:
  PERL5LIB=""
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="21933"
  PERL5_CPAN_IS_RUNNING="21933"
  PERL_MM_USE_DEFAULT="1"
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.5-77-g51a82aa/a2da/lib/site_perl/5.21.6/x86_64-linux-thread-multi-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.5-77-g51a82aa/a2da/lib/site_perl/5.21.6
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.5-77-g51a82aa/a2da/lib/5.21.6/x86_64-linux-thread-multi-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.5-77-g51a82aa/a2da/lib/5.21.6
  .
--
andreas

@p5pRT
Copy link
Author

p5pRT commented Nov 6, 2014

From @cpansprout

On Wed Nov 05 11​:30​:52 2014, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git bisect
----------
commit 51a82aa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Wed Oct 22 19​:32​:04 2014 -0700

[perl #122695] Fix line number for else{foo}

sample fail report
------------------
http​://www.cpantesters.org/cpan/report/57794ab6-5b4c-11e4-8613-
91e8bb36d621

Changes to line numbers (even fixes) are bound to break such sensitive tests. I don’t understand the test output, so I am cc’ing Tim Bunce with the hope that he can shed light on whether there really is a Perl bug here.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Nov 6, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 6, 2014

From @timbunce

The NYTProf tests are very sensitive to line number changes. I've not looked in-depth yet but I've looked closely enough to say that this looks like it's detecting the improved line numbering and that the tests need adjusting to handle that.

So this shouldn't be a blocker for perl.

And thanks, better line number accuracy is good!

@p5pRT
Copy link
Author

p5pRT commented Dec 13, 2014

From @jkeenan

On Thu Nov 06 03​:47​:38 2014, timbo wrote​:

The NYTProf tests are very sensitive to line number changes. I've not
looked in-depth yet but I've looked closely enough to say that this
looks like it's detecting the improved line numbering and that the
tests need adjusting to handle that.

So this shouldn't be a blocker for perl.

And thanks, better line number accuracy is good!

Tim​: I see that we have a passing cpantesters report for Devel-NYTProf-5.06_80 (Developer version) at​:

http​://www.cpantesters.org/cpan/report/d23be2dc-6582-11e4-aef9-bc9bbb36d621

Does that mean that this ticket is closable?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Dec 19, 2014

From @timbunce

On Fri, Dec 12, 2014 at 05​:12​:46PM -0800, James E Keenan via RT wrote​:

Tim​: I see that we have a passing cpantesters report for Devel-NYTProf-5.06_80 (Developer version) at​:
http​://www.cpantesters.org/cpan/report/d23be2dc-6582-11e4-aef9-bc9bbb36d621
Does that mean that this ticket is closable?

I hope to look into the state of this over the Christmas break.
Sorry for the delay James.

Tim.

@p5pRT
Copy link
Author

p5pRT commented Feb 21, 2015

From @timbunce

I've uploaded trial release (Devel-NYTProf-5.07-TRIAL1.tar.gz) that's
passing https://travis-ci.org/timbunce/devel-nytprof/builds/51595368

Once that smokes ok on cpantesters then I'll release it and we can close
this ticket. More news when I have it...

Tim.

@p5pRT
Copy link
Author

p5pRT commented Feb 21, 2015

From @timbunce

I've uploaded Devel-NYTProf-5.07 now.
I think this case can be closed.

@p5pRT p5pRT closed this as completed Feb 23, 2015
@p5pRT
Copy link
Author

p5pRT commented Feb 23, 2015

@iabyn - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant