Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl d8c6310a4f (Global symbol msg) breaks CPAN #14105

Closed
p5pRT opened this issue Sep 19, 2014 · 9 comments
Closed

Bleadperl d8c6310a4f (Global symbol msg) breaks CPAN #14105

p5pRT opened this issue Sep 19, 2014 · 9 comments

Comments

@p5pRT
Copy link

p5pRT commented Sep 19, 2014

Migrated from rt.perl.org#122814 (status was 'resolved')

Searchable as RT122814$

@p5pRT
Copy link
Author

p5pRT commented Sep 19, 2014

From @cpansprout

I haven’t got to testing them yet, but I suspect at least these modules’ tests will break, based on a CPAN grep​:

Acme​::use​::strict​::with​::pride
Apache​::EmbeddedPerl​::Lite
Coat
Config​::Vars
Dancer
DBIx​::VersionedSubs
Function​::Parameters
lib​::with​::preamble
Moose
MooseX​::Method​::Signatures
Mouse
Padre
Parse​::Keyword
triceps

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2014

From @jkeenan

On Fri Sep 19 16​:01​:00 2014, sprout wrote​:

I haven’t got to testing them yet, but I suspect at least these
modules’ tests will break, based on a CPAN grep​:

Acme​::use​::strict​::with​::pride
Apache​::EmbeddedPerl​::Lite
Coat
Config​::Vars
Dancer
DBIx​::VersionedSubs
Function​::Parameters
lib​::with​::preamble
Moose
MooseX​::Method​::Signatures
Mouse
Padre
Parse​::Keyword
triceps

This is the commit which we expect will cause some breakage -- correct?

#####
commit d8c6310
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Thu Sep 18 20​:34​:43 2014 -0700

[perl #121638] Make ‘Global symbol’ message more newbie-friendly by suggesting the declaration of a lexical variable, but without removing the ‘Global symbol’ part, since much code no doubt depends on its presence.
#####
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2014

From @jkeenan

On Fri Sep 19 16​:01​:00 2014, sprout wrote​:

I haven’t got to testing them yet, but I suspect at least these
modules’ tests will break, based on a CPAN grep​:

[snip]

Config​::Vars

Here's one case​:

#####
cpan[5]> test Config​::Vars
Running test for module 'Config​::Vars'
Fetching with LWP​:
http​://www.cpan.org/authors/id/R/RO/ROODE/Config-Vars-0.01.tar.gz
Fetching with LWP​:
http​://www.cpan.org/authors/id/R/RO/ROODE/CHECKSUMS
Checksum for /home/jkeenan/.cpan/sources/authors/id/R/RO/ROODE/Config-Vars-0.01.tar.gz ok
Configuring R/RO/ROODE/Config-Vars-0.01.tar.gz with Makefile.PL
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Config​::Vars
Writing MYMETA.yml and MYMETA.json
  ROODE/Config-Vars-0.01.tar.gz
  /home/jkeenan/testing/blead/bin/perl5.21.4 Makefile.PL INSTALLDIRS=site -- OK
Running make for R/RO/ROODE/Config-Vars-0.01.tar.gz
cp Vars.pm blib/lib/Config/Vars.pm
Manifying blib/man3/Config​::Vars.3
  ROODE/Config-Vars-0.01.tar.gz
  /usr/bin/make -- OK
Running make test
PERL_DL_NONLAZY=1 /home/jkeenan/testing/blead/bin/perl5.21.4 "-MExtUtils​::Command​::MM" "-MTest​::Harness" "-e" "undef *Test​::Harness​::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/export.t .. 1/2
# Failed test 'No default export'
# at t/export.t line 13.
# 'Global symbol "$cat" requires explicit package name (did you forget to declare "my $cat"?) at (eval 11) line 2.
# '
# doesn't match '(?^​:^Global symbol "\$cat\" requires explicit package name at)'
# Looks like you failed 1 test of 2.
#####

... which would be fixable simply by trimming 3 characters from the pattern.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 20, 2014

From @cpansprout

On Fri Sep 19 20​:28​:18 2014, jkeenan wrote​:

This is the commit which we expect will cause some breakage --
correct?

Yes.

#####
commit d8c6310
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Thu Sep 18 20​:34​:43 2014 -0700

[perl #121638] Make ‘Global symbol’ message more newbie-friendly by
suggesting the declaration of a lexical variable, but without removing
the ‘Global symbol’ part, since much code no doubt depends on its
presence.
#####

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Sep 22, 2014

From @andk

On Fri, 19 Sep 2014 16​:01​:00 -0700, Father Chrysostomos (via RT) <perlbug-followup@​perl.org> said​:

  > # New Ticket Created by Father Chrysostomos
  > # Please include the string​: [perl #122814]
  > # in the subject line of all future correspondence about this issue.
  > # <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=122814 >

  > I haven’t got to testing them yet, but I suspect at least these modules’ tests will break, based on a CPAN grep​:

  > [...]

Also affected​: ZOFFIX/Test-Synopsis-0.10.tar.gz http​://www.cpantesters.org/cpan/report/78770368-4065-11e4-b6a6-68612c6f0924

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Oct 3, 2014

From @cpansprout

Summary​:

Fixed version already released​:

- DBIx​::VersionedSubs
- lib​::with​::preamble
- Moose
- MooseX​::Method​::Signatures
- Mouse

Already broken in 5.12 or earlier​:

- Acme​::use​::strict​::with​::pride

Patches submitted​:

- Apache​::EmbeddedPerl​::Lite
- Coat
- Config​::Vars
- Dancer
- Function​::Parameters
- Padre
- Parse​::Keyword
- triceps

And finally, one of the contributors says he will fix this soon​:

- Test-Synopsis

(See <https://github.com/miyagawa/test-synopsis/issues/11>.)

Of the last 9 modules/distributions mentioned, only Dancer, Function​::Parameters, Padre and Parse​::Keyword have other things depending on them.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Oct 3, 2014

From @cpansprout

On Fri Oct 03 14​:42​:44 2014, sprout wrote​:

Of the last 9 modules/distributions mentioned, only Dancer,
Function​::Parameters, Padre and Parse​::Keyword have other things
depending on them.

I’ve mentioned those four in the Known Problems section of perl5220delta in commit 013f94d.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Oct 3, 2014

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant