From @andk

git bisect

commit cfc7ef1
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Sep 8 22​:37​:46 2014 -0700

  Stop barewords from trumping subs with (*) proto

sample fail report

http​://www.cpantesters.org/cpan/report/cf0d975e-3850-11e4-9db3-e2a5cc4edbc1

perl -V

Summary of my perl5 (revision 5 version 21 subversion 4) configuration​:
  Commit id​: c4c61c6
  Platform​:
  osname=linux, osvers=3.14-2-amd64, archname=x86_64-linux-thread-multi
  uname='linux k83 3.14-2-amd64 #1 smp debian 3.14.15-2 (2014-08-09) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-525-gc4c61c6/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.9.1', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_ITHREADS USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO
  USE_PERL_ATOF USE_REENTRANT_API
  Built under linux
  Compiled at Sep 9 2014 17​:55​:14
  %ENV​:
  PERL5LIB=""
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="27878"
  PERL5_CPAN_IS_RUNNING="27878"
  PERL_MM_USE_DEFAULT="1"
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-525-gc4c61c6/9980/lib/site_perl/5.21.4/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-525-gc4c61c6/9980/lib/site_perl/5.21.4
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-525-gc4c61c6/9980/lib/5.21.4/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.3-525-gc4c61c6/9980/lib/5.21.4
  .
--
andreas

From @jkeenan

On Wed Sep 10 20​:10​:29 2014, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git bisect
----------
commit cfc7ef1
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Sep 8 22​:37​:46 2014 -0700

Stop barewords from trumping subs with (*) proto

sample fail report
------------------
http​://www.cpantesters.org/cpan/report/cf0d975e-3850-11e4-9db3-
e2a5cc4edbc1

Breakage confirmed at commit 0eb7ca0.

$ ~/testing/blead/bin/prove -I./lib -vb t/*.t
t/example1.t ..
1..2
Not a GLOB reference at /home/jkeenan/.cpan/build/Hook-LexWrap-0.24-41H4Bj/blib/lib/Hook/LexWrap.pm line 34.
# Looks like your test exited with 255 before it could output anything.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests
[snip]
t/test.t ...... Can't wrap non-existent subroutine main​::1 at t/test.t line 15.

--
James E Keenan (jkeenan@​cpan.org)

The RT System itself - Status changed from 'new' to 'open'

From @cpansprout

On Thu Sep 11 16​:45​:15 2014, jkeenan wrote​:

On Wed Sep 10 20​:10​:29 2014, andreas.koenig.7os6VVqR@​franz.ak.mind.de
wrote​:

git bisect
----------
commit cfc7ef1
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Sep 8 22​:37​:46 2014 -0700

Stop barewords from trumping subs with (*) proto

sample fail report
------------------
http​://www.cpantesters.org/cpan/report/cf0d975e-3850-11e4-9db3-
e2a5cc4edbc1

Breakage confirmed at commit 0eb7ca0.

$ ~/testing/blead/bin/prove -I./lib -vb t/*.t
t/example1.t ..
1..2
Not a GLOB reference at /home/jkeenan/.cpan/build/Hook-LexWrap-0.24-
41H4Bj/blib/lib/Hook/LexWrap.pm line 34.
# Looks like your test exited with 255 before it could output
anything.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests
[snip]
t/test.t ...... Can't wrap non-existent subroutine main​::1 at t/test.t
line 15.

The tests are depending on the ability of the * prototype to override a sub call and change a bareword into a string.

If we fix the tests, then these two modules that use it will fail​:

Acme​::ComeFrom
RT​::Crypt​::SMIME

I’m not worried about Acme​::ComeFrom. So it looks as though our net breakage is 2 modules. Hook​::LexWrap’s tests need to be fixed and its documentation changed to encourage fat arrows or explicit initial splats. RT​::Crypt​::SMIME just needs a pair of quotation marks.

Considering the small degree of breakage, is it worth going back to the insanity we had before?

--

Father Chrysostomos

From @demerphq

On 12 September 2014 07​:09, Father Chrysostomos via RT <
perlbug-followup@​perl.org> wrote​:

On Thu Sep 11 16​:45​:15 2014, jkeenan wrote​:

On Wed Sep 10 20​:10​:29 2014, andreas.koenig.7os6VVqR@​franz.ak.mind.de
wrote​:

git bisect
----------
commit cfc7ef1
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Sep 8 22​:37​:46 2014 -0700

Stop barewords from trumping subs with (*) proto

sample fail report
------------------
http​://www.cpantesters.org/cpan/report/cf0d975e-3850-11e4-9db3-
e2a5cc4edbc1

Breakage confirmed at commit 0eb7ca0.

$ ~/testing/blead/bin/prove -I./lib -vb t/*.t
t/example1.t ..
1..2
Not a GLOB reference at /home/jkeenan/.cpan/build/Hook-LexWrap-0.24-
41H4Bj/blib/lib/Hook/LexWrap.pm line 34.
# Looks like your test exited with 255 before it could output
anything.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests
[snip]
t/test.t ...... Can't wrap non-existent subroutine main​::1 at t/test.t
line 15.

The tests are depending on the ability of the * prototype to override a
sub call and change a bareword into a string.

If we fix the tests, then these two modules that use it will fail​:

Acme​::ComeFrom
RT​::Crypt​::SMIME

I’m not worried about Acme​::ComeFrom. So it looks as though our net
breakage is 2 modules. Hook​::LexWrap’s tests need to be fixed and its
documentation changed to encourage fat arrows or explicit initial splats.
RT​::Crypt​::SMIME just needs a pair of quotation marks.

Considering the small degree of breakage, is it worth going back to the
insanity we had before?

IMO, no, your patch should stay and the modules be fixed.

Yves
--
perl -Mre=debug -e "/just|another|perl|hacker/"

From @jkeenan

On Fri Sep 12 07​:40​:07 2014, demerphq wrote​:

On 12 September 2014 07​:09, Father Chrysostomos via RT <
perlbug-followup@​perl.org> wrote​:

On Thu Sep 11 16​:45​:15 2014, jkeenan wrote​:

On Wed Sep 10 20​:10​:29 2014, andreas.koenig.7os6VVqR@​franz.ak.mind.de
wrote​:

git bisect
----------
commit cfc7ef1
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Sep 8 22​:37​:46 2014 -0700

Stop barewords from trumping subs with (*) proto

sample fail report
------------------
http​://www.cpantesters.org/cpan/report/cf0d975e-3850-11e4-9db3-
e2a5cc4edbc1

Breakage confirmed at commit 0eb7ca0.

$ ~/testing/blead/bin/prove -I./lib -vb t/*.t
t/example1.t ..
1..2
Not a GLOB reference at /home/jkeenan/.cpan/build/Hook-LexWrap-0.24-
41H4Bj/blib/lib/Hook/LexWrap.pm line 34.
# Looks like your test exited with 255 before it could output
anything.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests
[snip]
t/test.t ...... Can't wrap non-existent subroutine main​::1 at t/test.t
line 15.

The tests are depending on the ability of the * prototype to override a
sub call and change a bareword into a string.

If we fix the tests, then these two modules that use it will fail​:

Acme​::ComeFrom
RT​::Crypt​::SMIME

I’m not worried about Acme​::ComeFrom. So it looks as though our net
breakage is 2 modules. Hook​::LexWrap’s tests need to be fixed and its
documentation changed to encourage fat arrows or explicit initial splats.
RT​::Crypt​::SMIME just needs a pair of quotation marks.

Considering the small degree of breakage, is it worth going back to the
insanity we had before?

IMO, no, your patch should stay and the modules be fixed.

Yves

Filed bug ticket for Hook-LexWrap​:

https://rt.cpan.org/Ticket/Display.html?id=99021
--
James E Keenan (jkeenan@​cpan.org)

From @cpansprout

On Sun Sep 21 11​:02​:41 2014, jkeenan wrote​:

Filed bug ticket for Hook-LexWrap​:

https://rt.cpan.org/Ticket/Display.html?id=99021

I’ve posted a patch to that ticket and mentioned Hook​::LexWrap in the Known Problems section of Porting/perl5220delta.pod, added for that purpose. (Commits 634acdc and 3cbddcc.)

I submitted a patch for RT​::Crypt​::SMIME at <https://rt.cpan.org/Ticket/Display.html?id=99025>.

--

Father Chrysostomos

@cpansprout - Status changed from 'open' to 'rejected'